2 * Copyright (c) 2007 Scott Long
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions, and the following disclaimer,
10 * without modification, immediately at the beginning of the file.
11 * 2. The name of the author may not be used to endorse or promote products
12 * derived from this software without specific prior written permission.
14 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
15 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
17 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
18 * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
19 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
20 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
21 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
22 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
23 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
28 * scsi_sg peripheral driver. This driver is meant to implement the Linux
29 * SG passthrough interface for SCSI.
32 #include <sys/param.h>
33 #include <sys/systm.h>
34 #include <sys/kernel.h>
35 #include <sys/types.h>
39 #include <sys/malloc.h>
40 #include <sys/fcntl.h>
41 #include <sys/errno.h>
42 #include <sys/devicestat.h>
45 #include <sys/device.h>
46 #include <sys/sysmsg.h>
49 #include "../cam_ccb.h"
50 #include "../cam_periph.h"
51 #include "../cam_queue.h"
52 #include "../cam_xpt_periph.h"
53 #include "../cam_debug.h"
54 #include "../cam_sim.h"
57 #include "scsi_message.h"
62 SG_FLAG_LOCKED = 0x02,
63 SG_FLAG_INVALID = 0x04
82 #define ccb_type ppriv_field0
83 #define ccb_rdwr ppriv_ptr1
86 TAILQ_ENTRY(sg_rdwr) rdwr_link;
94 struct sg_io_hdr io_hdr;
101 struct devstat device_stats;
102 TAILQ_HEAD(, sg_rdwr) rdwr_done;
110 static d_open_t sgopen;
111 static d_close_t sgclose;
112 static d_ioctl_t sgioctl;
113 static d_write_t sgwrite;
114 static d_read_t sgread;
116 static periph_init_t sginit;
117 static periph_ctor_t sgregister;
118 static periph_oninv_t sgoninvalidate;
119 static periph_dtor_t sgcleanup;
120 static periph_start_t sgstart;
121 static void sgasync(void *callback_arg, uint32_t code,
122 struct cam_path *path, void *arg);
123 static void sgdone(struct cam_periph *periph, union ccb *done_ccb);
124 static int sgsendccb(struct cam_periph *periph, union ccb *ccb);
125 static int sgsendrdwr(struct cam_periph *periph, union ccb *ccb);
126 static int sgerror(union ccb *ccb, uint32_t cam_flags,
127 uint32_t sense_flags);
128 static void sg_scsiio_status(struct ccb_scsiio *csio,
129 u_short *hoststat, u_short *drvstat);
131 static int scsi_group_len(u_char cmd);
133 static struct periph_driver sgdriver =
136 TAILQ_HEAD_INITIALIZER(sgdriver.units), /* gen */ 0
138 PERIPHDRIVER_DECLARE(sg, sgdriver);
140 static struct dev_ops sg_ops = {
141 { "sg", 0, D_DISK | D_MPSAFE },
149 static int sg_version = 30125;
157 * Install a global async callback. This callback will receive aync
158 * callbacks like "new device found".
160 status = xpt_register_async(AC_FOUND_DEVICE, sgasync, NULL, NULL);
162 if (status != CAM_REQ_CMP) {
163 kprintf("sg: Failed to attach master async callbac "
164 "due to status 0x%x!\n", status);
169 sgoninvalidate(struct cam_periph *periph)
171 struct sg_softc *softc;
173 softc = (struct sg_softc *)periph->softc;
176 * Deregister any async callbacks.
178 xpt_register_async(0, sgasync, periph, periph->path);
180 softc->flags |= SG_FLAG_INVALID;
183 * XXX Return all queued I/O with ENXIO.
184 * XXX Handle any transactions queued to the card
185 * with XPT_ABORT_CCB.
189 xpt_print(periph->path, "lost device\n");
194 sgcleanup(struct cam_periph *periph)
196 struct sg_softc *softc;
198 softc = (struct sg_softc *)periph->softc;
200 xpt_print(periph->path, "removing device entry\n");
201 devstat_remove_entry(&softc->device_stats);
202 cam_periph_unlock(periph);
203 destroy_dev(softc->dev);
204 cam_periph_lock(periph);
205 kfree(softc, M_DEVBUF);
209 sgasync(void *callback_arg, uint32_t code, struct cam_path *path, void *arg)
211 struct cam_periph *periph;
213 periph = (struct cam_periph *)callback_arg;
216 case AC_FOUND_DEVICE:
218 struct ccb_getdev *cgd;
221 cgd = (struct ccb_getdev *)arg;
226 if (cgd->protocol != PROTO_SCSI)
231 * Allocate a peripheral instance for this device and
232 * start the probe process.
234 status = cam_periph_alloc(sgregister, sgoninvalidate,
236 "sg", CAM_PERIPH_BIO, cgd->ccb_h.path,
237 sgasync, AC_FOUND_DEVICE, cgd);
238 if ((status != CAM_REQ_CMP) && (status != CAM_REQ_INPROG)) {
239 const struct cam_status_entry *entry;
241 entry = cam_fetch_status_entry(status);
242 kprintf("sgasync: Unable to attach new device "
243 "due to status %#x: %s\n", status, entry ?
244 entry->status_text : "Unknown");
249 cam_periph_async(periph, code, path, arg);
255 sgregister(struct cam_periph *periph, void *arg)
257 struct sg_softc *softc;
258 struct ccb_getdev *cgd;
261 cgd = (struct ccb_getdev *)arg;
262 if (periph == NULL) {
263 kprintf("sgregister: periph was NULL!!\n");
264 return (CAM_REQ_CMP_ERR);
268 kprintf("sgregister: no getdev CCB, can't register device\n");
269 return (CAM_REQ_CMP_ERR);
272 softc = kmalloc(sizeof(*softc), M_DEVBUF, M_WAITOK | M_ZERO);
273 softc->state = SG_STATE_NORMAL;
274 softc->pd_type = SID_TYPE(&cgd->inq_data);
275 softc->sg_timeout = SG_DEFAULT_TIMEOUT / SG_DEFAULT_HZ * hz;
276 softc->sg_user_timeout = SG_DEFAULT_TIMEOUT;
277 TAILQ_INIT(&softc->rdwr_done);
278 periph->softc = softc;
281 * We pass in 0 for all blocksize, since we don't know what the
282 * blocksize of the device is, if it even has a blocksize.
284 cam_periph_unlock(periph);
285 no_tags = (cgd->inq_data.flags & SID_CmdQue) == 0;
286 devstat_add_entry(&softc->device_stats, "sg",
287 periph->unit_number, 0,
288 DEVSTAT_NO_BLOCKSIZE |
289 (no_tags ? DEVSTAT_NO_ORDERED_TAGS : 0),
291 DEVSTAT_TYPE_IF_SCSI | DEVSTAT_PRIORITY_PASS,
292 DEVSTAT_PRIORITY_PASS);
294 /* Register the device */
295 softc->dev = make_dev(&sg_ops, periph->unit_number,
296 UID_ROOT, GID_OPERATOR, 0600, "%s%d",
297 periph->periph_name, periph->unit_number);
298 make_dev_alias(softc->dev, "sg%c", 'a' + periph->unit_number);
299 cam_periph_lock(periph);
300 softc->dev->si_drv1 = periph;
303 * Add as async callback so that we get
304 * notified if this device goes away.
306 xpt_register_async(AC_LOST_DEVICE, sgasync, periph, periph->path);
310 xpt_announce_periph(periph, NULL);
313 return (CAM_REQ_CMP);
317 sgstart(struct cam_periph *periph, union ccb *start_ccb)
319 struct sg_softc *softc;
321 softc = (struct sg_softc *)periph->softc;
323 switch (softc->state) {
324 case SG_STATE_NORMAL:
325 start_ccb->ccb_h.ccb_type = SG_CCB_WAITING;
326 SLIST_INSERT_HEAD(&periph->ccb_list, &start_ccb->ccb_h,
328 periph->immediate_priority = CAM_PRIORITY_NONE;
329 wakeup(&periph->ccb_list);
335 sgdone(struct cam_periph *periph, union ccb *done_ccb)
337 struct sg_softc *softc;
338 struct ccb_scsiio *csio;
340 softc = (struct sg_softc *)periph->softc;
341 csio = &done_ccb->csio;
343 switch (csio->ccb_h.ccb_type) {
345 /* Caller will release the CCB */
346 wakeup(&done_ccb->ccb_h.cbfcnp);
350 struct sg_rdwr *rdwr;
352 devstat_end_transaction(
353 &softc->device_stats,
355 csio->tag_action & 0xf,
356 ((csio->ccb_h.flags & CAM_DIR_MASK) ==
357 CAM_DIR_NONE) ? DEVSTAT_NO_DATA :
358 ((csio->ccb_h.flags & CAM_DIR_OUT) ?
359 DEVSTAT_WRITE : DEVSTAT_READ));
361 rdwr = done_ccb->ccb_h.ccb_rdwr;
362 rdwr->state = SG_RDWR_DONE;
367 wakeup(&done_ccb->ccb_h.cbfcnp);
370 panic("unknown sg CCB type");
375 sgopen(struct dev_open_args *ap)
376 /*cdev_t dev, int flags, int fmt, struct thread *td)*/
378 struct cam_periph *periph;
379 struct sg_softc *softc;
383 * Disallow CAM access if RESTRICTEDROOT
385 if (caps_priv_check_self(SYSCAP_RESTRICTEDROOT))
388 periph = (struct cam_periph *)ap->a_head.a_dev->si_drv1;
393 * Don't allow access when we're running at a high securelevel.
395 if (securelevel > 1) {
396 cam_periph_unlock(periph);
397 cam_periph_release(periph);
400 cam_periph_lock(periph);
402 softc = (struct sg_softc *)periph->softc;
403 if (softc->flags & SG_FLAG_INVALID) {
404 cam_periph_unlock(periph);
408 if ((softc->flags & SG_FLAG_OPEN) == 0) {
409 softc->flags |= SG_FLAG_OPEN;
410 cam_periph_unlock(periph);
412 /* Device closes aren't symmetrical, fix up the refcount. */
413 cam_periph_unlock(periph);
414 cam_periph_release(periph);
421 sgclose(struct dev_close_args *ap)
422 /* cdev_t dev, int flag, int fmt, struct thread *td) */
424 struct cam_periph *periph;
425 struct sg_softc *softc;
427 periph = (struct cam_periph *)ap->a_head.a_dev->si_drv1;
431 cam_periph_lock(periph);
433 softc = (struct sg_softc *)periph->softc;
434 softc->flags &= ~SG_FLAG_OPEN;
436 cam_periph_unlock(periph);
437 cam_periph_release(periph);
443 sgioctl(struct dev_ioctl_args *ap)
444 /* cdev_t dev, u_long cmd, caddr_t arg, int flag, struct thread *td) */
447 struct ccb_scsiio *csio;
448 struct cam_periph *periph;
449 struct sg_softc *softc;
450 struct sg_io_hdr req;
453 periph = (struct cam_periph *)ap->a_head.a_dev->si_drv1;
457 cam_periph_lock(periph);
459 softc = (struct sg_softc *)periph->softc;
464 case LINUX_SCSI_GET_BUS_NUMBER: {
467 busno = xpt_path_path_id(periph->path);
468 error = copyout(&busno, ap->a_data, sizeof(busno));
471 case LINUX_SCSI_GET_IDLUN: {
472 struct scsi_idlun idlun;
475 idlun.dev_id = xpt_path_target_id(periph->path);
476 sim = xpt_path_sim(periph->path);
477 idlun.host_unique_id = sim->unit_number;
478 error = copyout(&idlun, ap->a_data, sizeof(idlun));
482 case SG_GET_VERSION_NUM:
483 error = copyout(&sg_version, ap->a_data, sizeof(sg_version));
485 case SG_SET_TIMEOUT: {
488 error = copyin(ap->a_data, &user_timeout, sizeof(u_int));
490 softc->sg_user_timeout = user_timeout;
491 softc->sg_timeout = user_timeout / SG_DEFAULT_HZ * hz;
497 * The value is returned directly to the syscall.
499 ap->a_sysmsg->sysmsg_result = softc->sg_user_timeout;
503 error = copyin(ap->a_data, &req, sizeof(req));
507 if (req.cmd_len > IOCDBLEN) {
512 if (req.iovec_count != 0) {
517 ccb = cam_periph_getccb(periph, /*priority*/5);
518 ccb->ccb_h.ccb_type = SG_CCB_POLLED;
521 error = copyin(req.cmdp, &csio->cdb_io.cdb_bytes, req.cmd_len);
523 xpt_release_ccb(ccb);
527 switch(req.dxfer_direction) {
528 case SG_DXFER_TO_DEV:
531 case SG_DXFER_FROM_DEV:
534 case SG_DXFER_TO_FROM_DEV:
535 dir = CAM_DIR_IN | CAM_DIR_OUT;
554 error = sgsendccb(periph, ccb);
556 req.host_status = DID_ERROR;
557 req.driver_status = DRIVER_INVALID;
558 xpt_release_ccb(ccb);
562 req.status = csio->scsi_status;
563 req.masked_status = (csio->scsi_status >> 1) & 0x7f;
564 sg_scsiio_status(csio, &req.host_status, &req.driver_status);
565 req.resid = csio->resid;
566 req.duration = csio->ccb_h.timeout;
569 error = copyout(&req, ap->a_data, sizeof(req));
570 if ((error == 0) && (csio->ccb_h.status & CAM_AUTOSNS_VALID)
571 && (req.sbp != NULL)) {
572 req.sb_len_wr = req.mx_sb_len - csio->sense_resid;
573 error = copyout(&csio->sense_data, req.sbp,
577 xpt_release_ccb(ccb);
580 case SG_GET_RESERVED_SIZE: {
583 error = copyout(&size, ap->a_data, sizeof(size));
589 struct sg_scsi_id id;
591 id.host_no = 0; /* XXX */
592 id.channel = xpt_path_path_id(periph->path);
593 id.scsi_id = xpt_path_target_id(periph->path);
594 id.lun = xpt_path_lun_id(periph->path);
595 id.scsi_type = softc->pd_type;
596 id.h_cmd_per_lun = 1;
597 id.d_queue_depth = 1;
601 error = copyout(&id, ap->a_data, sizeof(id));
605 case SG_EMULATED_HOST:
606 case SG_SET_TRANSFORM:
607 case SG_GET_TRANSFORM:
608 case SG_GET_NUM_WAITING:
610 case SG_GET_REQUEST_TABLE:
611 case SG_SET_KEEP_ORPHAN:
612 case SG_GET_KEEP_ORPHAN:
613 case SG_GET_ACCESS_COUNT:
614 case SG_SET_FORCE_LOW_DMA:
616 case SG_GET_SG_TABLESIZE:
617 case SG_SET_FORCE_PACK_ID:
619 case SG_SET_RESERVED_SIZE:
620 case SG_GET_COMMAND_Q:
621 case SG_SET_COMMAND_Q:
623 case SG_NEXT_CMD_LEN:
626 kprintf("sgioctl: rejecting cmd 0x%lx\n", ap->a_cmd);
632 cam_periph_unlock(periph);
637 sgwrite(struct dev_write_args *ap)
638 /*cdev_t dev, struct uio *uio, int ioflag)*/
641 struct cam_periph *periph;
642 struct ccb_scsiio *csio;
644 struct sg_header *hdr;
645 struct sg_rdwr *rdwr;
648 int error = 0, cdb_len, buf_len, dir;
649 struct uio *uio = ap->a_uio;
651 periph = ap->a_head.a_dev->si_drv1;
652 rdwr = kmalloc(sizeof(*rdwr), M_DEVBUF, M_WAITOK | M_ZERO);
653 hdr = &rdwr->hdr.hdr;
655 /* Copy in the header block and sanity check it */
656 if (uio->uio_resid < sizeof(*hdr)) {
660 error = uiomove((char *)hdr, sizeof(*hdr), uio);
664 ccb = xpt_alloc_ccb();
672 * Copy in the CDB block. The designers of the interface didn't
673 * bother to provide a size for this in the header, so we have to
674 * figure it out ourselves.
676 if (uio->uio_resid < 1)
678 error = uiomove(&cdb_cmd, 1, uio);
681 if (hdr->twelve_byte)
684 cdb_len = scsi_group_len(cdb_cmd);
686 * We've already read the first byte of the CDB and advanced the uio
687 * pointer. Just read the rest.
689 csio->cdb_io.cdb_bytes[0] = cdb_cmd;
690 error = uiomove(&csio->cdb_io.cdb_bytes[1], cdb_len - 1, uio);
695 * Now set up the data block. Again, the designers didn't bother
696 * to make this reliable.
698 buf_len = uio->uio_resid;
700 buf = kmalloc(buf_len, M_DEVBUF, M_WAITOK | M_ZERO);
701 error = uiomove(buf, buf_len, uio);
705 } else if (hdr->reply_len != 0) {
706 buf = kmalloc(hdr->reply_len, M_DEVBUF, M_WAITOK | M_ZERO);
707 buf_len = hdr->reply_len;
715 cam_periph_lock(periph);
717 xpt_setup_ccb(&ccb->ccb_h, periph->path, /*priority*/5);
730 * Send off the command and hope that it works. This path does not
731 * go through sgstart because the I/O is supposed to be asynchronous.
734 rdwr->buf_len = buf_len;
735 rdwr->tag = hdr->pack_id;
737 rdwr->state = SG_RDWR_INPROG;
738 ccb->ccb_h.ccb_rdwr = rdwr;
739 ccb->ccb_h.ccb_type = SG_CCB_RDWR_IO;
740 TAILQ_INSERT_TAIL(&sc->rdwr_done, rdwr, rdwr_link);
741 error = sgsendrdwr(periph, ccb);
742 cam_periph_unlock(periph);
746 kfree(buf, M_DEVBUF);
748 xpt_free_ccb(&ccb->ccb_h);
750 kfree(rdwr, M_DEVBUF);
755 sgread(struct dev_read_args *ap)
756 /*cdev_t dev, struct uio *uio, int ioflag)*/
758 struct ccb_scsiio *csio;
759 struct cam_periph *periph;
761 struct sg_header *hdr;
762 struct sg_rdwr *rdwr;
763 u_short hstat, dstat;
764 int error, pack_len, reply_len, pack_id;
765 struct uio *uio = ap->a_uio;
767 periph = ap->a_head.a_dev->si_drv1;
769 /* XXX The pack len field needs to be updated and written out instead
770 * of discarded. Not sure how to do that.
772 uio->uio_rw = UIO_WRITE;
773 if ((error = uiomove((char *)&pack_len, 4, uio)) != 0)
775 if ((error = uiomove((char *)&reply_len, 4, uio)) != 0)
777 if ((error = uiomove((char *)&pack_id, 4, uio)) != 0)
779 uio->uio_rw = UIO_READ;
781 cam_periph_lock(periph);
784 TAILQ_FOREACH(rdwr, &sc->rdwr_done, rdwr_link) {
785 if (rdwr->tag == pack_id)
789 cam_periph_unlock(periph);
790 if (tsleep(&hstat, PCATCH, "sgnull", 0) == ERESTART)
792 cam_periph_lock(periph);
795 if (rdwr->state != SG_RDWR_DONE) {
796 tsleep_interlock(rdwr, PCATCH);
797 cam_periph_unlock(periph);
798 if (rdwr->state != SG_RDWR_DONE) {
799 if (tsleep(rdwr, PCATCH | PINTERLOCKED, "sgread", 0) ==
804 cam_periph_lock(periph);
807 TAILQ_REMOVE(&sc->rdwr_done, rdwr, rdwr_link);
808 cam_periph_unlock(periph);
810 hdr = &rdwr->hdr.hdr;
811 csio = &rdwr->ccb->csio;
812 sg_scsiio_status(csio, &hstat, &dstat);
813 hdr->host_status = hstat;
814 hdr->driver_status = dstat;
815 hdr->target_status = csio->scsi_status >> 1;
819 case DID_PASSTHROUGH:
839 if (dstat == DRIVER_SENSE) {
840 bcopy(&csio->sense_data, hdr->sense_buffer,
841 min(csio->sense_len, SG_MAX_SENSE));
843 scsi_sense_print(csio);
847 error = uiomove((char *)&hdr->result, sizeof(*hdr) -
848 offsetof(struct sg_header, result), uio);
849 if ((error == 0) && (hdr->result == 0))
850 error = uiomove(rdwr->buf, rdwr->buf_len, uio);
852 cam_periph_lock(periph);
853 xpt_free_ccb(&rdwr->ccb->ccb_h);
854 cam_periph_unlock(periph);
855 kfree(rdwr->buf, M_DEVBUF);
856 kfree(rdwr, M_DEVBUF);
861 sgsendccb(struct cam_periph *periph, union ccb *ccb)
863 struct sg_softc *softc;
864 struct cam_periph_map_info mapinfo;
865 int error, need_unmap = 0;
867 softc = periph->softc;
868 if (((ccb->ccb_h.flags & CAM_DIR_MASK) != CAM_DIR_NONE)
869 && (ccb->csio.data_ptr != NULL)) {
870 bzero(&mapinfo, sizeof(mapinfo));
873 * cam_periph_mapmem calls into proc and vm functions that can
874 * sleep as well as trigger I/O, so we can't hold the lock.
875 * Dropping it here is reasonably safe.
877 cam_periph_unlock(periph);
878 error = cam_periph_mapmem(ccb, &mapinfo);
879 cam_periph_lock(periph);
885 error = cam_periph_runccb(ccb, sgerror, CAM_RETRY_SELTO,
886 SF_RETRY_UA, &softc->device_stats);
889 cam_periph_unmapmem(ccb, &mapinfo);
895 sgsendrdwr(struct cam_periph *periph, union ccb *ccb)
897 struct sg_softc *softc;
899 softc = periph->softc;
900 devstat_start_transaction(&softc->device_stats);
906 sgerror(union ccb *ccb, uint32_t cam_flags, uint32_t sense_flags)
908 struct cam_periph *periph;
909 struct sg_softc *softc;
911 periph = xpt_path_periph(ccb->ccb_h.path);
912 softc = (struct sg_softc *)periph->softc;
914 return (cam_periph_error(ccb, cam_flags, sense_flags,
919 sg_scsiio_status(struct ccb_scsiio *csio, u_short *hoststat, u_short *drvstat)
923 status = csio->ccb_h.status;
925 switch (status & CAM_STATUS_MASK) {
930 case CAM_REQ_CMP_ERR:
931 *hoststat = DID_ERROR;
934 case CAM_REQ_ABORTED:
935 *hoststat = DID_ABORT;
938 case CAM_REQ_INVALID:
939 *hoststat = DID_ERROR;
940 *drvstat = DRIVER_INVALID;
942 case CAM_DEV_NOT_THERE:
943 *hoststat = DID_BAD_TARGET;
946 case CAM_SEL_TIMEOUT:
947 *hoststat = DID_NO_CONNECT;
950 case CAM_CMD_TIMEOUT:
951 *hoststat = DID_TIME_OUT;
954 case CAM_SCSI_STATUS_ERROR:
955 *hoststat = DID_ERROR;
958 case CAM_SCSI_BUS_RESET:
959 *hoststat = DID_RESET;
962 case CAM_UNCOR_PARITY:
963 *hoststat = DID_PARITY;
967 *hoststat = DID_BUS_BUSY;
971 *hoststat = DID_ERROR;
972 *drvstat = DRIVER_ERROR;
975 if (status & CAM_AUTOSNS_VALID)
976 *drvstat = DRIVER_SENSE;
980 scsi_group_len(u_char cmd)
982 int len[] = {6, 10, 10, 12, 12, 12, 10, 10};
985 group = (cmd >> 5) & 0x7;