Add -Wold-style-definition to WARNS >= 3 and fix the resulting fallout.
authorSascha Wildner <saw@online.de>
Sat, 10 Apr 2010 20:41:24 +0000 (22:41 +0200)
committerSascha Wildner <saw@online.de>
Sat, 10 Apr 2010 20:41:38 +0000 (22:41 +0200)
* Ansify a function in mount_smbfs(8).

* Lower the WARNS of some contrib/ stuff from 3 to 2.

contrib/smbfs/mount_smbfs/getmntopts.c
lib/libsmdb/Makefile
lib/libz/Makefile
secure/usr.bin/openssl/Makefile
secure/usr.bin/ssh/Makefile
share/mk/bsd.sys.mk
usr.sbin/tcpdump/Makefile

index 895b61c..360225b 100644 (file)
@@ -51,11 +51,8 @@ static const char rcsid[] =
 int getmnt_silent = 0;
 
 void
-getmntopts(options, m0, flagp, altflagp)
-       const char *options;
-       const struct mntopt *m0;
-       int *flagp;
-       int *altflagp;
+getmntopts(const char *options, const struct mntopt *m0, int *flagp,
+    int *altflagp)
 {
        const struct mntopt *m;
        int negative, len;
index 9fffad3..2dcf68b 100644 (file)
@@ -15,7 +15,7 @@ LIB=  smdb
 SRCS+= sm_os.h
 SRCS+= smdb.c smdb1.c smdb2.c smndbm.c
 CLEANFILES+=sm_os.h
-WARNS?=        3
+WARNS?=        2
 
 INTERNALLIB=           true
 
index 88a6dfb..b9d90a0 100644 (file)
@@ -5,7 +5,7 @@
 
 LIB=           z
 MAN=           zlib.3
-WARNS?=                3
+WARNS?=                2
 
 PATCHES!=      echo ${.CURDIR}/patches/*.patch
 CONTRIBDIR=    ${.CURDIR}/../../contrib/zlib-1.2
index 416e712..b900f0d 100644 (file)
@@ -3,7 +3,7 @@
 
 PROG=  xopenssl
 PROGNAME=      openssl
-WARNS?=        3
+WARNS?=        2
 
 DPADD= ${LIBSSL} ${LIBCRYPTO}
 LDADD= -lssl -lcrypto
index 4f2f03b..03acc2e 100644 (file)
@@ -6,7 +6,7 @@ PROG=   ssh
 LINKS= ${BINDIR}/ssh ${BINDIR}/slogin
 MAN=   ssh.1 ssh_config.5
 MLINKS=        ssh.1 slogin.1
-WARNS?=        3
+WARNS?=        2
 
 SRCS=  ssh.c readconf.c clientloop.c sshtty.c \
        sshconnect.c sshconnect1.c sshconnect2.c mux.c \
index 586d5d0..ba88fab 100644 (file)
@@ -33,7 +33,8 @@ CWARNFLAGS    +=      -Wall
 .  endif
 .  if ${WARNS} >= 3
 CWARNFLAGS     +=      -W -Wno-unused-parameter -Wstrict-prototypes\
-                       -Wmissing-prototypes -Wpointer-arith
+                       -Wmissing-prototypes -Wpointer-arith\
+                       -Wold-style-definition
 .  endif
 .  if ${WARNS} >= 4
 CWARNFLAGS     +=      -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch\
index 44f2ad7..e6816db 100644 (file)
@@ -61,7 +61,7 @@ DPADD+= ${LIBCRYPTO}
 LDADD+= -lcrypto
 CFLAGS+= -I${DESTDIR}/usr/include/openssl -DHAVE_LIBCRYPTO -DHAVE_OPENSSL_EVP_H
 .endif
-WARNS?=        3
+WARNS?=        2
 
 version.c: ${TCPDUMP_DISTDIR}/VERSION
        @rm -f $@