Remove unmatched crit_exit() from dsp_ioctl(). A critical section was never
authorThomas E. Spanjaard <tgen@dragonflybsd.org>
Thu, 28 Feb 2008 17:19:11 +0000 (17:19 +0000)
committerThomas E. Spanjaard <tgen@dragonflybsd.org>
Thu, 28 Feb 2008 17:19:11 +0000 (17:19 +0000)
entered before, and it doesn't seem necessary to have one either. This
prevents a panic from happening when you operate mixer ioctls on /dev/dsp.

sys/dev/sound/pcm/dsp.c

index 37f5c19..5948184 100644 (file)
@@ -24,7 +24,7 @@
  * SUCH DAMAGE.
  *
  * $FreeBSD: src/sys/dev/sound/pcm/dsp.c,v 1.80.2.6 2006/04/04 17:43:48 ariff Exp $
- * $DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.16 2007/10/08 17:55:00 hasso Exp $
+ * $DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.17 2008/02/28 17:19:11 tgen Exp $
  */
 
 #include <sys/param.h>
@@ -33,7 +33,7 @@
 #include <dev/sound/pcm/dsp.h>
 #include <dev/sound/pcm/sound.h>
 
-SND_DECLARE_FILE("$DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.16 2007/10/08 17:55:00 hasso Exp $");
+SND_DECLARE_FILE("$DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.17 2008/02/28 17:19:11 tgen Exp $");
 
 #define OLDPCM_IOCTL
 
@@ -464,7 +464,6 @@ dsp_ioctl(struct dev_ioctl_args *ap)
                }
 
                relchns(i_dev, rdch, wrch, 0);
-               crit_exit();
                return ret;
        }