From: Joe Talbott <josepht@dragonflybsd.org>
Date: Tue, 30 Nov 2010 02:03:20 +0000 (-0500)
Subject: unp_connect() - Use euid/egid for access checks via VOP_EACCESS().
X-Git-Tag: v2.10.0~555
X-Git-Url: http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff_plain/9de9cb5c7c5a9dd117de703ed7b4c80a8b3eb2b3

unp_connect() - Use euid/egid for access checks via VOP_EACCESS().

Fixes socket access for set[ug]id applications by using the euid/egid
rather than the uid/gid.

Reported-By: Tim Darby <t+dfbsd@timdarby.net>
---

diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c
index 3421e0c..b3c9986 100644
--- a/sys/kern/uipc_usrreq.c
+++ b/sys/kern/uipc_usrreq.c
@@ -868,7 +868,7 @@ unp_connect(struct socket *so, struct sockaddr *nam, struct thread *td)
 		error = ENOTSOCK;
 		goto bad;
 	}
-	error = VOP_ACCESS(vp, VWRITE, p->p_ucred);
+	error = VOP_EACCESS(vp, VWRITE, p->p_ucred);
 	if (error)
 		goto bad;
 	so2 = vp->v_socket;