From: Thomas E. Spanjaard <tgen@dragonflybsd.org>
Date: Thu, 28 Feb 2008 17:19:11 +0000 (+0000)
Subject: Remove unmatched crit_exit() from dsp_ioctl(). A critical section was never
X-Git-Tag: v2.0.1~1044
X-Git-Url: https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff_plain/f97b2778c23a2344793a78962ab1c543e079b336

Remove unmatched crit_exit() from dsp_ioctl(). A critical section was never
entered before, and it doesn't seem necessary to have one either. This
prevents a panic from happening when you operate mixer ioctls on /dev/dsp.
---

diff --git a/sys/dev/sound/pcm/dsp.c b/sys/dev/sound/pcm/dsp.c
index 37f5c1931b..59481849a4 100644
--- a/sys/dev/sound/pcm/dsp.c
+++ b/sys/dev/sound/pcm/dsp.c
@@ -24,7 +24,7 @@
  * SUCH DAMAGE.
  *
  * $FreeBSD: src/sys/dev/sound/pcm/dsp.c,v 1.80.2.6 2006/04/04 17:43:48 ariff Exp $
- * $DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.16 2007/10/08 17:55:00 hasso Exp $
+ * $DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.17 2008/02/28 17:19:11 tgen Exp $
  */
 
 #include <sys/param.h>
@@ -33,7 +33,7 @@
 #include <dev/sound/pcm/dsp.h>
 #include <dev/sound/pcm/sound.h>
 
-SND_DECLARE_FILE("$DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.16 2007/10/08 17:55:00 hasso Exp $");
+SND_DECLARE_FILE("$DragonFly: src/sys/dev/sound/pcm/dsp.c,v 1.17 2008/02/28 17:19:11 tgen Exp $");
 
 #define OLDPCM_IOCTL
 
@@ -464,7 +464,6 @@ dsp_ioctl(struct dev_ioctl_args *ap)
 		}
 
 		relchns(i_dev, rdch, wrch, 0);
-		crit_exit();
 		return ret;
 	}