zrj [Sun, 4 Feb 2018 15:32:02 +0000 (17:32 +0200)]
world: Remove references to %r and %b.
While there, remove %r and %b and %y support from libstand(3).
Those format are not used in loaders and only eat space.
zrj [Sun, 4 Feb 2018 14:50:03 +0000 (16:50 +0200)]
kernel: Remove last use cases of "%b" format.
Switch to args safe "%pb%i" internal format.
zrj [Sun, 4 Feb 2018 14:27:27 +0000 (16:27 +0200)]
kernel/disk: Remove use of "%b" format.
Switch to args safe "%pb%i" internal format.
zrj [Sun, 4 Feb 2018 13:06:59 +0000 (15:06 +0200)]
kernel/net: Remove use of "%b" format.
Switch to args safe "%pb%i" internal format.
Note: the if_nfe.c used 0x%4b format, while %b was not handling the width.
zrj [Sun, 4 Feb 2018 12:30:53 +0000 (14:30 +0200)]
kernel: Remove use of "%b" format in main kernel code.
Switch to args safe "%pb%i" internal format.
zrj [Sun, 4 Feb 2018 12:15:43 +0000 (14:15 +0200)]
kernel: Implement "%pb%i" as args safe "%b" replacement.
zrj [Sat, 3 Feb 2018 19:27:51 +0000 (21:27 +0200)]
kernel: Nuke legacy FreeBSD "%r" format support.
Makes a quite a cleanup in subr_prf.c and less hits against things
like "%rip". Only one custom format remains - "%b".
zrj [Sat, 3 Feb 2018 18:42:11 +0000 (20:42 +0200)]
kernel: Remove use of deprecated "%r" radix format.
zrj [Sat, 3 Feb 2018 18:37:03 +0000 (20:37 +0200)]
kernel: Implement makedev_unit_b32()
It would be used to replace deprecated legacy FreeBSD "%r" formats.
Change tty_pty.c to use hex2ascii(), since it has only upto 32 devices.
zrj [Sat, 3 Feb 2018 13:08:21 +0000 (15:08 +0200)]
ddb(4): Remove use of deprecated "%r" radix format.
Use internal helpers like for "%z" to print numbers.
Taken-from: NetBSD (with adaptations by swildner)
Matthew Dillon [Wed, 14 Feb 2018 07:02:18 +0000 (23:02 -0800)]
kernel - Try to fix delayed mtime updates on SHARED+RW maps again
* Attempt to fix continuing problems with mtime updates related to
modifications made via SHARED+RW mmap()s. As evidenced by builds
under synth sometimes getting confused.
* Don't update vp->v_lastwrite_ts in vop_stdclose(). Instead, update
the field and set a new flag VLASTWRITETS upon mmap(SHARED+PROT_WRITE)
or upon mprotect(PROT_WRITE) on a SHARED mmap.
* Clear the flag on any regular write, utimes, or truncation.
* Adjust various filesystems to update mtime from vp->v_lastwrite_ts
only upon UIO_NOCOPY writes, and only if VLASTWRITETS is set.
tmpfs, ufs, hammer, hammer2 adjusted.
Matthew Dillon [Wed, 14 Feb 2018 01:46:46 +0000 (17:46 -0800)]
hammer2 - Add missing bkvasync()
* Add missing bkvasync() when a file read receives a chain from the
XOP helper thread.
Sascha Wildner [Tue, 13 Feb 2018 17:25:10 +0000 (18:25 +0100)]
pthread.3: Add missing functions.
Sascha Wildner [Tue, 13 Feb 2018 17:23:21 +0000 (18:23 +0100)]
<signal.h>: Adjust #if 0'd prototype.
Sascha Wildner [Tue, 13 Feb 2018 17:22:38 +0000 (18:22 +0100)]
Change __restrict -> restrict in two manual pages.
Tomohiro Kusumi [Tue, 13 Feb 2018 23:48:39 +0000 (08:48 +0900)]
sbin/hammer: Fix compile error on Linux
Failed with gcc 4.4.7 in CentOS 6.x.
--
cmd_recover.c:78: error: redefinition of typedef 'bigblock_t'
cmd_recover.c:55: note: previous declaration of 'bigblock_t' was here
Tomohiro Kusumi [Tue, 13 Feb 2018 23:35:32 +0000 (08:35 +0900)]
sys/vfs/autofs: Remove AUTOFS_ASSERT_*LOCKED()
These macros came from FreeBSD, but more readable without these.
Tomohiro Kusumi [Tue, 13 Feb 2018 22:13:13 +0000 (07:13 +0900)]
sys/vfs/autofs: Change autofs_mount::am_lock to use mutex(9)
Tomohiro Kusumi [Tue, 13 Feb 2018 21:57:32 +0000 (06:57 +0900)]
sys/vfs/autofs: Change autofs_node::an_vnode_lock to use mutex(9)
Sascha Wildner [Tue, 13 Feb 2018 14:06:25 +0000 (15:06 +0100)]
hammer(8): Remove include guards in a .c file.
Tomohiro Kusumi [Tue, 13 Feb 2018 18:33:30 +0000 (03:33 +0900)]
sys/vfs/autofs: Remove #if0'd export related code
Exporting is never going to be implemented.
Tomohiro Kusumi [Tue, 13 Feb 2018 17:10:39 +0000 (02:10 +0900)]
sys/vfs/autofs: Cleanups
zrj [Tue, 13 Feb 2018 09:56:13 +0000 (11:56 +0200)]
binutils227: Add support for DWARF-4 line number tables.
Backport from upstream trunk the
c83344582375e65643c5efe68b3739e87db482f3
Work around the ld.gold issue when '.rela.debug_line' is populated.
We use ld.gold as default system linker that sigbus on DWARF-4 tables.
LDVER=ld.bfd seems to be unaffected, apply 2018-02-03 fix only for 227.
No functional change for default non-debug buildworlds (only for gcc80).
Sascha Wildner [Mon, 12 Feb 2018 20:05:42 +0000 (21:05 +0100)]
<unistd.h>: Remove commented out ctermid() prototype. It's not needed here.
Tomohiro Kusumi [Tue, 13 Feb 2018 02:28:15 +0000 (11:28 +0900)]
etc/autofs: Cleanup trailing whitespaces
This generates diff from FreeBSD.
Tomohiro Kusumi [Mon, 12 Feb 2018 10:24:24 +0000 (19:24 +0900)]
etc/autofs: Sync special_media with FreeBSD
Tomohiro Kusumi [Mon, 12 Feb 2018 10:22:40 +0000 (19:22 +0900)]
usr.sbin/fstyp: Bring in exFAT support from FreeBSD
exFAT support was added by below FreeBSD@GitHub commit in 2017.
f72e57262fe11f1cc7ffc3b3000bc5747467b8c3
Matthew Dillon [Sun, 11 Feb 2018 06:18:19 +0000 (22:18 -0800)]
tmpfs - Fix data loss issues
* Fix a data loss issue that can occur when vnodes are cycled. This
can be replicated by setting kern.maxvnodes to a fairly low value.
Vnode recycling does not necessarily issue a vinvalbuf() when clean
pages are present, which tmpfs needs to retain.
* Fix a data loss issue when swap becomes full or when the system has
no swap configured. When tmpfs tries to flush to swap and fails,
pages can remain associated with the vnode after the vinvalbuf()
call, and then lost when the vnode is recycled.
* The above fixes are accomplished by call vinvalbuf() on vnode deactivation
to make sure that all buffers have been flushed, and then moving any
pages that remain to tn_aobj.
The pages are moved back when the vnode is reinstantiated and an open(),
read(), write(), or setattr (i.e. truncation or extension) is called.
We try to avoid moving the pages back if the vnode is merely *stat()d
or deleted.
* Use cluster_read() by default to try to improve read throughput when
pages are swap-backed.
Reported-by: zrj, marino
Matthew Dillon [Sun, 11 Feb 2018 06:17:31 +0000 (22:17 -0800)]
kernel - syntax
* Improve a formatting issue.
Matthew Dillon [Sun, 11 Feb 2018 06:11:18 +0000 (22:11 -0800)]
kernel - Fix two rare namecache bugs
* Fix calculations which use the vfscache_negs global. This global
is somewhat heuristical and can values which are a bit off, including
0. Copy to a local and limit the range, fixing a divide-by-zero
bug and a negative-number handling bug.
* Fix a bug in the handling of a race in _cache_cleanneg(). We were
unlocking the ncp but failing to drop it, leaving it with a ref.
The accumulating namecache records prevent umount from succeeding.
This race can only occur regularly when kern.maxvnodes is set to
a low value.
Sepherosa Ziehau [Sat, 10 Feb 2018 02:37:16 +0000 (10:37 +0800)]
if: Allow user to override software queue length.
Sepherosa Ziehau [Sat, 10 Feb 2018 00:19:49 +0000 (08:19 +0800)]
if: Remove ifq maxlen fixup in ifinit.
It will not work, and no drivers in the base require this kind of fixup.
Sascha Wildner [Thu, 8 Feb 2018 10:16:52 +0000 (11:16 +0100)]
<fcntl.h>: Add #if 0'd prototypes for posix_fa{dvise,llocate}().
Sascha Wildner [Wed, 7 Feb 2018 14:06:18 +0000 (15:06 +0100)]
syscall.9: Explain better how errno and return value are set in userland.
In-discussion-with: peeterm, zrj
Sascha Wildner [Tue, 6 Feb 2018 08:49:30 +0000 (09:49 +0100)]
Use 'null' and 'NULL' instead of 'nil' in some manual pages.
Matthew Dillon [Sun, 4 Feb 2018 19:17:47 +0000 (11:17 -0800)]
kernel - Do not panic on media size of zero in disk_probe()
* Do not panic if the media size is zero in disk_probe().
Matthew Dillon [Sun, 4 Feb 2018 19:13:03 +0000 (11:13 -0800)]
kernel - Fix CAM peripheral error handling
* cam_periph.c was bcopy()ing the *ENTIRE* saved ccb back to the
original when working through certain error results. This completely
destroys linked list entry fields.
* Refactor by hacking a restore_ccb() function which does not copy
over the link list entry fields or the callout structure.
* Fixes panics with CDs, particularly audio CDs, and can also fix
other panics.
Panics are related to situations where an AHCI error or errors occur
while multiple CCBs are queued.
* Also always initialize the state tracking field for various scsi
periphals to ensure that stale data does not result in improper
processing in scsi/*.c's *done() functions.
Reported-by: htse
Matthew Dillon [Sun, 4 Feb 2018 19:01:49 +0000 (11:01 -0800)]
ahci - Improve debug output
* TFES errors now also report the slot and ccb pointer
Sascha Wildner [Sun, 4 Feb 2018 12:01:46 +0000 (13:01 +0100)]
bsd.sys.mk: Don't exclude -Wformat-extra-args in FORMAT_AUDIT builds.
Not sure why this was originally added but we surely want to see them.
Reported-by: zrj
Sascha Wildner [Sun, 4 Feb 2018 11:59:59 +0000 (12:59 +0100)]
gdb/lvm: Fix two -Wformat-extra-args warnings.
The gdb one was taken from upstram and the lvm one is in __DragonFly__
specific code.
Sascha Wildner [Sat, 3 Feb 2018 20:41:20 +0000 (21:41 +0100)]
pthread_join.3: Add a missing header in the SYNOPSIS.
zrj [Sat, 3 Feb 2018 08:56:45 +0000 (10:56 +0200)]
cpucontrol(8): Fix -e handling.
We do not have implemented CPUCTL_EVAL_CPU_FEATURES in cpuctl(4) yet.
Sascha Wildner [Sat, 3 Feb 2018 08:00:39 +0000 (09:00 +0100)]
Fix a few mdoc issues.
Sascha Wildner [Sat, 3 Feb 2018 08:00:23 +0000 (09:00 +0100)]
newsyslog.8: Comment out another zstd reference (and fix a typo).
Sascha Wildner [Sat, 3 Feb 2018 07:57:40 +0000 (08:57 +0100)]
callout.9: Remove some obsolete MLINKS.
Eitan Adler [Sat, 3 Feb 2018 04:58:31 +0000 (20:58 -0800)]
[fish] fix style
Eitan Adler [Sat, 3 Feb 2018 04:51:45 +0000 (20:51 -0800)]
[fish] don't allow users to request cards they have made books for
It is not technically legal to request a card you don't have in your
hand, even if you have the book for it. This really only matters if
you're playing with more than one deck, which fish(6) does not support,
but since this is a critical bug, fix it.
zrj [Fri, 2 Feb 2018 20:15:20 +0000 (22:15 +0200)]
newsyslog(8): Add missing fallthrough.
Sascha Wildner [Fri, 2 Feb 2018 15:24:08 +0000 (16:24 +0100)]
Normalize libcrypto and libssl DPADD variable names and adjust Makefiles.
zrj [Tue, 30 Jan 2018 16:47:48 +0000 (18:47 +0200)]
drill(1): Use strdup() for known strings.
zrj [Tue, 30 Jan 2018 16:25:54 +0000 (18:25 +0200)]
libarchive: Use memcpy() when constructing buffers.
Avoid common mistakes that strncpy() will terminate the string.
Results here are not expected to be NULL terminated.
zrj [Tue, 30 Jan 2018 18:36:08 +0000 (20:36 +0200)]
ee(1): Fix ispell_op().
Do not pass NULL to sprintf, use tempname returned by mkstemp(3).
zrj [Wed, 31 Jan 2018 12:08:56 +0000 (14:08 +0200)]
truncate(1): Add support for T.
While there, add fallthrough.
zrj [Wed, 31 Jan 2018 12:06:19 +0000 (14:06 +0200)]
tput(1): Constify.
While there, add fallthrough.
zrj [Wed, 31 Jan 2018 12:02:08 +0000 (14:02 +0200)]
rs(1): Staticize.
While there, add few fallthrough.
zrj [Wed, 31 Jan 2018 11:47:02 +0000 (13:47 +0200)]
jot(1): General cleanup.
* staticize
* constify
* add fallthrough
zrj [Wed, 31 Jan 2018 11:33:32 +0000 (13:33 +0200)]
ident(1): Use NULL instead of 0.
While there, add few cases of fallthrough (few need more investigation).
zrj [Wed, 31 Jan 2018 11:16:43 +0000 (13:16 +0200)]
ctags(1): Add missing fallthrough.
The -v option implies the -x.
zrj [Wed, 31 Jan 2018 11:13:12 +0000 (13:13 +0200)]
colcrt(1): Add missing fallthrough.
zrj [Wed, 31 Jan 2018 11:04:08 +0000 (13:04 +0200)]
at(1): Add missing fallthrough.
While there, constify struct.
zrj [Tue, 30 Jan 2018 21:22:43 +0000 (23:22 +0200)]
kgdb(1): Avoid -Wformat-truncation warning.
No functional change.
zrj [Tue, 30 Jan 2018 19:50:13 +0000 (21:50 +0200)]
window(1): Add some format safety.
While there, add some FALLTHROUGH too.
zrj [Tue, 30 Jan 2018 19:13:11 +0000 (21:13 +0200)]
netstat(1): Add some formats safety.
No functional change intended.
zrj [Tue, 30 Jan 2018 14:43:43 +0000 (16:43 +0200)]
sort(1): Use asprintf(3) when fixing legacy options.
While there, make fix_obsolete_keys() static.
zrj [Tue, 30 Jan 2018 20:31:52 +0000 (22:31 +0200)]
tzsetup(8): Suppress -Wformat-overflow warning.
zrj [Tue, 30 Jan 2018 19:32:45 +0000 (21:32 +0200)]
systat(8): Add some formats safety.
Mainly to suppress -Wformat-overflow
zrj [Tue, 30 Jan 2018 20:28:21 +0000 (22:28 +0200)]
sliplogin(8): Add some formats safety.
Use %hu for printing ipv4 address octects and reduce login name lenght a
bit to allow for prepending path.
zrj [Wed, 31 Jan 2018 12:39:00 +0000 (14:39 +0200)]
sicontrol(8): Add few fallthrough.
zrj [Wed, 31 Jan 2018 10:52:47 +0000 (12:52 +0200)]
route(8): Add some __attribute__((__noreturn__)).
zrj [Wed, 31 Jan 2018 10:44:03 +0000 (12:44 +0200)]
restore(8): Add missing fallthrough.
While there, add few hints for a compiler, panic() can return.
zrj [Wed, 31 Jan 2018 12:22:40 +0000 (14:22 +0200)]
pflogd(8): Add few fallthrough.
zrj [Wed, 31 Jan 2018 12:29:13 +0000 (14:29 +0200)]
ppp(8): Add few fallthrough.
zrj [Wed, 31 Jan 2018 10:28:56 +0000 (12:28 +0200)]
ipfw(8): Add missing fallthrough.
zrj [Tue, 30 Jan 2018 18:10:00 +0000 (20:10 +0200)]
ipfw3(8): Increase stack storage for linename.
To accommodate fully the "Line %d" format and avoid buffer overflow.
Do the same some for ip6fw(8).
zrj [Tue, 30 Jan 2018 17:51:26 +0000 (19:51 +0200)]
ifconfig(8): Use strlcpy() to set the ifr_name field.
While there, change to use IFNAMSIZ too.
zrj [Tue, 30 Jan 2018 20:30:47 +0000 (22:30 +0200)]
dfregress(8): Suppress -Wformat-oveflow warnings.
zrj [Tue, 30 Jan 2018 20:11:21 +0000 (22:11 +0200)]
edquota(8): Use uintmax_t in cvtstoa().
Mainly to suppress the -Wformat-oveflow warnings.
zrj [Tue, 30 Jan 2018 20:06:58 +0000 (22:06 +0200)]
cron(8): Add some format safety.
Mostly no functional change for a common case, just to suppress
the -Wformat-overflow
zrj [Wed, 31 Jan 2018 11:10:33 +0000 (13:10 +0200)]
chat(8): Add missing fallthrough.
Handle them as an error.
zrj [Wed, 31 Jan 2018 10:56:57 +0000 (12:56 +0200)]
boot/common: Add missing fallthrough.
zrj [Wed, 31 Jan 2018 09:10:20 +0000 (11:10 +0200)]
libusb: Use more common "vendor product" order.
While there, make sure that "vendor product" would take only half of
the usb_desc field that is 96 chars long.
zrj [Wed, 31 Jan 2018 10:09:59 +0000 (12:09 +0200)]
libtcplay: Add some format safety.
Limit device prints to 88 chars (should be plenty).
While there, add few missing fallthrough.
zrj [Tue, 30 Jan 2018 17:56:58 +0000 (19:56 +0200)]
libcompat: Use %hu for unsigned shorts.
zrj [Tue, 30 Jan 2018 07:02:49 +0000 (09:02 +0200)]
rpc: Fix xdr_* macros and limit buffer sizes.
While there, constify few things.
Taken-from: FreeBSD
zrj [Mon, 29 Jan 2018 20:44:34 +0000 (22:44 +0200)]
yp*: Staticise.
While there, make few format fixes.
zrj [Tue, 30 Jan 2018 13:05:40 +0000 (15:05 +0200)]
md5(1): Untangle MD5 symbols.
Prefer to use symbols from LibreSSL crypto lib to match SHA ones. Adjust
the function casting to suppress the gcc80 -Wcast-function-type warnings.
While there, print MiB/s instead of bytes/s for benchmarks.
zrj [Mon, 29 Jan 2018 19:20:24 +0000 (21:20 +0200)]
libutil: Use local wrapper for exit(3).
Avoids -Wcast-function-type warning.
zrj [Fri, 2 Feb 2018 07:50:54 +0000 (09:50 +0200)]
cpucontrol(8): Unbreak WORLD_CCOPTLEVEL=2.
Add NO_STRICT_ALIASING for dereferencing type-punned pointers.
zrj [Mon, 29 Jan 2018 15:57:51 +0000 (17:57 +0200)]
init(8): Convert to use sig_atomic_t.
Instead of returning function pointer, now return enum for the next state.
Avoids -Wcast-function-type warnings.
Taken-from: OpenBSD
zrj [Fri, 2 Feb 2018 06:42:39 +0000 (08:42 +0200)]
kernel: Avoid long inactivity pauses on very early boot.
Increase verbosity a bit on certain setups.
François Tigeot [Thu, 1 Feb 2018 20:14:52 +0000 (21:14 +0100)]
drm/linux: Add some dma-buf stubs
zrj [Wed, 31 Jan 2018 19:53:17 +0000 (21:53 +0200)]
kernel: Avoid empty macros when not INVARIANTS.
Visible from MINI64.
zrj [Wed, 31 Jan 2018 19:36:34 +0000 (21:36 +0200)]
kernel/wlan: Avoid empty macros.
Visible from VKERNEL64.
zrj [Wed, 31 Jan 2018 18:43:13 +0000 (20:43 +0200)]
kernel: Avoid empty macros.
Suppresses last 11 -Wempty-body warnings.
zrj [Wed, 31 Jan 2018 18:24:41 +0000 (20:24 +0200)]
kernel/ntfs: Avoid empty macros.
zrj [Wed, 31 Jan 2018 18:16:37 +0000 (20:16 +0200)]
kernel/acpi: Add braces around empty if body.
zrj [Wed, 31 Jan 2018 18:14:11 +0000 (20:14 +0200)]
kernel/hpt*: Avoid empty macros.
Suppresses 14 -Wempty-body warnings.
zrj [Wed, 31 Jan 2018 17:25:08 +0000 (19:25 +0200)]
kernel/twa: Avoid empty macros.
Suppresses 42 -Wempty-body warnings.
zrj [Wed, 31 Jan 2018 17:15:16 +0000 (19:15 +0200)]
kernel/netif: Avoid empty if/else bodies.
zrj [Wed, 31 Jan 2018 17:05:56 +0000 (19:05 +0200)]
ath_hal: Avoid empty macros.
Fix just two callsights to have a terminating semicolon (rest have it)
and remove it from the macros.