From 62e5eef5b464d73f304317c4d3a30a3524998ec3 Mon Sep 17 00:00:00 2001 From: Sascha Wildner Date: Sat, 23 Aug 2008 23:23:37 +0000 Subject: [PATCH] Fix null dereference. Found-by: LLVM/Clang Static Analyzer --- games/robots/score.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/games/robots/score.c b/games/robots/score.c index ba14652db4..f4f30720a3 100644 --- a/games/robots/score.c +++ b/games/robots/score.c @@ -32,7 +32,7 @@ * * @(#)score.c 8.1 (Berkeley) 5/31/93 * $FreeBSD: src/games/robots/score.c,v 1.5 1999/11/30 03:49:20 billf Exp $ - * $DragonFly: src/games/robots/score.c,v 1.3 2006/08/27 21:45:07 pavalos Exp $ + * $DragonFly: src/games/robots/score.c,v 1.4 2008/08/23 23:23:37 swildner Exp $ */ # include "robots.h" @@ -145,11 +145,11 @@ static void set_name(SCORE *scp) { PASSWD *pp; - static char unk[] = "???"; if ((pp = getpwuid(scp->s_uid)) == NULL) - pp->pw_name = unk; - strncpy(scp->s_name, pp->pw_name, MAXNAME); + strncpy(scp->s_name, "???", MAXNAME); + else + strncpy(scp->s_name, pp->pw_name, MAXNAME); } /* -- 2.41.0