From 64242bb16d628cdc55d95e6bdd1dcd4c9c381ca9 Mon Sep 17 00:00:00 2001 From: Alex Hornung Date: Sat, 25 Feb 2012 19:27:41 +0000 Subject: [PATCH] puffs - fix possible null pointer dereference Found-by: clang static analyzer --- sys/vfs/puffs/puffs_vnops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/vfs/puffs/puffs_vnops.c b/sys/vfs/puffs/puffs_vnops.c index d04b8d499b..9599b4983f 100644 --- a/sys/vfs/puffs/puffs_vnops.c +++ b/sys/vfs/puffs/puffs_vnops.c @@ -111,7 +111,7 @@ puffs_vnop_lookup(struct vop_nresolve_args *ap) struct nchandle *nch = ap->a_nch; struct namecache *ncp = nch->ncp; struct ucred *cred = ap->a_cred; - struct vnode *vp, *dvp = ap->a_dvp; + struct vnode *vp = NULL, *dvp = ap->a_dvp; struct puffs_node *dpn; int error; @@ -169,7 +169,7 @@ puffs_vnop_lookup(struct vop_nresolve_args *ap) out: vput(dvp); - if (!error) { + if (!error && vp != NULL) { vn_unlock(vp); cache_setvp(nch, vp); vrele(vp); -- 2.41.0