kib [Sat, 17 Jun 2017 00:57:26 +0000 (00:57 +0000)]
Add abstime kqueue(2) timers and expand struct kevent members.
This change implements NOTE_ABSTIME flag for EVFILT_TIMER, which
specifies that the data field contains absolute time to fire the
event.
To make this useful, data member of the struct kevent must be extended
to 64bit. Using the opportunity, I also added ext members. This
changes struct kevent almost to Apple struct kevent64, except I did
not changed type of ident and udata, the later would cause serious API
incompatibilities.
The type of ident was kept uintptr_t since EVFILT_AIO returns a
pointer in this field, and e.g. CHERI is sensitive to the type
(discussed with brooks, jhb).
Unlike Apple kevent64, symbol versioning allows us to claim ABI
compatibility and still name the new syscall kevent(2). Compat shims
are provided for both host native and compat32.
Requested by: bapt
Reviewed by: bapt, brooks, ngie (previous version)
Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D11025
kib [Fri, 16 Jun 2017 23:41:13 +0000 (23:41 +0000)]
Style.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
X-Differential revision: https://reviews.freebsd.org/D11025
kib [Fri, 16 Jun 2017 23:25:11 +0000 (23:25 +0000)]
Move the description of kern.kq_calloutmax sysctl into a new paragraph
for better presentation.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
kib [Fri, 16 Jun 2017 23:17:31 +0000 (23:17 +0000)]
Start a new sentence on the new line.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
sbruno [Fri, 16 Jun 2017 22:32:23 +0000 (22:32 +0000)]
TCP Wrappers: tcpdchk (tcp wrapper configuration checker) and tcpdmatch
(tcp wrapper oracle) warning fixes via edits to the C code files
contrib/tcp_wrappers/fakelog.c
Warnings for each of functions: openlog( ), vsyslog( ), VARARGS( ),
closelog( )
warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
warning: control reaches end of non-void function [-Wreturn-type]
Fixes:
Explicitly added specification of function type to void for each
function, suppressing both warnings for each function listed
contrib/tcp_wrappers/inetcf.c
Warnings:
warning: incompativle redeclaration of library function 'malloc'
note: 'malloc' is a builtin with type 'void *(unsigned long)'
warning: implicit declaration of function 'check_path' is invalid in C99
[-Wimplicit-function-declaration]
Fixes:
Removed redeclaration of malloc on line 21
Included library <stdlib.h> in the code which contains the malloc( )
function in it's library
Included scaffold.h header file in the code that contains check-path( )
function
contrib/tcp_wrappers/scaffold.c
Warnings:
warning: implicitly declaring library function 'exit' with type
'void (int) __attribute__((noreturn))' [-Wimplicit-function-declaration]
note: include the header <stdlib.h> or explicitly provide a declaration
for 'exit'
Fixes:
Included <stdlib.h> in the code which contains the exit( ) function in
it's library
contrib/tcp_wrappers/tcpdchk.c
Warnings:
warning: implicit declaration of function 'getopt' is invalid
in C99 [-Wimplicit-function-declaration]
warning: implicit declaration of function 'atoi' is invalid
in C99 [-Wimplicit-function-declaration]
Fixes:
Included the specific function <getopt.h> library to the code
Included<stdlib.h> to the code which contains the atoi( ) function in
the library
contrib/tcp_wrappers/tcpdmatch.c
Warnings:
warning: implicit declaration of function 'getopt' is invalid in C99
[-Wimplicit-function-declaration]
Fixes:
Included<stdlib.h> to the code which contains the getopt( ) function in
the library
Submitted by: Aaron Prieger <aprieger@llnw.com>
Reviewed by: vangyzen
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D10995
bdrewery [Fri, 16 Jun 2017 21:48:42 +0000 (21:48 +0000)]
WITH_META_MODE: End each ERROR_CMD CMD line with ';'.
This makes it easier to debug multi-line command failures.
X-MFC-With: r319862
MFC after: 1 week
Sponsored by: Dell EMC Isilon
bdrewery [Fri, 16 Jun 2017 21:37:05 +0000 (21:37 +0000)]
Fix more incorrect library directories fix 'stale .depend' rebuilds.
Reported by: sbruno
MFC after: 3 days
Sponsored by: Dell EMC Isilon
bdrewery [Fri, 16 Jun 2017 20:47:12 +0000 (20:47 +0000)]
Fix LIBAMU location to fix 'stale .depend' rebuilds in usr.sbin/amd.
This originally came in r275052.
Reported by: sbruno
MFC after: 3 days
Sponsored by: Dell EMC Isilon
tsoome [Fri, 16 Jun 2017 20:08:44 +0000 (20:08 +0000)]
Add chain loader support for loader
Implement simple chain loader in loader; this update does add chain command,
taking device or file as argument to load and start new boot loader.
In case of BIOS, the chain will read the boot block to address 0000:7c00 and
jumps on it. In case of UEFI, the chain command is to be used with efi
application, typically stored in EFI System Partition.
The update also does add simple menu entry, if the variable chain_disk is set.
The value of the variable chain_disk is used as argument for chain loading.
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D5992
jhb [Fri, 16 Jun 2017 20:03:09 +0000 (20:03 +0000)]
Decode arguments to sched_* family of system calls.
This includes decoding both scheduler policy constants and the sched_param
structure for sched_get_priority_max(), sched_get_priority_min(),
sched_getparam(), sched_getscheduler(), sched_rr_get_interval(),
sched_setparam(), and sched_setscheduler().
sbruno [Fri, 16 Jun 2017 20:00:39 +0000 (20:00 +0000)]
Quiesce clang warning while building lpc.
usr.sbin/lpr/lpc/lpc.c
Warning
passing 'char *[20]' to parameter of type 'const char **' discards
qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]
Fix:
Explicitly cast the variable "margv" to const char ** only for it's
use as a parameter to suppress the error
Submitted by: Aaron Prieger <aprieger@llnw.com>
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D11019
emaste [Fri, 16 Jun 2017 19:26:33 +0000 (19:26 +0000)]
bsdinstall: correct comment after r320007
Submitted by: vangyzen
emaste [Fri, 16 Jun 2017 18:58:48 +0000 (18:58 +0000)]
bsdinstall: use consistent EFI configuration across platforms
- increase arm64 EFI partition to 200M, as x86
- use EFI_BOOTPART_SIZE and EFI_BOOTPART_PATH macros on x86
- increase ZFS EFI partition to 200M
PR: 201898
Reviewed by: allanjude, manu
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D11239
zbb [Fri, 16 Jun 2017 17:31:56 +0000 (17:31 +0000)]
Revert change to description introduced in r320002
Currently some ARM platforms implement their own platform_probe_and_attach()
function and other use common routine that calls platform's PLATFORM_ATTACH
method.
Keep the old description to match the preferred way of naming things.
Pointed out by: andrew
zbb [Fri, 16 Jun 2017 17:18:29 +0000 (17:18 +0000)]
Enhance Armada 38x SoC identification string
Add hw_clockrate and CPU frequency, basing on sample-at-reset
configuration.
Submitted by: Arnaud Ysmal <arnaud.ysmal@stormshield.eu>
Marcin Wojtas <mw@semihalf.com>
Obtained from: Stormshield, Semihalf
Sponsored by: Stormshield
Reviewed by: andrew
Differential revision: https://reviews.freebsd.org/D10899
sobomax [Fri, 16 Jun 2017 15:09:43 +0000 (15:09 +0000)]
Document st_flags in the stat(2).
Approved by: mckusick,vangyzen,jilles
Differential Revision: https://reviews.freebsd.org/D10852
trasz [Fri, 16 Jun 2017 14:19:23 +0000 (14:19 +0000)]
Don't print all timezones during installworld.
Submitted by: Alex Richardson <alr48@cl.cam.ac.uk>
Reviewed by: gjb
MFC after: 1 month
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D11154
zbb [Fri, 16 Jun 2017 13:53:02 +0000 (13:53 +0000)]
Minor style improvements to pmap_remap_vm_attr()
Use correct platform_ function name in the comment and remove
redundant tabs.
zbb [Fri, 16 Jun 2017 10:16:24 +0000 (10:16 +0000)]
Fix typo in "Marvell" string
Change Marwell to Marvell
Pointed out by: Ravi Pokala <rpokala@mac.com>
phil [Fri, 16 Jun 2017 06:29:21 +0000 (06:29 +0000)]
Merge libxo-0.8.2:
- xohtml: Add "-w" option to pull support files from gh_pages
- Add "upload-xohtml-files" target to publish support files in gh_pages/
- add HISTORY/AUTHORS section to man pages
- xohtml: Add div.units as standard CSS text
- Don't treat values as format strings; they are not
- add "-p" to "mkdir -p build" in setup.sh
- add test case for {U:%%} (from df.c)
- detect end-of-string in '%' and '' escaping
- make xo_simple_field, for common simple cases
- xohtml: nuke "n" in "echo" commands
- rename "format" to "fmt" for consistency; same for "str" to "value"
- update test cases
Submitted by: phil
bdrewery [Fri, 16 Jun 2017 04:28:10 +0000 (04:28 +0000)]
WITH_META_MODE: Don't try showing command if .ERROR_META_FILE is empty.
This was sed'ing on stdin for failing .PHONY targets.
Reported by: Mark Millard
X-MFC-With: r319862
MFC after: 1 week
Sponsored by: Dell EMC Isilon
araujo [Fri, 16 Jun 2017 01:26:01 +0000 (01:26 +0000)]
Check if pthread_create(3) successfully created the thread prior to call
pthread_join(3). The variable tid is not yet initialized in case
the authentication fails at early stage, that would lead pthread_join be
called with an uninitialized variable.
CID: 1375950
Reported by: Coverity, cem
Reviewed by: cem
MFC after: 3 weeks.
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D11150
adrian [Fri, 16 Jun 2017 00:44:23 +0000 (00:44 +0000)]
[ar71xx] migrate all of the duplicate configuration out into a shared config file.
This brings the default configurations (drivers, net80211 settings, etc) and some
of the shared configuration into std.AR_MIPS_BASE. I haven't yet moved the
-current settings (witness, memguard, etc) into it.
This should simplify building a lot of the same test images for my MIPS AP board
development and testing.
This is a work in progress; it's not designed to be perfect!
vangyzen [Thu, 15 Jun 2017 21:34:43 +0000 (21:34 +0000)]
copy(9): clarify that copystr() does not return EFAULT
The previous wording implied that copystr() could return EFAULT.
MFC after: 6 weeks
Sponsored by: Dell EMC
sbruno [Thu, 15 Jun 2017 21:14:48 +0000 (21:14 +0000)]
bnxt(4): Implement temporary workaround in driver to report supported media
types that are currently unavailable from the firmware. e.g. 10G, 25G, 50G
& 100G
Submitted by: bhargava.marreddy@broadcom.com
Reviewed by: venkatkumar.duvvuru@broadcom.com
Differential Revision: https://reviews.freebsd.org/D10816
sbruno [Thu, 15 Jun 2017 21:06:03 +0000 (21:06 +0000)]
bnxt(4) Enable LRO support
iflib - Handle out of order packet delivery from hardware in support of LRO
Out of order updates to rxd's is fixed in r315217. However, it is not
completely fixed. While refilling the buffers, iflib is not considering
the out of order descriptors. Hence, it is refilling sequentially.
"idx" variable in _iflib_fl_refill routine is incremented sequentially.
By doing refilling sequentially, it will override the SGEs that
are *IN USE* by other connections. Fix is to maintain a bitmap of
rx descriptors and differentiate the used one with unused one and
refill only at the unused indices. This patch also fixes a
few bugs in bnxt, related to the same feature.
Submitted by: bhargava.marreddy@broadcom.com
Reviewed by: shurd@
Differential Revision: https://reviews.freebsd.org/D10681
glebius [Thu, 15 Jun 2017 20:11:29 +0000 (20:11 +0000)]
Plug read(2) and write(2) on listening sockets.
stevek [Thu, 15 Jun 2017 20:06:41 +0000 (20:06 +0000)]
Replace md(4) usage in diskless(8) script rc.initdiskless with tmpfs(5).
Need to multiply the size of the disk passed to mount_md by 512 as mdmfs
expects number of 512-byte blocks while tmpfs size option wants number of
bytes.
Reviewed by: brooks
Approved by: sjg (mentor)
Obtained from: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D11106
np [Thu, 15 Jun 2017 19:56:59 +0000 (19:56 +0000)]
cxgbe(4): Fix per-queue netmap operation.
Do not attempt to initialize netmap queues that are already initialized
or aren't supposed to be initialized. Similarly, do not free queues
that are not initialized or aren't supposed to be freed.
PR: 217156
Sponsored by: Chelsio Communications
sbruno [Thu, 15 Jun 2017 17:46:20 +0000 (17:46 +0000)]
Revert r319921 which seems to cause NFS booting assertion panics in
various configurations.
Reported by: pho@
kib [Thu, 15 Jun 2017 14:34:33 +0000 (14:34 +0000)]
Some minor improvements to vnode_pager_generic_putpages().
- Add asserts that the pages to write are dirty. The last page, if
partially written, is only required to be dirty, while completely
written pages should have all dirty bit set.
- Use uintmax_t to print vm_page pindexes.
- Use NULL instead of casted zero.
- Remove if () test which duplicated the loop ending condition.
- Miscellaneous style fixes.
Reviewed by: alc, markj (previous version)
Tested by: pho
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
hselasky [Thu, 15 Jun 2017 11:56:40 +0000 (11:56 +0000)]
Use static device numbering instead of dynamic one when creating
mlx4en network interfaces. This prevents infinite unit number growth
typically when the mlx4en driver is used inside virtual machines which
support runtime PCI attach and detach.
MFC after: 3 days
Sponsored by: Mellanox Technologies
jasone [Thu, 15 Jun 2017 07:15:05 +0000 (07:15 +0000)]
Update jemalloc to 5.0.0.
araujo [Thu, 15 Jun 2017 06:48:36 +0000 (06:48 +0000)]
Use nitems() from sys/param.h.
MFC after: 4 weeks.
araujo [Thu, 15 Jun 2017 06:46:40 +0000 (06:46 +0000)]
Use nitems() from sys/param.h.
MFC after: 4 weeks.
araujo [Thu, 15 Jun 2017 06:21:01 +0000 (06:21 +0000)]
Initialize variables and use byteorder(9) instead of aliasing char array
buf via uint32_t pointer.
CID: 1375949
Reported by: Coverity, cem
Reviewed by: cem
MFC after: 3 weeks
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D11153
rlibby [Thu, 15 Jun 2017 04:49:12 +0000 (04:49 +0000)]
ddb show socket debugging
Display the mbuf/cluster count for a sockbuf and fix a couple whitespace
issues in the output.
Reviewed by: jhb, markj (both previous version)
Approved by: markj (mentor)
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D11062
davidcs [Thu, 15 Jun 2017 02:45:43 +0000 (02:45 +0000)]
Upgrade STORMFW to 8.30.0.0 and ecore version to 8.30.0.0
Add support for pci deviceID 0x8070 for QLE41xxx product line which
supports 10GbE/25GbE/40GbE
MFC after:5 days
cy [Thu, 15 Jun 2017 00:59:02 +0000 (00:59 +0000)]
Correct example directory location.
Submitted by: olivier@
MFC after: 3 days
emaste [Wed, 14 Jun 2017 19:36:28 +0000 (19:36 +0000)]
lld: Add armelf emulation mode
Obtained from: LLD r305375
emaste [Wed, 14 Jun 2017 18:56:33 +0000 (18:56 +0000)]
lld: Fix weak symbols on arm and aarch64
Given
.weak target
.global _start
_start:
b target
The intention is that the branch goes to the instruction after the
branch, effectively turning it on a nop. The branch adds the runtime
PC, but we were adding it statically too.
I noticed the oddity by inspection, but llvm-objdump seems to agree,
since it now prints things like:
b #-4 <_start+0x4>
Obtained from: LLD commit r305212
Differential Revision: https://reviews.freebsd.org/D11191
Reviewed by: dim, Rafael EspĂndola
Obtained from: LLD r305212
MFC after: 3 days
emaste [Wed, 14 Jun 2017 18:53:33 +0000 (18:53 +0000)]
lld: sort relocations
No functional change; applied to facilitate merge of later LLD commit.
Reviewed by: dim, Rafael EspĂndola
Obtained from: LLD r298797
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D11190
gjb [Wed, 14 Jun 2017 18:34:22 +0000 (18:34 +0000)]
Modernize FreeBSD version numbers in freebsd-update(8).
While here, expand a contraction to make textproc/igor happy.
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
avg [Wed, 14 Jun 2017 16:55:47 +0000 (16:55 +0000)]
MFV r319951: 8311 ZFS_READONLY is a little too strict
illumos/illumos-gate@
2889ec41c05e9ffe1890b529b3111354da325aeb
https://github.com/illumos/illumos-gate/commit/
2889ec41c05e9ffe1890b529b3111354da325aeb
https://www.illumos.org/issues/8311
Description:
There was a misunderstanding about the enforcement details of the "Read-only"
flag introduced for SMB/CIFS compatibility, way back in 2007 in the Sun PSARC
2007/315 case.
The original authors thought enforcement of the READONLY flag should work
similarly as the IMMUTABLE flag. Unfortunately, that enforcement is
incompatible with the expectations of Windows applications using this feature
through the SMB service. Applications assume (and the MS File System Algorithms
MS-FSA confirms they should) that an SMB client can:
(a) Open an SMB handle on a file with read/write access,
(b) Set the DOS attributes to include the READONLY flag,
(c) continue to have write access via that handle.
This access model is essentially the same as a Unix/POSIX application that
creates a file (with read/write access), uses fchmod() to change the file mode
to something not granting write access (i.e. 0444), and then continues to write
that file using the open handle it got before the mode change.
Currently, the SMB server works-around this problem in a way that will become
difficult to maintain as we implement support for SMB3 persistent handles, so
SMB depends on this fix.
I've written a test program that can be used to demonstrate this problem, and
added it to zfs-tests (tests/functional/acl/cifs/cifs_attr_004_pos).
It currently fails, but will pass when this problem fixed.
Steps to Reproduce:
Run the test program on a ZFS file system.
Expected Results:
Pass
Actual Results:
Fail.
Reviewed by: Sanjay Nadkarni <sanjay.nadkarni@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed by: John Kennedy <john.kennedy@delphix.com>
Approved by: Prakash Surya <prakash.surya@delphix.com>
Author: Gordon Ross <gwr@nexenta.com>
MFC after: 2 weeks
markj [Wed, 14 Jun 2017 16:55:23 +0000 (16:55 +0000)]
Fix indentation.
MFC after: 1 week
avg [Wed, 14 Jun 2017 16:42:38 +0000 (16:42 +0000)]
MFV r319948: 5428 provide fts(), reallocarray(), and strtonum()
illumos/illumos-gate@
4585130b259133a26efae68275dbe56b08366deb
https://github.com/illumos/illumos-gate/commit/
4585130b259133a26efae68275dbe56b08366deb
https://www.illumos.org/issues/5428
Most of the upstream change is not applicable to FreeBSD.
Only the renaming of strtonum to zfs_strtonum is relevant to us.
And we already had it partially done.
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Joshua M. Clulow <josh@sysmgr.org>
Author: Yuri Pankov <yuri.pankov@nexenta.com>
MFC after: 1 week
avg [Wed, 14 Jun 2017 16:31:36 +0000 (16:31 +0000)]
MFV r319945,r319946: 8264 want support for promoting datasets in libzfs_core
illumos/illumos-gate@
a4b8c9aa65a0a735aba318024a424a90d7b06c37
https://github.com/illumos/illumos-gate/commit/
a4b8c9aa65a0a735aba318024a424a90d7b06c37
https://www.illumos.org/issues/8264
Oddly there is a lzc_clone function, but no lzc_promote function.
Reviewed by: Andriy Gapon <avg@FreeBSD.org>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Dan McDonald <danmcd@kebe.com>
Approved by: Dan McDonald <danmcd@kebe.com>
Author: Andrew Stormont <astormont@racktopsystems.com>
MFC after: 1 week
glebius [Wed, 14 Jun 2017 16:13:20 +0000 (16:13 +0000)]
Check return value from soaccept().
Coverity: 1376209
jhb [Wed, 14 Jun 2017 13:34:09 +0000 (13:34 +0000)]
Don't try to assign interrupts to a CPU on single-CPU systems.
All interrupts are routed to the sole CPU in that case implicitly.
This is a regression in EARLY_AP_STARTUP. Previously the 'assign_cpu'
variable was only set when a multi-CPU system finished booting, so
it's value both meant that interrupts could be assigned and that
there was more than one CPU.
PR: 219882
Reported by: ota@j.email.ne.jp
MFC after: 3 days
rlibby [Wed, 14 Jun 2017 07:46:52 +0000 (07:46 +0000)]
ddb show files: fix up file types and whitespace
This makes ddb show files more descriptive and also adjusts the
whitespace to align the columns for non-32-bit architectures.
Reviewed by: cem (previous version), jhb
Approved by: markj (mentor)
Differential Revision: https://reviews.freebsd.org/D11061
jhibbits [Wed, 14 Jun 2017 04:26:37 +0000 (04:26 +0000)]
Actually add the mpc85xx_get_platform_clock() function.
Follow up r319935 by actually committing the mpc85xx_get_platform_clock()
function. This function was created to facilitate other development, and I
thought I had committed it earlier.
Some blocks depend on the platform clock rather than the system clock.
The System clock is derived from the platform clock as one-half the
platform clock. Rewrite mpc85xx_get_system_clock() to use the new
function.
Pointy-hat to: jhibbits
jhibbits [Wed, 14 Jun 2017 04:16:37 +0000 (04:16 +0000)]
Use mpc85xx_get_platform_clock() instead of rolling our own.
Now that we have a single source for the platform clock, we don't need to
roll our own in every user.
markj [Wed, 14 Jun 2017 03:55:11 +0000 (03:55 +0000)]
Don't call vm_pager_page_unswapped() when writing or deleting a dirty page.
The swap space backing a clean page is released when it is first dirtied,
so there's no need to attempt to release swap space when the page is
already dirty.
Reviewed by: alc
MFC after: 1 week
markj [Wed, 14 Jun 2017 03:50:02 +0000 (03:50 +0000)]
Free the request page if an I/O error occurs while reading from swap.
After such a failure, the page is invalid, so there's point in keeping it
around. Moreover, such pages were not being inserted into the active queue,
making them unreclaimable until a subsequent write or delete made them
valid.
Reported by: alc
Reviewed by: alc (previous revision)
MFC after: 1 week
markj [Wed, 14 Jun 2017 03:45:26 +0000 (03:45 +0000)]
Fix handling of subpage BIO_WRITE and BIO_DELETE requests on swap MDs.
Such requests would previously mark the entire page as valid, which was
incorrect since nothing guaranteed that the page's contents had been
initialized. This change also modifies subpage BIO_DELETEs so that the
entire page is marked dirty, rather than only a subrange. There is no
benefit to creating partially dirty swap pages.
Reviewed by: alc, kib (previous version)
MFC after: 3 days
cy [Wed, 14 Jun 2017 02:42:38 +0000 (02:42 +0000)]
Chase r319848: remove -v option from getopt() call.
cy [Wed, 14 Jun 2017 02:41:22 +0000 (02:41 +0000)]
-n (do nothing) is not a commmand option.
ngie [Wed, 14 Jun 2017 02:28:10 +0000 (02:28 +0000)]
Use nitems(..) when computing `max` instead of the longhand version of
the same logic
MFC after: 1 month
rlibby [Tue, 13 Jun 2017 23:50:55 +0000 (23:50 +0000)]
Add myself (rlibby) as a src committer and markj as my mentor.
Approved by: markj (mentor)
Differential Revision: https://reviews.freebsd.org/D11189
sbruno [Tue, 13 Jun 2017 23:49:49 +0000 (23:49 +0000)]
bnxt: In case of multi queues, have unique name for different IRQs.
Submitted by: bhargava.marreddy@broadcom.com
Differential Revision: https://reviews.freebsd.org/D11149
sbruno [Tue, 13 Jun 2017 23:16:38 +0000 (23:16 +0000)]
Add new sysctl to allow changing of timing of the txq timers.
Add new sysctl to override use of busdma in the driver.
Submitted by: Drew Gallitin <gallatin@netflix.com>
dim [Tue, 13 Jun 2017 21:01:06 +0000 (21:01 +0000)]
Revert r319796 for now, it can cause undefined references when linking
in some circumstances.
Reported by: Shawn Webb <shawn.webb@hardenedbsd.org>
sbruno [Tue, 13 Jun 2017 19:32:23 +0000 (19:32 +0000)]
Plug mbuf leak in the busdma path of iflib.
Submitted by: Michael Tuexen <tuexen@freebsd.org>
Reported by: Drew Gallitin <gallatin@netflix.com>
kib [Tue, 13 Jun 2017 19:02:12 +0000 (19:02 +0000)]
Remove stray return.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
zbb [Tue, 13 Jun 2017 18:55:21 +0000 (18:55 +0000)]
Enable HWPMC overflow IRQ on both CPUs in MPIC
This commit enables usage of HWPMC interrupts for the
Marvell SoCs, which use MPIC (Armada38x and ArmadaXP).
Those interrupts require extra unmasking, comparing to
others. Also, in order to process counters per-CPU,
they are masked/unmasked using separate registers' sets
for each core.
Submitted by: Michal Mazur <mkm@semihalf.com>
Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield, Netgate
Differential revision: https://reviews.freebsd.org/D10913
zbb [Tue, 13 Jun 2017 18:53:56 +0000 (18:53 +0000)]
Fix INVARIANTS debug code in HWPMC
When HWPMC stops sampling, ps_pmc may be freed before samples
are processed. In such situation treat PMC as stopped.
Add "ifdef" to fix build without INVARIANTS code.
Submitted by: Michal Mazur <mkm@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield, Netgate
Differential revision: https://reviews.freebsd.org/D10912
zbb [Tue, 13 Jun 2017 18:52:39 +0000 (18:52 +0000)]
Fix event table for Cortex A9.
Removed events 0x8 (INSTR_EXECUTED), 0xE (PC_PROC_RETURN) and
0x13-0x1d not supported on Cortex A9.
Add events 0x68 and 0x6E which replaced 0x8 and 0xE.
Submitted by: Michal Mazur <mkm@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield, Netgate
Differential revision: https://reviews.freebsd.org/D10911
zbb [Tue, 13 Jun 2017 18:51:23 +0000 (18:51 +0000)]
Fix HWPMC interrupt handling in Counting Mode
Additionally:
- Fix support for Cycle Counter (evsel == 0xFF)
- Stop and mask interrupts from all counters on init and finish
Submitted by: Michal Mazur <mkm@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield, Netgate
Differential revision: https://reviews.freebsd.org/D10910
zbb [Tue, 13 Jun 2017 18:50:08 +0000 (18:50 +0000)]
Add detection of CPU class for ARMv6/v7
Submitted by: Michal Mazur <mkm@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Reviewed by: andrew
Differential revision: https://reviews.freebsd.org/D10909
zbb [Tue, 13 Jun 2017 18:48:51 +0000 (18:48 +0000)]
Enable in-band link management on A388-Clearfog board
This patch adds in-band link management over SGMII of the
SFP transceiver on Armada-388-Clearfog board.
Submitted by: Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Netgate
Reviewed by: loos
Differential revision: https://reviews.freebsd.org/D10708
zbb [Tue, 13 Jun 2017 18:47:42 +0000 (18:47 +0000)]
Enable neta controller support in ARMADA38X
Submitted by: Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Differential revision: https://reviews.freebsd.org/D10707
zbb [Tue, 13 Jun 2017 18:46:29 +0000 (18:46 +0000)]
Introduce Armada 38x/XP network controller support
This patch contains a new driver for the network unit of Marvell
Armada 38x/XP SoCs, called NETA. This support was thoroughly tested
and optimised in terms of stability and performance. Additional
hardware features, like Buffer Management (BM) or Parser and Classifier
(PnC) will be progressively supported as needed.
Submitted by: Fabien Thomas <fabien.thomas@stormshield.eu>
Arnaud Ysmal <arnaud.ysmal@stormshield.eu>
Zbigniew Bodek <zbb@semihalf.com>
Michal Mazur <mkm@semihalf.com>
Bartosz Szczepanek <bsz@semihalf.com>
Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield (main development)
Netgate (cleanup and upstreaming)
Differential revision: https://reviews.freebsd.org/D10706
zbb [Tue, 13 Jun 2017 18:35:14 +0000 (18:35 +0000)]
Prevent multiple lock initialization in e6000sw probe
r319886 ("Add the initial support for the Marvell 88E6141
and 88E6341 switches.") unveiled a problem with possible
multiple lock creation. Move its initialization
to the driver attach and for obtaining the switch ID
create a temprorary one, which is immediately destroyed
after the check.
Submitted by: Zbigniew Bodek <zbb@semihalf.com>
Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
alc [Tue, 13 Jun 2017 17:49:49 +0000 (17:49 +0000)]
Reduce the frequency of hint updates on allocation without incurring
additional allocation overhead. Previously, blst_meta_alloc() updated the
hint after every successful allocation. However, these "eager" hint
updates are of no actual benefit if, instead, the "lazy" hint update at
the start of blst_meta_alloc() is generalized to handle all cases where
the number of available blocks is less than the requested allocation.
Previously, the lazy hint update at the start of blst_meta_alloc() only
handled the ALL-FULL case. (I would also note that this change provides
consistency between blist_alloc() and blist_fill() in that their hint
maintenance is now entirely lazy.)
Eliminate unnecessary checks for terminators in blst_meta_alloc() and
blst_meta_fill() when handling ALL-FREE meta nodes.
Eliminate the field "bl_free" from struct blist. It is redundant. Unless
the entire radix tree is a single leaf, the count of free blocks is stored
in the root node. Instead, provide a function blist_avail() for obtaining
the number of free blocks.
In blst_meta_alloc(), perform a sanity check on the allocation once rather
than repeating it in a loop over the meta node's children.
In blst_leaf_fill(), use the optimized bitcount*() function instead of a
loop to count the blocks being allocated.
Add or improve several comments.
Address some nearby style errors.
Reviewed by: kib
MFC after: 6 weeks
Differential Revision: https://reviews.freebsd.org/D11146
cognet [Tue, 13 Jun 2017 16:19:32 +0000 (16:19 +0000)]
style(9) fixes.
Reported by: cem
stevek [Tue, 13 Jun 2017 15:50:16 +0000 (15:50 +0000)]
The variable nargv is allocated but never freed, so free it when the it
is no longer used.
Submitted by: Thomas Rix <trix@juniper.net>
Reviewed by: ed
Approved by: sjg (mentor)
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D9652
markj [Tue, 13 Jun 2017 15:37:04 +0000 (15:37 +0000)]
Hint at the intended usage for the "ll" field of struct uuid_private.
Discussed with: kib
MFC after: 1 week
asomers [Tue, 13 Jun 2017 14:57:48 +0000 (14:57 +0000)]
sbin/ipfw: strcpy, strncpy => strlcpy
Reported by: Coverity
CID: 1356162, 1356166
MFC after: 3 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D10662
ian [Tue, 13 Jun 2017 14:07:13 +0000 (14:07 +0000)]
Add missing header dependencies (based on looking in the .depend file).
Reported by: gjb
gahr [Tue, 13 Jun 2017 13:26:50 +0000 (13:26 +0000)]
Handle partial writes
Reported by: ed
Reviewed by: cognet
Approved by: cognet
gahr [Tue, 13 Jun 2017 12:35:01 +0000 (12:35 +0000)]
Improve yes' throughput
On my system, this brings up the throughput from ~20 to ~600 MiB/s.
Inspired by: https://www.reddit.com/r/unix/comments/6gxduc/how_is_gnu_yes_so_fast/
Reviewed by: cognet
Approved by: cognet
mmel [Tue, 13 Jun 2017 12:07:18 +0000 (12:07 +0000)]
Implement tunable CPU quirks.
These quirks are intended for optimizing CPU performance, not for
applying errata workarounds. Nobody can expect that CPU with unfixed
errata is stable enough to execute the kernel until quirks are applied.
MFC after: 3 weeks
ae [Tue, 13 Jun 2017 10:52:31 +0000 (10:52 +0000)]
Resurrect RTF_RNH_LOCKED flag and restore ability to call rtalloc1_fib()
with acquired RIB lock.
This fixes a possible panic due to trying to acquire RIB rlock when it is
already exclusive locked.
PR: 215963, 215122
MFC after: 1 week
Sponsored by: Yandex LLC
phil [Tue, 13 Jun 2017 05:38:40 +0000 (05:38 +0000)]
Use {T:Capacity} for header so html output looks tidy
Submitted by: phil
Approved by: sjg
emaste [Tue, 13 Jun 2017 01:25:19 +0000 (01:25 +0000)]
lld: revert accidentally committed change from r319887
This change is a portion of LLD rev 305212 which accidentally ended
up in my svn tree. We do want to backport the change to LLD 4.0, but
it needs additional work and was not supposed to be included in
r319887.
emaste [Tue, 13 Jun 2017 01:17:58 +0000 (01:17 +0000)]
Correct bitwise test in mac_bsdextended ugidfw_rule_valid()
PR: 218039
CID: 1008934
Reported by: Coverity, PVS-Studio
Reviewed by: kib
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10300
ian [Tue, 13 Jun 2017 01:12:37 +0000 (01:12 +0000)]
By popular demand: change MAKE_GENERIC_KERNELS to MAKE_LINT_KERNELS.
It appears that the same arches that lack GENERIC kernel configs also lack
LINT. But enough different arches get built to ensure a kernel change
should build everywhere (32 and 64 bit, clang and old gcc, little and big
endian).
emaste [Tue, 13 Jun 2017 01:05:55 +0000 (01:05 +0000)]
hexdump: actually enter capability mode on last file
Reviewed by: cem, Kyle Evans
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10897
loos [Tue, 13 Jun 2017 00:42:23 +0000 (00:42 +0000)]
Add the initial support for the Marvell 88E6141 and 88E6341 switches.
Right now the driver only supports port VLANs, so make sure
etherswitch_getinfo() return the proper switch capabilities.
Handle the cases where not all ports are in use (that will also require
etherswitch cooperation).
Sponsored by: Rubicon Communications, LLC (Netgate)
emaste [Tue, 13 Jun 2017 00:31:16 +0000 (00:31 +0000)]
lld: ELF: Fix ICF crash on absolute symbol relocations.
If two sections contained relocations to absolute symbols with the same
value we would crash when trying to access their sections. Add a check that
both symbols point to sections before accessing their sections, and treat
absolute symbols as equal if their values are equal.
Obtained from: LLD commit r292578
MFC after: 3 days
rmacklem [Mon, 12 Jun 2017 23:41:20 +0000 (23:41 +0000)]
Define NFS_MAXXDR as the upper bound on XDR overhead in an NFS RPC.
This definition is a part of the maxiotune2 patch that will be
committed soon. It is being committed separately to ease merging
with the pNFS projects subversion trees.
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D10991
loos [Mon, 12 Jun 2017 22:53:18 +0000 (22:53 +0000)]
Update the current version of netmap to bring it in sync with the github
version.
This commit contains mostly refactoring, a few fixes and minor added
functionality.
Submitted by: Vincenzo Maffione <v.maffione at gmail.com>
Requested by: many
Sponsored by: Rubicon Communications, LLC (Netgate)
kib [Mon, 12 Jun 2017 21:16:37 +0000 (21:16 +0000)]
Update scescx test to print syscall number and arguments.
Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks
kib [Mon, 12 Jun 2017 21:15:43 +0000 (21:15 +0000)]
Add ptrace(PT_GET_SC_ARGS) command to return debuggee' current syscall
arguments.
Reviewed by: jhb (previous version)
Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks
Differential revision: https://reviews.freebsd.org/D11080
kib [Mon, 12 Jun 2017 21:11:11 +0000 (21:11 +0000)]
Print unimplemented syscall number to the ctty on SIGSYS, if enabled
by the knob kern.lognosys.
Discussed with: imp
Reviewed by: jhb
Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks
X-Differential revision: https://reviews.freebsd.org/D11080
kib [Mon, 12 Jun 2017 21:03:23 +0000 (21:03 +0000)]
Move struct syscall_args syscall arguments parameters container into
struct thread.
For all architectures, the syscall trap handlers have to allocate the
structure on the stack. The structure takes 88 bytes on 64bit arches
which is not negligible. Also, it cannot be easily found by other
code, which e.g. caused duplication of some members of the structure
to struct thread already. The change removes td_dbg_sc_code and
td_dbg_sc_nargs which were directly copied from syscall_args.
The structure is put into the copied on fork part of the struct thread
to make the syscall arguments information correct in the child after
fork.
This move will also allow several more uses shortly.
Reviewed by: jhb (previous version)
Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks
X-Differential revision: https://reviews.freebsd.org/D11080
np [Mon, 12 Jun 2017 20:55:20 +0000 (20:55 +0000)]
cxgbe(4): Do not request an FEC setting that the port does not support.
MFC after: 3 days.
Sponsored by: Chelsio Communications
kib [Mon, 12 Jun 2017 20:53:44 +0000 (20:53 +0000)]
Make struct syscall_args visible to userspace compilation environment
from machine/proc.h, consistently on all architectures.
Reviewed by: jhb
Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks
X-Differential revision: https://reviews.freebsd.org/D11080
emaste [Mon, 12 Jun 2017 20:42:37 +0000 (20:42 +0000)]
msdosfs: adjust #ifdefs to be similar to NetBSD
- Add header guards where missing
- Make parts available for use in makefs
Sponsored by: The FreeBSD Foundation
kib [Mon, 12 Jun 2017 20:42:16 +0000 (20:42 +0000)]
Decode recently added flags.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days