modpost: fix null pointer dereference
authorMax Kellermann <max.kellermann@ionos.com>
Thu, 15 Feb 2024 14:13:21 +0000 (15:13 +0100)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 18 Mar 2024 17:30:03 +0000 (02:30 +0900)
commit23dfd914d2bfc4c9938b0084dffd7105de231d98
treed272c01076fb9d798642495a9f413df577b4afdf
parent44929bfaceaaa6a854ddc6df6de9433fab1eef92
modpost: fix null pointer dereference

If the find_fromsym() call fails and returns NULL, the warn() call
will dereference this NULL pointer and cause the program to crash.

This happened when I tried to build with "test_user_copy" module.
With this fix, it prints lots of warnings like this:

 WARNING: modpost: lib/test_user_copy: section mismatch in reference: (unknown)+0x4 (section: .text.fixup) -> (unknown) (section: .init.text)

masahiroy@kernel.org:
 The issue is reproduced with ARCH=arm allnoconfig + CONFIG_MODULES=y +
 CONFIG_RUNTIME_TESTING_MENU=y + CONFIG_TEST_USER_COPY=m

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/mod/modpost.c