mlxsw: spectrum: Do not try to create non-existing ports during unsplit
authorIdo Schimmel <idosch@mellanox.com>
Tue, 21 Nov 2017 08:42:21 +0000 (09:42 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Nov 2017 11:15:22 +0000 (20:15 +0900)
commitbf4e9f24a8d9e63c9cbd9cbeb84fc8a9a46ff1a3
tree52d00b9e98b3090f34eaf0022feac4fd98c36f4a
parent32a72bbd5da2411eab591bf9bc2e39349106193a
mlxsw: spectrum: Do not try to create non-existing ports during unsplit

On some systems, when we unsplit a port we need to re-create two ports
instead. On other systems, only one needs to be re-created.

Do not try to create a port if during driver initialization it was
assigned a negative module number, which is invalid.

This avoids the following error during unsplit:
[  941.012478] mlxsw_spectrum 0000:01:00.0: Port 43: Failed to map module

The error is harmless and caused by the fact that a local port is
already mapped to module 0.

Fixes: be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c
drivers/net/ethernet/mellanox/mlxsw/spectrum.h