From: Simon Schubert <corecode@dragonflybsd.org>
Date: Thu, 9 Jul 2009 12:37:15 +0000 (+0200)
Subject: dma: treat a QUIT error as merely a warning
X-Git-Url: https://gitweb.dragonflybsd.org/~corecode/dragonfly.git/commitdiff_plain/6cfc247daee1d0273ed1c08a21b7b3dd6b8849d6

dma: treat a QUIT error as merely a warning

RFC 2821 only mandates that a QUIT error should abort an unfinished
transaction, and since we've reached this point, the DATA command has
succeeded and the message has been accepted for delivery by the remote
end.  Thus, just warn about it.

Submitted-by: Peter Pentchev <roam@ringlet.net>
---

diff --git a/libexec/dma/net.c b/libexec/dma/net.c
index e688b1037f..049baee340 100644
--- a/libexec/dma/net.c
+++ b/libexec/dma/net.c
@@ -462,11 +462,9 @@ deliver_remote(struct qitem *it, const char **errmsg)
 	}
 
 	send_remote_command(fd, "QUIT");
-	if (read_remote(fd, 0, NULL) != 2) {
-		syslog(LOG_ERR, "%s: remote delivery deferred: "
+	if (read_remote(fd, 0, NULL) != 2)
+		syslog(LOG_WARNING, "%s: remote delivery succeeded but "
 		       "QUIT failed: %s", it->queueid, neterr);
-		return (1);
-	}
 out:
 
 	close(fd);