From 85c101d73c3654e014a60f6f1e5bcddaeb74d18b Mon Sep 17 00:00:00 2001 From: Sascha Wildner Date: Wed, 16 Oct 2013 06:15:50 +0200 Subject: [PATCH] ppp(8): Fix a logic error. MPPE only accepts protocol numbers 0x21 through 0xfa. Confirmed-by: FreeBSD --- usr.sbin/ppp/mppe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/ppp/mppe.c b/usr.sbin/ppp/mppe.c index a991ae61e1..41b98e5e44 100644 --- a/usr.sbin/ppp/mppe.c +++ b/usr.sbin/ppp/mppe.c @@ -168,7 +168,7 @@ MPPEOutput(void *v, struct ccp *ccp, struct link *l __unused, int pri __unused, dictinit = 0; log_Printf(LogDEBUG, "MPPE: Output: Proto %02x (%d bytes)\n", *proto, ilen); - if (*proto < 0x21 && *proto > 0xFA) { + if (*proto < 0x21 || *proto > 0xFA) { log_Printf(LogDEBUG, "MPPE: Output: Not encrypting\n"); ccp->compout += ilen; ccp->uncompout += ilen; -- 2.41.0