From: John Marino <draco@marino.st>
Date: Tue, 10 Feb 2015 22:17:53 +0000 (+0100)
Subject: pflogd(8): lower WARNS and fix logic errors
X-Git-Tag: v4.2.0rc~866
X-Git-Url: https://gitweb.dragonflybsd.org/~tuxillo/dragonfly.git/commitdiff_plain/5e2f99e962f18646b3f4bca59ea12a7e0b054027

pflogd(8): lower WARNS and fix logic errors

The contrib files trigger a new -Wunused-value warning, so lower WARNS
to 3 to suppress that.  Also, a [logical-not-parenthesis] error was
triggering [-Werror=bool-compare].  Fixing it fixed the compare too.
---

diff --git a/usr.sbin/pflogd/Makefile b/usr.sbin/pflogd/Makefile
index 58766262c7..8bcd9c2b07 100644
--- a/usr.sbin/pflogd/Makefile
+++ b/usr.sbin/pflogd/Makefile
@@ -3,7 +3,7 @@
 LDADD+= -lpcap -lutil
 DPADD+=	${LIBPCAP} ${LIBUTIL}
 CFLAGS+= -DHAVE_SNPRINTF -I${.CURDIR}/../../contrib/libpcap
-WARNS?=	5
+WARNS?=	3
 
 PROG=	pflogd
 SRCS=	pflogd.c privsep.c privsep_fdpass.c
diff --git a/usr.sbin/pflogd/pflogd.c b/usr.sbin/pflogd/pflogd.c
index 9513ab4d55..da38dd7b88 100644
--- a/usr.sbin/pflogd/pflogd.c
+++ b/usr.sbin/pflogd/pflogd.c
@@ -722,7 +722,7 @@ main(int argc, char **argv)
 		np = pcap_dispatch(hpcap, PCAP_NUM_PKTS,
 		    phandler, (u_char *)dpcap);
 		if (np < 0) {
-			if (!if_exists(__DECONST(char *, interface)) == -1) {
+			if (!(if_exists(__DECONST(char *, interface)) == -1)) {
 				logmsg(LOG_NOTICE, "interface %s went away",
 				    interface);
 				ret = -1;