2 * Copyright (c) 1986, 1988, 1991, 1993
3 * The Regents of the University of California. All rights reserved.
4 * (c) UNIX System Laboratories, Inc.
5 * All or some portions of this file are derived from material licensed
6 * to the University of California by American Telephone and Telegraph
7 * Co. or Unix System Laboratories, Inc. and are reproduced herein with
8 * the permission of UNIX System Laboratories, Inc.
10 * Redistribution and use in source and binary forms, with or without
11 * modification, are permitted provided that the following conditions
13 * 1. Redistributions of source code must retain the above copyright
14 * notice, this list of conditions and the following disclaimer.
15 * 2. Redistributions in binary form must reproduce the above copyright
16 * notice, this list of conditions and the following disclaimer in the
17 * documentation and/or other materials provided with the distribution.
18 * 3. All advertising materials mentioning features or use of this software
19 * must display the following acknowledgement:
20 * This product includes software developed by the University of
21 * California, Berkeley and its contributors.
22 * 4. Neither the name of the University nor the names of its contributors
23 * may be used to endorse or promote products derived from this software
24 * without specific prior written permission.
26 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
27 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
28 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
29 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
30 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
31 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
32 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
33 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
34 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
35 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
38 * @(#)subr_prf.c 8.3 (Berkeley) 1/21/94
39 * $FreeBSD: src/sys/kern/subr_prf.c,v 1.61.2.5 2002/08/31 18:22:08 dwmalone Exp $
44 #include <sys/param.h>
45 #include <sys/systm.h>
46 #include <sys/kernel.h>
47 #include <sys/msgbuf.h>
48 #include <sys/malloc.h>
52 #include <sys/tprintf.h>
53 #include <sys/stdint.h>
54 #include <sys/syslog.h>
57 #include <sys/sysctl.h>
59 #include <sys/ctype.h>
60 #include <sys/eventhandler.h>
61 #include <sys/kthread.h>
63 #include <sys/thread2.h>
64 #include <sys/spinlock2.h>
71 * Note that stdarg.h and the ANSI style va_start macro is used for both
72 * ANSI and traditional C compilers. We use the __ machine version to stay
73 * within the kernel header file set.
75 #include <machine/stdarg.h>
82 /* Max number conversion buffer length: a u_quad_t in base 2, plus NUL byte. */
83 #define MAXNBUF (sizeof(intmax_t) * NBBY + 1)
98 struct tty *constty; /* pointer to console "window" tty */
100 static void msglogchar(int c, int pri);
101 static void msgaddchar(int c, void *dummy);
102 static void kputchar (int ch, void *arg);
103 static char *ksprintn (char *nbuf, uintmax_t num, int base, int *lenp,
105 static void snprintf_func (int ch, void *arg);
107 static int consintr = 1; /* Ok to handle console interrupts? */
108 static int msgbufmapped; /* Set when safe to use msgbuf */
109 static struct spinlock cons_spin = SPINLOCK_INITIALIZER(cons_spin);
110 static thread_t constty_td = NULL;
114 static int log_console_output = 1;
115 TUNABLE_INT("kern.log_console_output", &log_console_output);
116 SYSCTL_INT(_kern, OID_AUTO, log_console_output, CTLFLAG_RW,
117 &log_console_output, 0, "");
119 static int unprivileged_read_msgbuf = 1;
120 SYSCTL_INT(_security, OID_AUTO, unprivileged_read_msgbuf, CTLFLAG_RW,
121 &unprivileged_read_msgbuf, 0,
122 "Unprivileged processes may read the kernel message buffer");
125 * Warn that a system table is full.
128 tablefull(const char *tab)
131 log(LOG_ERR, "%s: table is full\n", tab);
135 * Uprintf prints to the controlling terminal for the current process.
138 uprintf(const char *fmt, ...)
140 struct proc *p = curproc;
142 struct putchar_arg pca;
145 if (p && (p->p_flags & P_CONTROLT) && p->p_session->s_ttyvp) {
147 pca.tty = p->p_session->s_ttyp;
150 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
157 tprintf_open(struct proc *p)
159 if ((p->p_flags & P_CONTROLT) && p->p_session->s_ttyvp) {
160 sess_hold(p->p_session);
161 return ((tpr_t) p->p_session);
163 return ((tpr_t) NULL);
167 tprintf_close(tpr_t sess)
170 sess_rele((struct session *) sess);
174 * tprintf prints on the controlling terminal associated
175 * with the given session.
178 tprintf(tpr_t tpr, const char *fmt, ...)
180 struct session *sess = (struct session *)tpr;
181 struct tty *tp = NULL;
184 struct putchar_arg pca;
187 if (sess && sess->s_ttyvp && ttycheckoutq(sess->s_ttyp, 0)) {
195 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
202 * Ttyprintf displays a message on a tty; it should be used only by
203 * the tty driver, or anything that knows the underlying tty will not
204 * be revoke(2)'d away. Other callers should use tprintf.
207 ttyprintf(struct tty *tp, const char *fmt, ...)
210 struct putchar_arg pca;
216 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
222 * Log writes to the log buffer, and guarantees not to sleep (so can be
223 * called by interrupt routines). If there is no process reading the
224 * log yet, it writes to the console also.
227 log(int level, const char *fmt, ...)
231 struct putchar_arg pca;
235 pca.flags = log_open ? TOLOG : TOCONS;
238 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
245 #define CONSCHUNK 128
248 log_console(struct uio *uio)
250 int c, i, error, iovlen, nl;
252 struct iovec *miov = NULL;
256 if (!log_console_output)
259 pri = LOG_INFO | LOG_CONSOLE;
261 iovlen = uio->uio_iovcnt * sizeof (struct iovec);
262 miov = kmalloc(iovlen, M_TEMP, M_WAITOK);
263 consbuffer = kmalloc(CONSCHUNK, M_TEMP, M_WAITOK);
264 bcopy((caddr_t)muio.uio_iov, (caddr_t)miov, iovlen);
269 while (uio->uio_resid > 0) {
270 c = (int)szmin(uio->uio_resid, CONSCHUNK);
271 error = uiomove(consbuffer, (size_t)c, uio);
274 for (i = 0; i < c; i++) {
275 msglogchar(consbuffer[i], pri);
276 if (consbuffer[i] == '\n')
283 msglogchar('\n', pri);
286 kfree(consbuffer, M_TEMP);
291 * Output to the console.
294 kprintf(const char *fmt, ...)
298 struct putchar_arg pca;
301 savintr = consintr; /* disable interrupts */
305 pca.flags = TOCONS | TOLOG;
307 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
311 consintr = savintr; /* reenable interrupts */
316 kvprintf(const char *fmt, __va_list ap)
319 struct putchar_arg pca;
322 savintr = consintr; /* disable interrupts */
325 pca.flags = TOCONS | TOLOG;
327 retval = kvcprintf(fmt, kputchar, &pca, 10, ap);
330 consintr = savintr; /* reenable interrupts */
335 * Limited rate kprintf. The passed rate structure must be initialized
336 * with the desired reporting frequency. A frequency of 0 will result in
339 * count may be initialized to a negative number to allow an initial
343 krateprintf(struct krate *rate, const char *fmt, ...)
347 if (rate->ticks != (int)time_second) {
348 rate->ticks = (int)time_second;
352 if (rate->count < rate->freq) {
361 * Print a character to the dmesg log, the console, and/or the user's
364 * NOTE: TOTTY does not require nonblocking operation, but TOCONS
365 * and TOLOG do. When we have a constty we still output to
366 * the real console but we have a monitoring thread which
367 * we wakeup which tracks the log.
370 kputchar(int c, void *arg)
372 struct putchar_arg *ap = (struct putchar_arg*) arg;
373 int flags = ap->flags;
374 struct tty *tp = ap->tty;
378 if ((flags & TOCONS) && tp == NULL && constty)
379 flags |= TOLOG | TOWAKEUP;
380 if ((flags & TOTTY) && tputchar(c, tp) < 0)
383 msglogchar(c, ap->pri);
384 if ((flags & TOCONS) && c)
386 if (flags & TOWAKEUP)
391 * Scaled down version of sprintf(3).
394 ksprintf(char *buf, const char *cfmt, ...)
399 __va_start(ap, cfmt);
400 retval = kvcprintf(cfmt, NULL, (void *)buf, 10, ap);
407 * Scaled down version of vsprintf(3).
410 kvsprintf(char *buf, const char *cfmt, __va_list ap)
414 retval = kvcprintf(cfmt, NULL, (void *)buf, 10, ap);
420 * Scaled down version of snprintf(3).
423 ksnprintf(char *str, size_t size, const char *format, ...)
428 __va_start(ap, format);
429 retval = kvsnprintf(str, size, format, ap);
435 * Scaled down version of vsnprintf(3).
438 kvsnprintf(char *str, size_t size, const char *format, __va_list ap)
440 struct snprintf_arg info;
445 retval = kvcprintf(format, snprintf_func, &info, 10, ap);
446 if (info.remain >= 1)
452 ksnrprintf(char *str, size_t size, int radix, const char *format, ...)
457 __va_start(ap, format);
458 retval = kvsnrprintf(str, size, radix, format, ap);
464 kvsnrprintf(char *str, size_t size, int radix, const char *format, __va_list ap)
466 struct snprintf_arg info;
471 retval = kvcprintf(format, snprintf_func, &info, radix, ap);
472 if (info.remain >= 1)
478 kvasnrprintf(char **strp, size_t size, int radix,
479 const char *format, __va_list ap)
481 struct snprintf_arg info;
484 *strp = kmalloc(size, M_TEMP, M_WAITOK);
487 retval = kvcprintf(format, snprintf_func, &info, radix, ap);
488 if (info.remain >= 1)
494 kvasfree(char **strp)
497 kfree(*strp, M_TEMP);
503 snprintf_func(int ch, void *arg)
505 struct snprintf_arg *const info = arg;
507 if (info->remain >= 2) {
514 * Put a NUL-terminated ASCII number (base <= 36) in a buffer in reverse
515 * order; return an optional length and a pointer to the last character
516 * written in the buffer (i.e., the first character of the string).
517 * The buffer pointed to by `nbuf' must have length >= MAXNBUF.
520 ksprintn(char *nbuf, uintmax_t num, int base, int *lenp, int upper)
527 c = hex2ascii(num % base);
528 *++p = upper ? toupper(c) : c;
529 } while (num /= base);
536 * Scaled down version of printf(3).
538 * Two additional formats:
540 * The format %b is supported to decode error registers.
543 * kprintf("reg=%b\n", regval, "<base><arg>*");
545 * where <base> is the output base expressed as a control character, e.g.
546 * \10 gives octal; \20 gives hex. Each arg is a sequence of characters,
547 * the first of which gives the bit number to be inspected (origin 1), and
548 * the next characters (up to a control character, i.e. a character <= 32),
549 * give the name of the register. Thus:
551 * kvcprintf("reg=%b\n", 3, "\10\2BITTWO\1BITONE\n");
553 * would produce output:
555 * reg=3<BITTWO,BITONE>
557 * XXX: %D -- Hexdump, takes pointer and separator string:
558 * ("%6D", ptr, ":") -> XX:XX:XX:XX:XX:XX
559 * ("%*D", len, ptr, " " -> XX XX XX XX ...
562 #define PCHAR(c) {int cc=(c); if(func) (*func)(cc,arg); else *d++=cc; retval++;}
565 kvcprintf(char const *fmt, void (*func)(int, void*), void *arg,
566 int radix, __va_list ap)
570 const char *p, *percent, *q;
574 int base, tmp, width, ladjust, sharpflag, neg, sign, dot;
575 int cflag, hflag, jflag, lflag, qflag, tflag, zflag;
578 int retval = 0, stop = 0;
582 * Make a supreme effort to avoid reentrant panics or deadlocks.
584 * NOTE! Do nothing that would access mycpu/gd/fs unless the
585 * function is the normal kputchar(), which allows us to
586 * use this function for very early debugging with a special
589 if (func == kputchar) {
590 if (mycpu->gd_flags & GDF_KPRINTF)
592 atomic_set_long(&mycpu->gd_flags, GDF_KPRINTF);
602 fmt = "(fmt null)\n";
604 if (radix < 2 || radix > 36)
607 usespin = (func == kputchar &&
608 panic_cpu_gd != mycpu &&
609 (((struct putchar_arg *)arg)->flags & TOTTY) == 0);
612 spin_lock(&cons_spin);
618 while ((ch = (u_char)*fmt++) != '%' || stop) {
624 dot = dwidth = ladjust = neg = sharpflag = sign = upper = 0;
625 cflag = hflag = jflag = lflag = qflag = tflag = zflag = 0;
628 switch (ch = (u_char)*fmt++) {
646 width = __va_arg(ap, int);
652 dwidth = __va_arg(ap, int);
660 case '1': case '2': case '3': case '4':
661 case '5': case '6': case '7': case '8': case '9':
662 for (n = 0;; ++fmt) {
663 n = n * 10 + ch - '0';
665 if (ch < '0' || ch > '9')
674 num = (u_int)__va_arg(ap, int);
675 p = __va_arg(ap, char *);
676 for (q = ksprintn(nbuf, num, *p++, NULL, 0); *q;)
684 if (num & (1 << (n - 1))) {
685 PCHAR(tmp ? ',' : '<');
686 for (; (n = *p) > ' '; ++p)
690 for (; *p > ' '; ++p)
697 PCHAR(__va_arg(ap, int));
700 up = __va_arg(ap, u_char *);
701 p = __va_arg(ap, char *);
705 PCHAR(hex2ascii(*up >> 4));
706 PCHAR(hex2ascii(*up & 0x0f));
737 *(__va_arg(ap, char *)) = retval;
739 *(__va_arg(ap, short *)) = retval;
741 *(__va_arg(ap, intmax_t *)) = retval;
743 *(__va_arg(ap, long *)) = retval;
745 *(__va_arg(ap, quad_t *)) = retval;
747 *(__va_arg(ap, int *)) = retval;
754 sharpflag = (width == 0);
756 num = (uintptr_t)__va_arg(ap, void *);
767 p = __va_arg(ap, char *);
773 for (n = 0; n < dwidth && p[n]; n++)
778 if (!ladjust && width > 0)
783 if (ladjust && width > 0)
805 num = (u_char)__va_arg(ap, int);
807 num = (u_short)__va_arg(ap, int);
809 num = __va_arg(ap, uintmax_t);
811 num = __va_arg(ap, u_long);
813 num = __va_arg(ap, u_quad_t);
815 num = __va_arg(ap, ptrdiff_t);
817 num = __va_arg(ap, size_t);
819 num = __va_arg(ap, u_int);
823 num = (char)__va_arg(ap, int);
825 num = (short)__va_arg(ap, int);
827 num = __va_arg(ap, intmax_t);
829 num = __va_arg(ap, long);
831 num = __va_arg(ap, quad_t);
833 num = __va_arg(ap, ptrdiff_t);
835 num = __va_arg(ap, ssize_t);
837 num = __va_arg(ap, int);
839 if (sign && (intmax_t)num < 0) {
841 num = -(intmax_t)num;
843 p = ksprintn(nbuf, num, base, &tmp, upper);
844 if (sharpflag && num != 0) {
853 if (!ladjust && padc != '0' && width &&
854 (width -= tmp) > 0) {
860 if (sharpflag && num != 0) {
863 } else if (base == 16) {
868 if (!ladjust && width && (width -= tmp) > 0)
875 if (ladjust && width && (width -= tmp) > 0)
881 while (percent < fmt)
884 * Since we ignore an formatting argument it is no
885 * longer safe to obey the remaining formatting
886 * arguments as the arguments will no longer match
895 * Cleanup reentrancy issues.
897 if (func == kputchar)
898 atomic_clear_long(&mycpu->gd_flags, GDF_KPRINTF);
900 spin_unlock(&cons_spin);
909 * Called from the panic code to try to get the console working
910 * again in case we paniced inside a kprintf().
915 spin_init(&cons_spin);
916 atomic_clear_long(&mycpu->gd_flags, GDF_KPRINTF);
920 * Console support thread for constty intercepts. This is needed because
921 * console tty intercepts can block. Instead of having kputchar() attempt
922 * to directly write to the console intercept we just force it to log
923 * and wakeup this baby to track and dump the log to constty.
933 EVENTHANDLER_REGISTER(shutdown_pre_sync, shutdown_kproc,
934 constty_td, SHUTDOWN_PRI_FIRST);
935 constty_td->td_flags |= TDF_SYSTHREAD;
938 kproc_suspend_loop();
942 if (mbp == NULL || msgbufmapped == 0 ||
943 windex == mbp->msg_bufx) {
944 tsleep(constty_td, 0, "waiting", hz*60);
948 windex = mbp->msg_bufx;
952 * Get message buf FIFO indices. rindex is tracking.
954 if ((tp = constty) == NULL) {
955 rindex = mbp->msg_bufx;
960 * Don't blow up if the message buffer is broken
962 if (windex < 0 || windex >= mbp->msg_size)
964 if (rindex < 0 || rindex >= mbp->msg_size)
968 * And dump it. If constty gets stuck will give up.
970 while (rindex != windex) {
971 if (tputchar((uint8_t)mbp->msg_ptr[rindex], tp) < 0) {
973 rindex = mbp->msg_bufx;
976 if (++rindex >= mbp->msg_size)
978 if (tp->t_outq.c_cc >= tp->t_ohiwat) {
979 tsleep(constty_daemon, 0, "blocked", hz / 10);
980 if (tp->t_outq.c_cc >= tp->t_ohiwat) {
989 static struct kproc_desc constty_kp = {
994 SYSINIT(bufdaemon, SI_SUB_KTHREAD_UPDATE, SI_ORDER_ANY,
995 kproc_start, &constty_kp)
998 * Put character in log buffer with a particular priority.
1003 msglogchar(int c, int pri)
1005 static int lastpri = -1;
1006 static int dangling;
1012 if (c == '\0' || c == '\r')
1014 if (pri != -1 && pri != lastpri) {
1016 msgaddchar('\n', NULL);
1019 msgaddchar('<', NULL);
1020 for (p = ksprintn(nbuf, (uintmax_t)pri, 10, NULL, 0); *p;)
1021 msgaddchar(*p--, NULL);
1022 msgaddchar('>', NULL);
1025 msgaddchar(c, NULL);
1035 * Put char in log buffer. Make sure nothing blows up beyond repair if
1036 * we have an MP race.
1041 msgaddchar(int c, void *dummy)
1050 windex = mbp->msg_bufx;
1051 mbp->msg_ptr[windex] = c;
1052 if (++windex >= mbp->msg_size)
1054 rindex = mbp->msg_bufr;
1055 if (windex == rindex) {
1057 if (rindex >= mbp->msg_size)
1058 rindex -= mbp->msg_size;
1059 mbp->msg_bufr = rindex;
1061 mbp->msg_bufx = windex;
1065 msgbufcopy(struct msgbuf *oldp)
1069 pos = oldp->msg_bufr;
1070 while (pos != oldp->msg_bufx) {
1071 msglogchar(oldp->msg_ptr[pos], -1);
1072 if (++pos >= oldp->msg_size)
1078 msgbufinit(void *ptr, size_t size)
1081 static struct msgbuf *oldp = NULL;
1083 size -= sizeof(*msgbufp);
1085 msgbufp = (struct msgbuf *) (cp + size);
1086 if (msgbufp->msg_magic != MSG_MAGIC || msgbufp->msg_size != size ||
1087 msgbufp->msg_bufx >= size || msgbufp->msg_bufr >= size) {
1089 bzero(msgbufp, sizeof(*msgbufp));
1090 msgbufp->msg_magic = MSG_MAGIC;
1091 msgbufp->msg_size = (char *)msgbufp - cp;
1093 msgbufp->msg_ptr = cp;
1094 if (msgbufmapped && oldp != msgbufp)
1100 /* Sysctls for accessing/clearing the msgbuf */
1103 sysctl_kern_msgbuf(SYSCTL_HANDLER_ARGS)
1109 * Only wheel or root can access the message log.
1111 if (unprivileged_read_msgbuf == 0) {
1112 KKASSERT(req->td->td_proc);
1113 cred = req->td->td_proc->p_ucred;
1115 if ((cred->cr_prison || groupmember(0, cred) == 0) &&
1116 priv_check(req->td, PRIV_ROOT) != 0
1123 * Unwind the buffer, so that it's linear (possibly starting with
1124 * some initial nulls).
1126 error = sysctl_handle_opaque(oidp, msgbufp->msg_ptr + msgbufp->msg_bufx,
1127 msgbufp->msg_size - msgbufp->msg_bufx, req);
1130 if (msgbufp->msg_bufx > 0) {
1131 error = sysctl_handle_opaque(oidp, msgbufp->msg_ptr,
1132 msgbufp->msg_bufx, req);
1137 SYSCTL_PROC(_kern, OID_AUTO, msgbuf, CTLTYPE_STRING | CTLFLAG_RD,
1138 0, 0, sysctl_kern_msgbuf, "A", "Contents of kernel message buffer");
1140 static int msgbuf_clear;
1143 sysctl_kern_msgbuf_clear(SYSCTL_HANDLER_ARGS)
1146 error = sysctl_handle_int(oidp, oidp->oid_arg1, oidp->oid_arg2, req);
1147 if (!error && req->newptr) {
1148 /* Clear the buffer and reset write pointer */
1149 bzero(msgbufp->msg_ptr, msgbufp->msg_size);
1150 msgbufp->msg_bufr = msgbufp->msg_bufx = 0;
1156 SYSCTL_PROC(_kern, OID_AUTO, msgbuf_clear,
1157 CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_SECURE, &msgbuf_clear, 0,
1158 sysctl_kern_msgbuf_clear, "I", "Clear kernel message buffer");
1162 DB_SHOW_COMMAND(msgbuf, db_show_msgbuf)
1166 if (!msgbufmapped) {
1167 db_printf("msgbuf not mapped yet\n");
1170 db_printf("msgbufp = %p\n", msgbufp);
1171 db_printf("magic = %x, size = %d, r= %d, w = %d, ptr = %p\n",
1172 msgbufp->msg_magic, msgbufp->msg_size, msgbufp->msg_bufr,
1173 msgbufp->msg_bufx, msgbufp->msg_ptr);
1174 for (i = 0; i < msgbufp->msg_size; i++) {
1175 j = (i + msgbufp->msg_bufr) % msgbufp->msg_size;
1176 db_printf("%c", msgbufp->msg_ptr[j]);
1185 hexdump(const void *ptr, int length, const char *hdr, int flags)
1189 const unsigned char *cp;
1192 if ((flags & HD_DELIM_MASK) != 0)
1193 delim = (flags & HD_DELIM_MASK) >> 8;
1197 if ((flags & HD_COLUMN_MASK) != 0)
1198 cols = flags & HD_COLUMN_MASK;
1203 for (i = 0; i < length; i+= cols) {
1207 if ((flags & HD_OMIT_COUNT) == 0)
1208 kprintf("%04x ", i);
1210 if ((flags & HD_OMIT_HEX) == 0) {
1211 for (j = 0; j < cols; j++) {
1214 kprintf("%c%02x", delim, cp[k]);
1220 if ((flags & HD_OMIT_CHARS) == 0) {
1222 for (j = 0; j < cols; j++) {
1226 else if (cp[k] >= ' ' && cp[k] <= '~')
1227 kprintf("%c", cp[k]);