access(2): fix confusion between real and effective uid/gid
Posix states that access() shall check permissions against
real uid and gid but our implementation was using effective
uid and gid instead.
Change vop_helper_access accordingly.
NOTE: This code will change soon when faccessat(2) is implemented
but I'd rather not mix the bug fix with a new feature in a single
commit.
NOTE: nfs_access() may need to be fixed too but I haven't
managed yet to figure out whether it should use real or
effective uid.
Fix-suggested-by: Alex Hornung <ahornung@gmail.com>
Approved-by: dillon@