From: Simon Schubert <corecode@dragonflybsd.org>
Date: Mon, 19 Jun 2006 12:06:07 +0000 (+0000)
Subject: Coverity CID 890: Possible NULL pointer deref.
X-Git-Tag: v2.0.1~4782
X-Git-Url: https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff_plain/4b1ea71df727210dfd7a1fddca3f7e53c4bf67f8

Coverity CID 890: Possible NULL pointer deref.

Taken from: NetBSD via Coverity Prevent
Submitted by: Gary <gary@velocity-servers.net>
---

diff --git a/bin/sh/exec.c b/bin/sh/exec.c
index 9e51e91e83..9b8941ed82 100644
--- a/bin/sh/exec.c
+++ b/bin/sh/exec.c
@@ -35,7 +35,7 @@
  *
  * @(#)exec.c	8.4 (Berkeley) 6/8/95
  * $FreeBSD: src/bin/sh/exec.c,v 1.14.2.4 2002/08/27 01:36:28 tjr Exp $
- * $DragonFly: src/bin/sh/exec.c,v 1.6 2006/02/04 14:12:20 eirikn Exp $
+ * $DragonFly: src/bin/sh/exec.c,v 1.7 2006/06/19 12:06:07 corecode Exp $
  */
 
 #include <sys/types.h>
@@ -422,9 +422,12 @@ loop:
 	return;
 
 success:
-	cmdp->rehash = 0;
-	entry->cmdtype = cmdp->cmdtype;
-	entry->u = cmdp->param;
+	if (cmdp) {
+		cmdp->rehash = 0;
+		entry->cmdtype = cmdp->cmdtype;
+		entry->u = cmdp->param;
+	} else
+		entry->cmdtype = CMDUNKNOWN;
 }