From: David Rhodus <drhodus@dragonflybsd.org>
Date: Tue, 14 Sep 2004 00:33:53 +0000 (+0000)
Subject: Fix a problem with the NSIG check which could lead to an exploitable
X-Git-Tag: v2.0.1~10307
X-Git-Url: https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff_plain/c24db2df6410faf1fa2269300dac195a0699124f

Fix a problem with the NSIG check which could lead to an exploitable
condition.

Merged from fbsd.
---

diff --git a/usr.bin/killall/killall.c b/usr.bin/killall/killall.c
index 9583efb4a3..b2501812b7 100644
--- a/usr.bin/killall/killall.c
+++ b/usr.bin/killall/killall.c
@@ -25,7 +25,7 @@
  * SUCH DAMAGE.
  *
  * $FreeBSD: src/usr.bin/killall/killall.c,v 1.5.2.4 2001/05/19 19:22:49 phk Exp $
- * $DragonFly: src/usr.bin/killall/killall.c,v 1.6 2004/07/16 00:52:22 hmp Exp $
+ * $DragonFly: src/usr.bin/killall/killall.c,v 1.7 2004/09/14 00:33:53 drhodus Exp $
  */
 
 #include <sys/cdefs.h>
@@ -198,7 +198,7 @@ main(int ac, char **av)
 					sig = strtol(*av, &ep, 10);
 					if (!*av || *ep)
 						errx(1, "illegal signal number: %s", *av);
-					if (sig < 0 || sig > NSIG)
+					if (sig < 0 || sig >= NSIG)
 						nosig(*av);
 				} else
 					nosig(*av);