dragonfly.git
5 years agoldns: Adjust makefiles for ldns-1.7.0 update.
zrj [Mon, 15 Apr 2019 14:15:43 +0000 (17:15 +0300)]
ldns: Adjust makefiles for ldns-1.7.0 update.

Several changes:
 * move ldns.h to contrib
 * use single config.h
 * convert ldns headers to private (ldns is a private base lib)
 * bump soname for api changesmi, use shpub
 * add missing deps on librecrypto.so
 * update READMES

Currently only user of the libprivate_ldns is drill(1).
OpenSSH will be adjusted to use this lib next.

5 years agoMerge remote-tracking branch 'origin/vendor/LDNS'
zrj [Wed, 24 Apr 2019 17:14:10 +0000 (20:14 +0300)]
Merge remote-tracking branch 'origin/vendor/LDNS'

5 years agoRevert "drill(1): Use strdup() for known strings."
zrj [Mon, 15 Apr 2019 08:29:10 +0000 (11:29 +0300)]
Revert "drill(1): Use strdup() for known strings."

This reverts commit 471272f59981f2dcc1aac28b61c0a06d49388615.

Already in a new version.

5 years agounzip(1): Add missing dependencies.
zrj [Sun, 14 Apr 2019 20:21:42 +0000 (23:21 +0300)]
unzip(1): Add missing dependencies.

Satisfies NOSHARED build after libarchive update.

5 years agoMakefile.inc1: Update library interdeps.
zrj [Sun, 14 Apr 2019 19:53:17 +0000 (22:53 +0300)]
Makefile.inc1: Update library interdeps.

 * libarchive no longer depends on libmd
 * libarchive and liblzma no longer depends on libthread_xu
 * libdevattr can be compiled in standard order

Adjust lib/Makefile to match output of tools/make_libdeps.sh.

5 years agoxz: Adjust makefiles for xz-5.2.4 update.
zrj [Sun, 14 Apr 2019 16:22:06 +0000 (19:22 +0300)]
xz: Adjust makefiles for xz-5.2.4 update.

Disable multi-threading on liblizma by deafult to prevent libarchive
getting a hard dependency on pthreads. Move whole threading support
directly to usr.bin/xz. This solves static linking and simplifies the
lib/Makefile inter-libs dependencies. This also makes pkg(8) no longer
implicitly depend on pthreads. As bonus, allow crunchgen'ed xz(8)
without multi-threading support. Should be benefitial for initrd/rescue.

5 years agoMerge remote-tracking branch 'origin/vendor/XZ'
zrj [Wed, 24 Apr 2019 17:12:27 +0000 (20:12 +0300)]
Merge remote-tracking branch 'origin/vendor/XZ'

5 years agoAdjust files for libarchive-3.3.3 import.
zrj [Sat, 13 Apr 2019 20:59:32 +0000 (23:59 +0300)]
Adjust files for libarchive-3.3.3 import.

This finally drops dependency on libmd. Also avoid pthreads from lzma.

Changes:
 * Remove LIBMD
 * Add README.DELETED
 * Fix Symbol.map
 * Adjust tools to take version from config.h

5 years agoMerge remote-tracking branch 'origin/vendor/LIBARCHIVE'
zrj [Wed, 24 Apr 2019 17:12:03 +0000 (20:12 +0300)]
Merge remote-tracking branch 'origin/vendor/LIBARCHIVE'

5 years agolibarchive: Revert manpage fixes.
zrj [Sat, 13 Apr 2019 13:16:07 +0000 (16:16 +0300)]
libarchive: Revert manpage fixes.

5 years agolibarchive: Revert local changes.
zrj [Sat, 13 Apr 2019 13:11:39 +0000 (16:11 +0300)]
libarchive: Revert local changes.

Fixed in new version.

5 years agoRevert "libarchive: Use memcpy() when constructing buffers."
zrj [Sat, 13 Apr 2019 12:29:20 +0000 (15:29 +0300)]
Revert "libarchive: Use memcpy() when constructing buffers."

This reverts commit be16867234e89aa9cc5f9a12e3836f84f5268b80.

Before libarchive update.

5 years agoUpdate LibreSSL makefiles.
zrj [Fri, 12 Apr 2019 17:36:59 +0000 (20:36 +0300)]
Update LibreSSL makefiles.

Version 2.9.1, add local CRYPTO_free.c CRYPTO_malloc.c to avoid extra deps.

5 years agolibressl: Add missing timespecsub().
zrj [Fri, 12 Apr 2019 17:34:28 +0000 (20:34 +0300)]
libressl: Add missing timespecsub().

The <sys/time.h> needs update for 3 arg macros.

5 years agoAdd local patches to LibreSSL.
zrj [Fri, 12 Apr 2019 17:33:43 +0000 (20:33 +0300)]
Add local patches to LibreSSL.

Document local changes.

5 years agoMerge remote-tracking branch 'origin/vendor/LIBRESSL'
zrj [Wed, 24 Apr 2019 17:10:42 +0000 (20:10 +0300)]
Merge remote-tracking branch 'origin/vendor/LIBRESSL'

5 years agoRevert "libressl: Few local modifications for netcat."
zrj [Tue, 9 Apr 2019 12:20:00 +0000 (15:20 +0300)]
Revert "libressl: Few local modifications for netcat."

This reverts commit 66ceb5e9b7ccc1005b0b710f32228c0b69070e98.

Before LibreSSL update.

5 years agoRevert "security/libressl: Fix ECDSA P-256 timing attack vulnerability"
zrj [Tue, 9 Apr 2019 10:34:41 +0000 (13:34 +0300)]
Revert "security/libressl: Fix ECDSA P-256 timing attack vulnerability"

This reverts commit bd84e83893b298face58762e1fec24667126c8c7.

Before LibreSSL update.

5 years agowpa_supplicant(8): Add LibreSSL v2.9.0 compat fixes.
zrj [Fri, 12 Apr 2019 18:05:47 +0000 (21:05 +0300)]
wpa_supplicant(8): Add LibreSSL v2.9.0 compat fixes.

The tls_connection_get_keyblock_size() seems to be unused.

The wpa_supplicant really needs a proper update.

5 years agolibssh: Disable use of openssl engine.
zrj [Fri, 12 Apr 2019 17:24:53 +0000 (20:24 +0300)]
libssh: Disable use of openssl engine.

5 years agoldns: Add OPENSSL_NO_ENGINE checks.
zrj [Fri, 12 Apr 2019 17:23:56 +0000 (20:23 +0300)]
ldns: Add OPENSSL_NO_ENGINE checks.

Functionality is unused.

5 years agoldns: Update vendor branch from 1.6.16 to 1.7.0
zrj [Mon, 15 Apr 2019 14:01:32 +0000 (17:01 +0300)]
ldns: Update vendor branch from 1.6.16 to 1.7.0

5 years agoUpgrade xz from 5.2.2 to 5.2.4 on the vendor branch.
zrj [Sun, 14 Apr 2019 15:58:31 +0000 (18:58 +0300)]
Upgrade xz from 5.2.2 to 5.2.4 on the vendor branch.

Remove not needed sources.

5 years agoImport libarchive-3.3.3
zrj [Sat, 13 Apr 2019 15:52:14 +0000 (18:52 +0300)]
Import libarchive-3.3.3

Remove README.DELETED, it will be recreated on master branch.

5 years agoUpdate LibreSSL from version 2.4.4 => 2.9.1
Maxim Ag [Sat, 20 Apr 2019 09:51:47 +0000 (12:51 +0300)]
Update LibreSSL from version 2.4.4 => 2.9.1

Submitted-by: Maxim + v2 update to 2.9.1 stable
5 years agodrm/linux: Add trace/events/dma_fence.h
François Tigeot [Wed, 24 Apr 2019 09:11:40 +0000 (11:11 +0200)]
drm/linux: Add trace/events/dma_fence.h

5 years ago<unistd.h>: FWIW, set _XOPEN_ENH_I18N, per the standard.
Sascha Wildner [Wed, 24 Apr 2019 08:51:49 +0000 (10:51 +0200)]
<unistd.h>: FWIW, set _XOPEN_ENH_I18N, per the standard.

We support all functions that it originally required, when it was
still optional. It won't have any impact on anything, as far as I
can see, so this commit is more cosmetic than anything else.

While here, improve some comments.

5 years agoSync indent(1) with FreeBSD.
Sascha Wildner [Wed, 24 Apr 2019 07:10:38 +0000 (09:10 +0200)]
Sync indent(1) with FreeBSD.

A number of new options. Also -troff is gone.

5 years ago<unistd.h>: Bump _POSIX_THREAD_SAFE_FUNCTIONS to 200112L.
Sascha Wildner [Wed, 24 Apr 2019 06:59:07 +0000 (08:59 +0200)]
<unistd.h>: Bump _POSIX_THREAD_SAFE_FUNCTIONS to 200112L.

It became non-optional anyway in 200809. We have all the functions
that 200112 required in the option, so I don't see why not.

Thanks to zrj for checking with a dports bulk build.

5 years agoman(1): Adjust manual page search path a bit.
Sascha Wildner [Wed, 24 Apr 2019 05:30:33 +0000 (07:30 +0200)]
man(1): Adjust manual page search path a bit.

Our old one, basically.

5 years agomakedb: Ignore makewhatis(8) errors.
Sascha Wildner [Tue, 23 Apr 2019 23:02:27 +0000 (01:02 +0200)]
makedb: Ignore makewhatis(8) errors.

Might occur with make distribution building a master IMG on release or
vice versa, due to the location change of makewhatis (its database
format has changed too).

5 years agodrm/linux: Add config_enabled()
François Tigeot [Tue, 23 Apr 2019 20:23:51 +0000 (22:23 +0200)]
drm/linux: Add config_enabled()

5 years agoLink mandoc(1) as 'whatis' too.
Sascha Wildner [Tue, 23 Apr 2019 19:51:08 +0000 (21:51 +0200)]
Link mandoc(1) as 'whatis' too.

Reported-by: zrj
5 years agohammer2(8): Document dependency on thread library.
zrj [Tue, 23 Apr 2019 16:26:55 +0000 (19:26 +0300)]
hammer2(8): Document dependency on thread library.

While there, start using PRIVATELIB_CFLAGS.

5 years agolibc: Move out locking from vsyslog() core.
zrj [Tue, 23 Apr 2019 16:16:12 +0000 (19:16 +0300)]
libc: Move out locking from vsyslog() core.

For consistency with openlog() and closelog().

While there, use SOCK_CLOEXEC directly and do not attempt to closelog()
several times for badly written programs (LogFile is handled internally).

5 years agolibc: Fix few typos in vsyslog().
zrj [Tue, 23 Apr 2019 15:54:32 +0000 (18:54 +0300)]
libc: Fix few typos in vsyslog().

While there, move variable declarations to top and remove braces.

5 years agogcc47: Disconnect objc components from world.
zrj [Tue, 23 Apr 2019 15:47:56 +0000 (18:47 +0300)]
gcc47: Disconnect objc components from world.

5 years agoRemove groff from base.
Sascha Wildner [Tue, 23 Apr 2019 17:45:56 +0000 (19:45 +0200)]
Remove groff from base.

There is a dports package available for people who need it. Also,
for some manual pages in dports, man(1) will report that mandoc(1)
cannot render them, and advise to install groff too, which man(1)
will then use.

Also remove vgrind(1) and the old base me(7) macros.

Disable the groff part of manlint for now, also mandiff. I will
decide later if it should be made to work with dports groff.

There are a number of related utilities, like colcrt, checknr etc.
that I have not touched yet. Their fate will be decided later.

There are also some references to these tools left in existing
manual pages.

5 years agoRemove no longer needed catman periodic via 'make upgrade'.
Sascha Wildner [Mon, 22 Apr 2019 22:42:11 +0000 (00:42 +0200)]
Remove no longer needed catman periodic via 'make upgrade'.

5 years agodrm/linux: Add list_for_each_entry_continue_reverse()
François Tigeot [Mon, 22 Apr 2019 20:55:13 +0000 (22:55 +0200)]
drm/linux: Add list_for_each_entry_continue_reverse()

Obtained-from: OpenBSD

5 years agoDeprecate and remove OPIE from PAM.
zrj [Mon, 22 Apr 2019 08:42:16 +0000 (11:42 +0300)]
Deprecate and remove OPIE from PAM.

This will require user intervention to manually disable OPIE usage or
cleanly reinstall pam.d/* (even better if no modifications were done).
Due to very strict used "requisite" requirements any pam_opie loading
error will result in unusable system except for singe user mode.
Add warning for the user. Sooner or later this will need to be done.

While there, disable installing /etc/pam.d/rsh script. It can be removed.

5 years agokernel/tty: Use GID_TTY for non root users by default.
zrj [Fri, 19 Apr 2019 10:32:55 +0000 (13:32 +0300)]
kernel/tty: Use GID_TTY for non root users by default.

Previous behaviour defaulting to GID_WHEEL was confusing OpenSSH tests.

5 years agoRemove the old GNU man, makewhatis and manpath.config.5 manual page.
Sascha Wildner [Mon, 22 Apr 2019 15:27:08 +0000 (17:27 +0200)]
Remove the old GNU man, makewhatis and manpath.config.5 manual page.

5 years agoSwitch to the new man(1) command.
Sascha Wildner [Mon, 22 Apr 2019 15:24:19 +0000 (17:24 +0200)]
Switch to the new man(1) command.

* Exchange our old GNU man(1) command with the one from FreeBSD that I
  recently imported. It uses mandoc(1) by default. If mandoc(1) reports
  that it cannot render a page, man(1) will fall back to groff (right
  now our base groff, later the groff pkg when we remove it).

* Install mandoc(1) as apropos(1) and makewhatis(8). This means
  makewhatis moves from /usr/sbin to /usr/bin.

* Use mandoc(1) instead of groff for most purposes of bsd.man.mk.

* Remove /usr/share/man/cat*. It's not necessary anymore to cache
  formatted manual pages.

5 years agoKind of sync makewhatis.local with FreeBSD. Ignore r/o directories.
Sascha Wildner [Sun, 21 Apr 2019 16:23:05 +0000 (18:23 +0200)]
Kind of sync makewhatis.local with FreeBSD. Ignore r/o directories.

One or two improvements to the manual page by me.

5 years agodrm/linux: Add down_read_trylock()
François Tigeot [Sun, 21 Apr 2019 15:41:42 +0000 (17:41 +0200)]
drm/linux: Add down_read_trylock()

5 years agoSync manctl(8) with FreeBSD.
Sascha Wildner [Sun, 21 Apr 2019 08:29:12 +0000 (10:29 +0200)]
Sync manctl(8) with FreeBSD.

Basically, don't mention the unimplemented purge command anymore.

5 years agoRemove catman(1) since it is no longer needed in modern times.
Sascha Wildner [Sun, 21 Apr 2019 08:24:11 +0000 (10:24 +0200)]
Remove catman(1) since it is no longer needed in modern times.

It was used to bulk format manual pages for faster displaying.

su(1)'s EXAMPLES section was taken from FreeBSD.

Our man(1) command still stores and utilizes manual pages in
/usr/share/man/cat* after this commit.

5 years agousr.bin/man: Some local adjustments, also bump .Dd.
Sascha Wildner [Sun, 21 Apr 2019 07:32:35 +0000 (09:32 +0200)]
usr.bin/man: Some local adjustments, also bump .Dd.

5 years agoAdd FreeBSD's man(1) command unchanged but don't hook in just yet.
Sascha Wildner [Sun, 21 Apr 2019 07:30:26 +0000 (09:30 +0200)]
Add FreeBSD's man(1) command unchanged but don't hook in just yet.

It will use mandoc if the manual page is supported by it (all our
base manual pages are). If unsupported, as could be the case for
ports manual pages, it will fall back to groff. If groff isn't
found, it will advise to install the groff package.

5 years agohammer2 - Improve verbosity of CHECK errors on the console (2)
Matthew Dillon [Sat, 20 Apr 2019 22:19:20 +0000 (15:19 -0700)]
hammer2 - Improve verbosity of CHECK errors on the console (2)

* Also print the PFS name along with the device.

5 years agohammer2 - Improve verbosity of CHECK errors on the console
Matthew Dillon [Sat, 20 Apr 2019 22:01:06 +0000 (15:01 -0700)]
hammer2 - Improve verbosity of CHECK errors on the console

* Improve the verbosity of CHECK errors on the console.  Print
  the block-type in human-readable form, and attempt to trace
  it back to its governing inode and report the inode number
  the error is in.

* Also print the device path string associated with the mount
  so we know what block device the error occurred on.

5 years agoCAM - A few more kmalloc -> xpt_alloc_ccb fixes
Matthew Dillon [Sat, 20 Apr 2019 21:27:01 +0000 (14:27 -0700)]
CAM - A few more kmalloc -> xpt_alloc_ccb fixes

* Fix (now improper) kmalloc()s of ccbs in the ASR and MPS
  drivers.  Properly use xpt_alloc_ccb().

5 years agocross-tools: Do not install manpages during this stage.
zrj [Fri, 19 Apr 2019 17:01:56 +0000 (20:01 +0300)]
cross-tools: Do not install manpages during this stage.

Saves ~1s and few KBs in /usr/obj/.

5 years agolibutil: Prevent leaking slave fd on failed fork.
zrj [Thu, 18 Apr 2019 20:02:31 +0000 (23:02 +0300)]
libutil: Prevent leaking slave fd on failed fork.

5 years agolibc: Implement properly pthread_equal() stub.
zrj [Thu, 18 Apr 2019 20:01:47 +0000 (23:01 +0300)]
libc: Implement properly pthread_equal() stub.

Functional stub is needed to avoid forcing thread library on librecrypto.

5 years agoFix a couple of NULL dereferences in error paths.
Sascha Wildner [Thu, 18 Apr 2019 14:53:24 +0000 (16:53 +0200)]
Fix a couple of NULL dereferences in error paths.

5 years agokernel: Use NULL for pointers, not 0.
Sascha Wildner [Thu, 18 Apr 2019 07:34:20 +0000 (09:34 +0200)]
kernel: Use NULL for pointers, not 0.

5 years agokernel/libiconv: Compare a char with \0.
Sascha Wildner [Thu, 18 Apr 2019 07:34:01 +0000 (09:34 +0200)]
kernel/libiconv: Compare a char with \0.

5 years agohammer2: Improve bulkfree console logging
Matthew Dillon [Thu, 18 Apr 2019 05:14:23 +0000 (22:14 -0700)]
hammer2: Improve bulkfree console logging

* Improve console logging, only print one buf= line and make the
  'pass' lines fit in 80 columns.  Improve the media coverage
  message so users are not confused.

* There is no need to allocate an excessively-large buffer when
  the bitmap for the entire media fits.  Cap the buffer size for
  this case.

5 years agolibc/rpc: Fix -Wtype-limits.
Sascha Wildner [Tue, 16 Apr 2019 08:13:52 +0000 (10:13 +0200)]
libc/rpc: Fix -Wtype-limits.

Instead of triggering a warning by checking if the passed type is signed
split the INT_STRLEN_MACRO() into two, one for unsigned and the other for
signed types. The latter isn't used and was added just for completeness.

5 years agolibc: Fix some more -Wmissing-prototypes warnings.
Sascha Wildner [Tue, 16 Apr 2019 07:06:03 +0000 (09:06 +0200)]
libc: Fix some more -Wmissing-prototypes warnings.

5 years ago<time.h>: Provide time2posix(), posix2time() prototypes.
Sascha Wildner [Sat, 13 Apr 2019 22:40:01 +0000 (00:40 +0200)]
<time.h>: Provide time2posix(), posix2time() prototypes.

They have a manual page too. Also provide offtime() and timeoff()
prototypes.

Fixes some -Wmissing-prototypes warnings.

5 years agoUpdate the pciconf(8) database.
Sascha Wildner [Tue, 16 Apr 2019 06:55:41 +0000 (08:55 +0200)]
Update the pciconf(8) database.

April 12, 2019 snapshot from https://pci-ids.ucw.cz

5 years agogcc80: Document -save-temps=objects addition.
zrj [Tue, 16 Apr 2019 04:15:47 +0000 (07:15 +0300)]
gcc80: Document -save-temps=objects addition.

5 years agogcc80: Update manpages.
zrj [Tue, 16 Apr 2019 03:38:32 +0000 (06:38 +0300)]
gcc80: Update manpages.

5 years agoAdjust makefiles for GCC80 update.
zrj [Tue, 16 Apr 2019 02:43:32 +0000 (05:43 +0300)]
Adjust makefiles for GCC80 update.

5 years agoMerge remote-tracking branch 'origin/vendor/GCC80'
zrj [Tue, 16 Apr 2019 03:28:06 +0000 (06:28 +0300)]
Merge remote-tracking branch 'origin/vendor/GCC80'

5 years agoBring in branch-8 bugfixes into GCC80. vendor/GCC80
zrj [Tue, 16 Apr 2019 02:39:06 +0000 (05:39 +0300)]
Bring in branch-8 bugfixes into GCC80.

Bugfixes as of April 15.
Huge thanks to gcc developers for keeping longterm branches and
backporting/testing all the bugfixes.

5 years agoUpdate GCC80 to version 8.3
zrj [Tue, 16 Apr 2019 02:37:34 +0000 (05:37 +0300)]
Update GCC80 to version 8.3

5 years agobsd.lib.mk: Fix SHLIB_LINK handling.
zrj [Mon, 15 Apr 2019 17:37:14 +0000 (20:37 +0300)]
bsd.lib.mk: Fix SHLIB_LINK handling.

Checks should be for TARGETs. Also .so should be created in LIBDIR version.

No functional change intended on master.

5 years agogcc80: Make LTO plugins installation consistent.
zrj [Mon, 15 Apr 2019 17:33:42 +0000 (20:33 +0300)]
gcc80: Make LTO plugins installation consistent.

Previously my LTO additions were (ab)using bug in bsd.lib.mk.
All other cases in world override both variables.
Do the same fix for gcc47 too.

No functional change intended.

5 years agolibc: Adjust HISTORY sections in a few recently added manual pages.
Sascha Wildner [Sun, 14 Apr 2019 10:58:07 +0000 (12:58 +0200)]
libc: Adjust HISTORY sections in a few recently added manual pages.

5 years agotimingsafe_bcmp.3: Add missing .Lb.
Sascha Wildner [Sun, 14 Apr 2019 01:06:43 +0000 (03:06 +0200)]
timingsafe_bcmp.3: Add missing .Lb.

5 years agoPRIV: Add transitional handling in bsd.lib.mk.
zrj [Fri, 12 Apr 2019 13:03:44 +0000 (16:03 +0300)]
PRIV: Add transitional handling in bsd.lib.mk.

Allow certain versioned private libraries to be installed into public
libraries directory. PRIVATELIB libraries already have mangled names.

5 years agoPRIV: Add helper tool.
zrj [Fri, 12 Apr 2019 07:55:29 +0000 (10:55 +0300)]
PRIV: Add helper tool.

To speed up vendor updates.

5 years agofactor(6): Convert to BN_is_prime_ex().
zrj [Fri, 12 Apr 2019 07:51:56 +0000 (10:51 +0300)]
factor(6): Convert to BN_is_prime_ex().

5 years agohammer2 - Performance work
Matthew Dillon [Fri, 12 Apr 2019 06:16:32 +0000 (23:16 -0700)]
hammer2 - Performance work

* Implement immediate (async) flush follow-through when OS requests
  it, with write-clustering support at the device level if enabled.
  Write-clustering support at the device level is disabled by default
  because H2 already uses a fairly large and efficient 64K block size.

* Change the XOP dispatch for strategy functions.  Further partition
  strategy functions by read or write to prevent reads from getting
  stuck behind long write chains.

  Also do not span-out I/O related to a single inode across too many
  XOP threads as doing so creates a massive amount of unnecessary
  lock contention.

* Significantly improves concurrent filesystem ops and I/O and
  significantly improves sequential filesystem write I/O.

5 years agohammer2 - Add debugging directive for calculating dirent crcs
Matthew Dillon [Fri, 12 Apr 2019 03:08:43 +0000 (20:08 -0700)]
hammer2 - Add debugging directive for calculating dirent crcs

* Add a debugging directive 'dhash' that can calculate the
  crc for extended directory entries (ones that overflow into
  a data block).

5 years agohammer2 - Correct allocator race and related corruption
Matthew Dillon [Fri, 12 Apr 2019 02:04:56 +0000 (19:04 -0700)]
hammer2 - Correct allocator race and related corruption

* When allocating fragments (below 16KB), for example 1K directory
  entries, 1K inodes, compressed file blocks that happen to be
  fragments, or end-of-file fragments, the allocator must ensure
  that any partially freed block is set back to fully allocated.

* In this specific case the allocator was not setting the
  correct bits in the freemap.  The situation never occurs
  on a block boundary (different code is executed which does
  the correct calculation), so the related block will always
  be in a minimally allocated state (either partially allocated
  or fully allocated).

  This means that the corruption can only happen under the specific
  circumstance where a fragment is allocated out of a block that
  the bulkfree code is simultaneously trying to free (marking it
  partially-allocated).  Because the wrong bits are set, the NEXT
  bulkfree pass can also miss the fact that the fragment is
  allocated and finish transitioning the block from partially-
  allocated to fully-free.

  A later allocation then corrupts the block, resulting in CHECK
  errors on the console.

* Because the bulkfree code always comes in and in ALL SITUATIONS OTHER
  THAN THIS SPECIFIC RACE will re-mark the blocks fully-allocated,
  the corruption can ONLY occur during heavy write activity during
  a bulkfree operation, typically when heavy manipulation of directory
  entries or inodes occurs.

* Correct the fragmentary bitmap calculation to set the proper
  bits.

5 years agolibc/rpc: Use sig_t (fixes -Wstrict-prototypes).
Sascha Wildner [Thu, 11 Apr 2019 19:25:18 +0000 (21:25 +0200)]
libc/rpc: Use sig_t (fixes -Wstrict-prototypes).

5 years agolibc/rpc: Fix some -Wstrict-prototypes warnings.
Sascha Wildner [Thu, 11 Apr 2019 18:03:33 +0000 (20:03 +0200)]
libc/rpc: Fix some -Wstrict-prototypes warnings.

5 years agolibc/db: Remove unnecessary casts too.
Sascha Wildner [Thu, 11 Apr 2019 11:03:08 +0000 (13:03 +0200)]
libc/db: Remove unnecessary casts too.

5 years agoftpd(8): Use libutil's pidfile(3) implementation.
Sascha Wildner [Thu, 11 Apr 2019 10:09:43 +0000 (12:09 +0200)]
ftpd(8): Use libutil's pidfile(3) implementation.

This unbreaks buildworld.

Reported-by: zrj
5 years agolibc/db: Fix -Wcast-function-type.
Sascha Wildner [Thu, 11 Apr 2019 09:25:42 +0000 (11:25 +0200)]
libc/db: Fix -Wcast-function-type.

5 years ago<string.h>: Remove legacy declaration of swab().
zrj [Wed, 10 Apr 2019 10:13:28 +0000 (13:13 +0300)]
<string.h>: Remove legacy declaration of swab().

It has prototype in <unistd.h> like in other BSDs and GNU implementations
as per OpenGroups XSI.

5 years agolibc/string: Add timing_safe functions from OpenBSD.
zrj [Tue, 9 Apr 2019 09:17:34 +0000 (12:17 +0300)]
libc/string: Add timing_safe functions from OpenBSD.

Good and small functions for crypto retlated things.
Add manpage and set __pure attributes.

Taken-from: OpenBSD

5 years agolibc/stdlib: Add recallocarray() function.
zrj [Tue, 9 Apr 2019 08:39:05 +0000 (11:39 +0300)]
libc/stdlib: Add recallocarray() function.

It is useful function for security related features, like resizing
memory objects containing sensitive data to avoid information leaking.
Update manpage.

Taken-from: OpenBSD

5 years agolibc/stdlib: Add freezero() function.
zrj [Tue, 9 Apr 2019 08:26:46 +0000 (11:26 +0300)]
libc/stdlib: Add freezero() function.

It is useful function for security related features. Internally uses
explicit_bzero(3) before freeing the pointers. It could be implemented
in nmalloc.c for extra benefits.
Update the manpage.

Taken-from: OpenBSD

5 years agolibc/string: Add explicit_bzero() from OpenBSD.
zrj [Tue, 9 Apr 2019 07:29:03 +0000 (10:29 +0300)]
libc/string: Add explicit_bzero() from OpenBSD.

It is useful function for security related features. It allows to
further manipulate discarded memory region through weak hook.
Update the bzero.3 manpage.

Taken-from: OpenBSD

5 years agolibc/tre: Fix -Wpointer-arith.
Sascha Wildner [Thu, 11 Apr 2019 06:37:39 +0000 (08:37 +0200)]
libc/tre: Fix -Wpointer-arith.

5 years agonscd(8): Remove local pidfile(3) implementation and use libutil's.
Sascha Wildner [Thu, 11 Apr 2019 07:21:07 +0000 (09:21 +0200)]
nscd(8): Remove local pidfile(3) implementation and use libutil's.

5 years agolibc/rpc: Fix some -Wmissing-prototypes.
Sascha Wildner [Wed, 10 Apr 2019 18:31:26 +0000 (20:31 +0200)]
libc/rpc: Fix some -Wmissing-prototypes.

5 years agolibc/locale: Fix -Wmissing-field-initializers.
Sascha Wildner [Wed, 10 Apr 2019 18:06:20 +0000 (20:06 +0200)]
libc/locale: Fix -Wmissing-field-initializers.

5 years agolibc: Remove an age old unused function.
Sascha Wildner [Wed, 10 Apr 2019 13:02:37 +0000 (15:02 +0200)]
libc: Remove an age old unused function.

It was labeled as "historic" even in 1994 and probably much earlier
before FreeBSD existed. Nothing in dports uses it and it was also
not added to Symbol.map so nothing could exist that uses it and is
dynamically linked against our libc.

In-discussion-with: zrj

5 years agolibc: Revert last commit partially. Make function public instead.
Sascha Wildner [Wed, 10 Apr 2019 08:58:00 +0000 (10:58 +0200)]
libc: Revert last commit partially. Make function public instead.

5 years agolibc/net: Align rthdr.c with <netinet6/in6.h> (#if 0 a function).
Sascha Wildner [Wed, 10 Apr 2019 08:48:46 +0000 (10:48 +0200)]
libc/net: Align rthdr.c with <netinet6/in6.h> (#if 0 a function).

Fixes a -Wmissing-prototype.

While here, fix typos in comments.

5 years agolibc: Fix some more -Wmissing-prototype.
Sascha Wildner [Tue, 9 Apr 2019 20:18:46 +0000 (22:18 +0200)]
libc: Fix some more -Wmissing-prototype.

5 years agolibc/glob: Fix a -Wstrict-prototypes warning by bringing back an old fix.
Sascha Wildner [Tue, 9 Apr 2019 18:51:24 +0000 (20:51 +0200)]
libc/glob: Fix a -Wstrict-prototypes warning by bringing back an old fix.

It went like this:

* In 2005, joerg fixed this warning in DragonFly (2a6aec8dab58c89961).

* In 2013, this fix was overwritten without looking with the then still
  broken version from FreeBSD (0d5acd7467c4e95f79).

* In 2015, joerg submitted the fix to FreeBSD and it was committed as
  r288098.

This commit applies back FreeBSD's r288098 to our tree. :)

5 years agoPRIV: Add global PRIVATELIB_CFLAGS.
zrj [Mon, 8 Apr 2019 22:21:33 +0000 (01:21 +0300)]
PRIV: Add global PRIVATELIB_CFLAGS.

In preparations for next updates.