dragonfly.git
2 years agoFix gcc80 -Wmultistatement-macros.
Sascha Wildner [Tue, 23 Jan 2018 09:13:06 +0000 (10:13 +0100)]
Fix gcc80 -Wmultistatement-macros.

2 years agogcc50/Makefile.inc: Add newline at EOF.
Sascha Wildner [Tue, 23 Jan 2018 08:01:40 +0000 (09:01 +0100)]
gcc50/Makefile.inc: Add newline at EOF.

2 years agoRevert "terminfo: Add xterm-termite to Makefile.entries"
Markus Pfeiffer [Mon, 22 Jan 2018 20:27:13 +0000 (20:27 +0000)]
Revert "terminfo: Add xterm-termite to Makefile.entries"

This reverts commit 5f4713d27c03fbf254d1d7e9939f9864261337b6.

2 years agognu/sbin: Raise WARNS generally to 1 via Makefile.inc.
Sascha Wildner [Mon, 22 Jan 2018 17:47:48 +0000 (18:47 +0100)]
gnu/sbin: Raise WARNS generally to 1 via Makefile.inc.

2 years agogcc50/libgcov: Fix whitespace in Makefile.
Sascha Wildner [Mon, 22 Jan 2018 16:50:40 +0000 (17:50 +0100)]
gcc50/libgcov: Fix whitespace in Makefile.

2 years agoRevert "kernel: Disable attributes that take no effect."
zrj [Mon, 22 Jan 2018 16:23:09 +0000 (18:23 +0200)]
Revert "kernel: Disable attributes that take no effect."

This reverts commit 191430ddf0486f992e75ff14effbb5a69e1da2bd.

Needs more checking.

2 years agosbin/mount_autofs: Add description
Tomohiro Kusumi [Mon, 22 Jan 2018 15:29:46 +0000 (17:29 +0200)]
sbin/mount_autofs: Add description

TL;DR users won't be running this command to mount autofs.

Having autofs_enable=YES won't run this command either.
There is a high level command automount(8) and that does everything
based on /etc/auto_master contents.

mount_autofs(8) is a low level version where users can manually
specify things automount(8) internally passes to mount(2).
Thus it's not easy or needed to understand what -fOp options exactly
do without having clear understanding of autofs internal.
But I'll write it here in case interested.

 -f is a string which eventually gets copied to statfs::f_mntfromname.
  Unlike most of the filesystems with backing store, this is just
  a label to identify the autofs mount.
 -O is mount options of autofs(5).
 -p is a prefix string to distinct direct and indirect mapping.

2 years agoFix some -Wunused-const-variable warnings and a -Wmisleading-indentation.
Sascha Wildner [Mon, 22 Jan 2018 12:59:27 +0000 (13:59 +0100)]
Fix some -Wunused-const-variable warnings and a -Wmisleading-indentation.

2 years agodconschat(8): Put the fflush() under 'verbose' too.
Sascha Wildner [Mon, 22 Jan 2018 12:44:12 +0000 (13:44 +0100)]
dconschat(8): Put the fflush() under 'verbose' too.

2 years agodconschat(8): Fix -Wmisleading-indentation.
Sascha Wildner [Mon, 22 Jan 2018 12:37:19 +0000 (13:37 +0100)]
dconschat(8): Fix -Wmisleading-indentation.

2 years agoFix one last -Wnonnull-compare in m4(1).
Sascha Wildner [Mon, 22 Jan 2018 12:31:51 +0000 (13:31 +0100)]
Fix one last -Wnonnull-compare in m4(1).

2 years agoFix gcc80 -Wnonnull-compare.
Sascha Wildner [Mon, 22 Jan 2018 12:26:58 +0000 (13:26 +0100)]
Fix gcc80 -Wnonnull-compare.

For arguments that are checked against NULL in the function, we don't
want a nonnull attribute, because that will cause the NULL check to be
optimized away in higher -O levels and it will also trigger a
-Wnonnull-compare warning.

See also 0f037c78525bfb7df49de8338826e15137859b1d commit message.

2 years agolib/i18n_module: Add a missing break.
Sascha Wildner [Sun, 21 Jan 2018 21:13:30 +0000 (22:13 +0100)]
lib/i18n_module: Add a missing break.

It is intended and correct, but has no correctness implications due
to is94 => is96.

Confirmed-by: cem@freebsd, eadler@freebsd
2 years agorcs: Fix gcc80 warnings (-Wdangling-else and -Wmisleading-indentation).
Sascha Wildner [Sun, 21 Jan 2018 21:03:35 +0000 (22:03 +0100)]
rcs: Fix gcc80 warnings (-Wdangling-else and -Wmisleading-indentation).

2 years agohammer2: Remove duplicate initialialization of fields.
zrj [Sun, 21 Jan 2018 18:37:20 +0000 (20:37 +0200)]
hammer2: Remove duplicate initialialization of fields.

Avoids -Woverride-init diagnostics.

While there, minor whitespace cleanup.

2 years agokernel: Disable few nonnull attributes.
zrj [Sun, 21 Jan 2018 18:31:01 +0000 (20:31 +0200)]
kernel: Disable few nonnull attributes.

To avoid -Wnonnull-compare, similarly as in:
0f037c78525bfb7df49de8338826e15137859b1d

devfs_core.c:   devfs_find_device_by_name()
1st arg checked (NULL == return)
kern_slaballoc.c: kfree()
1st arg checked (NULL == panic)
2nd arg not checked
kern_synch.c:   tsleep()
1st arg checked (NULL == KASSERT)
subr_prf.c: kvcprintf()
1st arg checked (NULL == "(fmt null)")
subr_sbuf.c: sbuf_vprintf()
2nd arg checked (NULL == KASSERT)

2 years agokernel/bus: Avoid panic on NULL passed to kfree().
zrj [Sun, 21 Jan 2018 15:56:58 +0000 (17:56 +0200)]
kernel/bus: Avoid panic on NULL passed to kfree().

Our kfree() will issue panic() on NULL pointer.

Caught-by: gcc80 -Wnonnull
2 years agokernel/ipsec: Avoid -Warray-bounds warning.
zrj [Sun, 21 Jan 2018 15:32:21 +0000 (17:32 +0200)]
kernel/ipsec: Avoid -Warray-bounds warning.

Just panic if something else than 0, 1 or 2 is passed.

2 years agokernel/ipsec: Fix useless m_pkthdr.len check.
zrj [Sun, 21 Jan 2018 15:02:22 +0000 (17:02 +0200)]
kernel/ipsec: Fix useless m_pkthdr.len check.

Compare it against sadb_msg.

Caught-by: gcc80 -Wtautological-compare
2 years agoig_hal: Reindent e1000_ich8lan.c a bit.
zrj [Sun, 21 Jan 2018 14:34:47 +0000 (16:34 +0200)]
ig_hal: Reindent e1000_ich8lan.c a bit.

No functional change.

2 years agoipfw3_nat: Reindent switch cases.
zrj [Sun, 21 Jan 2018 14:15:34 +0000 (16:15 +0200)]
ipfw3_nat: Reindent switch cases.

No functional change.

While there, make add_redir_spool_cfg() and del_redir_spool_cfg() static.

2 years agokernel: Disable attributes that take no effect.
zrj [Sun, 21 Jan 2018 12:46:14 +0000 (14:46 +0200)]
kernel: Disable attributes that take no effect.

Both gcc50 and gcc80 ignore these attributes:
warning: ignoring attribute 'aligned' because it conflicts with attribute 'packed' [-Wattributes]
No differences for final objects.

2 years agonetgraph: Disable unused structs.
zrj [Sun, 21 Jan 2018 11:42:15 +0000 (13:42 +0200)]
netgraph: Disable unused structs.

This needs recheck.

While there, document that musycc and if_mn requires netgraph and
are not compatible with netgraph7.

2 years agousr.sbin/autofs: Drop unneeded header include
Tomohiro Kusumi [Sun, 21 Jan 2018 17:49:56 +0000 (19:49 +0200)]
usr.sbin/autofs: Drop unneeded header include

common.c has no dependency on autofs api itself.

2 years agoSync zoneinfo database with tzdata2018b from ftp://ftp.iana.org/tz/releases
Sascha Wildner [Sun, 21 Jan 2018 11:02:04 +0000 (12:02 +0100)]
Sync zoneinfo database with tzdata2018b from ftp://ftp.iana.org/tz/releases

* Sao Tome and Principe switched from +00 to +01.

* Brazil's DST will now start on November's first Sunday.

* A discrepancy of 4 s in timestamps before 1931 in South Sudan has
    been corrected.

* The abbreviation invented for Bolivia Summer Time (1931-2) is now
    BST instead of BOST.

* Various smaller adjustments.

For a detailed list of changes, see share/zoneinfo/NEWS.

2 years agolimit(1): fix always true condition
Eitan Adler [Sun, 21 Jan 2018 09:01:26 +0000 (01:01 -0800)]
limit(1): fix always true condition

2 years agodrm/i915: Backport fix for a bad bitmask.
zrj [Sat, 20 Jan 2018 19:32:42 +0000 (21:32 +0200)]
drm/i915: Backport fix for a bad bitmask.

No-op, we explictly disable stolen memory in i915_gem_init_stolen().

2 years agocpdup - Additional fixes for -X absolute_path
Matthew Dillon [Sun, 21 Jan 2018 06:51:38 +0000 (22:51 -0800)]
cpdup - Additional fixes for -X absolute_path

* When an absolute path is specified the file is connsidered
  to be local to the machine and is not opened on a remote
  source.

2 years agohammer2 - Correct ip->cluster.nchains gap filler
Matthew Dillon [Sun, 21 Jan 2018 05:51:48 +0000 (21:51 -0800)]
hammer2 - Correct ip->cluster.nchains gap filler

* Fix a bug where gaps in the cluster array were not being
  properly filled.  This is only applicable to clusters
  consisting of more than one element, which we do not
  officially support yet.

Reported-by: zrj (gcc80 found it)
2 years agocpdup - Enhance -X operation
Matthew Dillon [Sun, 21 Jan 2018 05:47:01 +0000 (21:47 -0800)]
cpdup - Enhance -X operation

* Enhance -X operation.  When the cpignore file is specified as an
  absolute path, it may contain wildcards which match against the
  concatenated source path and directory element (as specified in the
  source), instead of just match against directory elements.

* Thus an absolute cpignore file may contain full paths and wildcards.
  For example, if you:

  cpdup -X $cwd/mycpignore /tmp /fubar

  And $cwd/mycpignore (specified with an absolute path) contains:

      /tmp/xyz/swap*

  Then cpdup will not copy files that match against /tmp/xyz/swap*.

  If you specify a relative path for the cpignore file, or use the
  -x option (instead of -X cpignorefile), operation remains as before
  and only matches against the directory element.

2 years ago{bs,quiz}(6): Compare pointers with NULL, not '\0'.
Sascha Wildner [Sat, 20 Jan 2018 23:22:27 +0000 (00:22 +0100)]
{bs,quiz}(6): Compare pointers with NULL, not '\0'.

2 years agodrm/radeon: Disable few unused const arrays.
zrj [Sat, 20 Jan 2018 17:26:41 +0000 (19:26 +0200)]
drm/radeon: Disable few unused const arrays.

No functional change.

2 years agoLINT64: Cleanup for -Wunused-const-variable.
zrj [Sat, 20 Jan 2018 17:22:13 +0000 (19:22 +0200)]
LINT64: Cleanup for -Wunused-const-variable.

2 years agosound/hda: Disable hdac_pcie_snoop struct.
zrj [Sat, 20 Jan 2018 17:17:25 +0000 (19:17 +0200)]
sound/hda: Disable hdac_pcie_snoop struct.

It is currently unused.

2 years agokernel/mpt: Fix evaluation of args in macro.
zrj [Sat, 20 Jan 2018 17:15:45 +0000 (19:15 +0200)]
kernel/mpt: Fix evaluation of args in macro.

2 years agokernel/ncr: Remove unused variable.
zrj [Sat, 20 Jan 2018 17:08:09 +0000 (19:08 +0200)]
kernel/ncr: Remove unused variable.

2 years agokernel/isp: Minor cleanup.
zrj [Sat, 20 Jan 2018 17:06:01 +0000 (19:06 +0200)]
kernel/isp: Minor cleanup.

Remove unused string and use 'rqo' only if ISP_TARGET_MODE.

2 years ago<sys/ktr.h>: Use empty macros for non KTR case.
zrj [Sat, 20 Jan 2018 16:59:46 +0000 (18:59 +0200)]
<sys/ktr.h>: Use empty macros for non KTR case.

Cleans up the gcc80 -Wunused-const-variable warnings.

2 years agokernel/pf: Remove an unused variable.
Sascha Wildner [Sat, 20 Jan 2018 18:58:51 +0000 (19:58 +0100)]
kernel/pf: Remove an unused variable.

2 years agoterminfo: Add xterm-termite to Makefile.entries
Markus Pfeiffer [Sat, 20 Jan 2018 13:59:53 +0000 (13:59 +0000)]
terminfo: Add xterm-termite to Makefile.entries

2 years agotermcap: Add xterm-termite
Markus Pfeiffer [Sat, 20 Jan 2018 11:58:18 +0000 (11:58 +0000)]
termcap: Add xterm-termite

2 years agodrm/linux: Improve linux/log2.h
zrj [Sat, 20 Jan 2018 10:29:06 +0000 (12:29 +0200)]
drm/linux: Improve linux/log2.h

With newer GCC compilers it is no longer possible to easily detect bad
cases of ilog2() usage in drm shim, see:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=72785

There is just a single use case of this macro in drm/radeon/radeon_device.c
for radeon_vm_size, it is already checked to be positive 2^N small number.
So simplify macro and just return 0 for n < 2.

While there, adjust logic to use proper fls(3) and flsll(3) functions
based on integer size (previously both cases where calling flsl(3)).

2 years agoFix few typos.
zrj [Sat, 20 Jan 2018 09:17:16 +0000 (11:17 +0200)]
Fix few typos.

Spotted-by: swildner
2 years agolimits(1): Add missing 'break'.
Sascha Wildner [Sat, 20 Jan 2018 10:48:46 +0000 (11:48 +0100)]
limits(1): Add missing 'break'.

2 years agoktrdump(8): Fix wrongly placed 'break' for floating point unpacking.
Sascha Wildner [Sat, 20 Jan 2018 10:37:04 +0000 (11:37 +0100)]
ktrdump(8): Fix wrongly placed 'break' for floating point unpacking.

2 years agogzip(1): Add some __attribute__((__noreturn__)).
Sascha Wildner [Sat, 20 Jan 2018 10:28:22 +0000 (11:28 +0100)]
gzip(1): Add some __attribute__((__noreturn__)).

2 years agopam_exec(8): Raise WARNS to 3.
Sascha Wildner [Sat, 20 Jan 2018 09:05:45 +0000 (10:05 +0100)]
pam_exec(8): Raise WARNS to 3.

2 years agofsdb(8): Fix some -Wformat warnings and raise WARNS to 2.
Sascha Wildner [Sat, 20 Jan 2018 08:37:51 +0000 (09:37 +0100)]
fsdb(8): Fix some -Wformat warnings and raise WARNS to 2.

2 years agoumount(8): Add missing braces.
Sascha Wildner [Sat, 20 Jan 2018 08:07:57 +0000 (09:07 +0100)]
umount(8): Add missing braces.

2 years agomfiutil(8): Remove -fno-builtin-strftime from CFLAGS.
Sascha Wildner [Fri, 19 Jan 2018 19:13:06 +0000 (20:13 +0100)]
mfiutil(8): Remove -fno-builtin-strftime from CFLAGS.

We don't need this.

2 years agoProvide __{printf,scanf,strfmon,strftime}like() for builtin functions too.
Sascha Wildner [Fri, 19 Jan 2018 19:11:33 +0000 (20:11 +0100)]
Provide __{printf,scanf,strfmon,strftime}like() for builtin functions too.

We want our formats checked in -fno-builtin builds as well.

2 years agobsd.sys.mk: Set -Werror only for compilers that have the warnings fixed.
Sascha Wildner [Fri, 19 Jan 2018 12:23:47 +0000 (13:23 +0100)]
bsd.sys.mk: Set -Werror only for compilers that have the warnings fixed.

This reverts part of b399af1115fa4d2d29e5b5e59eb3a5c3087dccda.

2 years agobsd.{sys,kern}.mk: Apply warning restrictions for future GCCs.
Sascha Wildner [Mon, 31 Jul 2017 19:28:21 +0000 (21:28 +0200)]
bsd.{sys,kern}.mk: Apply warning restrictions for future GCCs.

2 years agoAdd __attribute__((__noreturn__)) to a number of usage() like functions.
Sascha Wildner [Fri, 19 Jan 2018 10:16:52 +0000 (11:16 +0100)]
Add __attribute__((__noreturn__)) to a number of usage() like functions.

These were not caught in the -Wsuggest-attribute=noreturn cleanup
because they were already static at that point. There are likely
more such cases but I don't know how to find them systematically.

2 years agoed(1): Add three __attribute__((__noreturn__)).
Sascha Wildner [Fri, 19 Jan 2018 09:19:26 +0000 (10:19 +0100)]
ed(1): Add three __attribute__((__noreturn__)).

I had missed them in a31274954f5c10e5a80969dcfc719d665f36a26c.

2 years agopfctl(8): Fix two wrong conditions.
Sascha Wildner [Fri, 19 Jan 2018 09:09:09 +0000 (10:09 +0100)]
pfctl(8): Fix two wrong conditions.

Caught by gcc80's -Wtautological-compare option.

2 years agolibthread_xu: Fix issues detected by gcc80.
Sascha Wildner [Fri, 19 Jan 2018 08:55:59 +0000 (09:55 +0100)]
libthread_xu: Fix issues detected by gcc80.

The changes to <pthread.h> all deal with -Wnonnull-compare warnings,
which are issued when a function has a NULL check for a parameter that
at the same time is marked with __attribute__((nonnull(...))), aka
__nonnull(...).

Such __nonnull() decoration only ever catches those cases where NULL is
passed directly to the function, but not any more indirect ways. What
makes matters worse is that in higher optimization levels (-O >= 2),
GCC will happily optimize out any NULL checks within the function for
these parameters.

This means that __nonnull() is generally inferior to a direct NULL check
in the function itself and if we have both, which newer GCCs warn about
with -Wnonnull-compare (that is part of -Wall), we should remove the
__nonnull().

This commit does that for all parameters which our libthread_xu checks
directly in the function. What remains are __nonnull() for parameters
which are _not_ checked in the functions, to at least catch cases where
NULL is passed directly. We should think about adding real checks for
those parameters too.

While here, add a "/* FALLTHROUGH */" comment in thr_printf.c which
fixes a -Wimplicit-fallthrough warning.

2 years agomfiutil(8): Use MAN instead of MAN8.
Sascha Wildner [Thu, 18 Jan 2018 17:34:30 +0000 (18:34 +0100)]
mfiutil(8): Use MAN instead of MAN8.

2 years agoRevert "bsd.sys.mk: support -Wunused-local-typedef"
Sascha Wildner [Thu, 18 Jan 2018 13:35:43 +0000 (14:35 +0100)]
Revert "bsd.sys.mk: support -Wunused-local-typedef"

This reverts commit 14683bdb9c1d41c0d62dc7d11f3fd535973ad258.

It is no longer needed after 6954d52dca31dc7773729c0bf92e14fb1dab5aae.

2 years agogcc50: Move out manpage version handling.
zrj [Thu, 18 Jan 2018 05:27:51 +0000 (07:27 +0200)]
gcc50: Move out manpage version handling.

The Makefile.cco should only affect global ones.

2 years agogcc47: Move out manpage version handling.
zrj [Thu, 18 Jan 2018 05:26:06 +0000 (07:26 +0200)]
gcc47: Move out manpage version handling.

The Makefile.cco should only affect global ones.

2 years agocorepower - Add kabylake support
Matthew Dillon [Wed, 17 Jan 2018 21:30:57 +0000 (13:30 -0800)]
corepower - Add kabylake support

* Add kabylake support (just the id needed)

2 years agoetc/remote: Fix ucom[234].
Sascha Wildner [Wed, 17 Jan 2018 12:30:12 +0000 (13:30 +0100)]
etc/remote: Fix ucom[234].

2 years agokernel/evdev: Whitespace correction in input-event-codes.h
Peeter Must [Wed, 17 Jan 2018 09:32:13 +0000 (11:32 +0200)]
kernel/evdev: Whitespace correction in input-event-codes.h

2 years agokernel/evdev: Update input-event-codes.h
Peeter Must [Wed, 17 Jan 2018 08:48:52 +0000 (10:48 +0200)]
kernel/evdev: Update input-event-codes.h

Taken-from: Linux

2 years agoipfw: Add icmpcodes support.
Sepherosa Ziehau [Tue, 16 Jan 2018 05:07:14 +0000 (13:07 +0800)]
ipfw: Add icmpcodes support.

2 years agokernel - Fix busdma allocation bug
Matthew Dillon [Tue, 16 Jan 2018 00:42:00 +0000 (16:42 -0800)]
kernel - Fix busdma allocation bug

* Fix a bug where kmalloc() could be used to allocate DMA memory
  that the caller intends to be non-cacheable.

  If a non-cacheable tag is specified, bus_dma now uses contigmalloc.

* Use the bus_dmamap_t pointer to differentiate between kmalloc
  and contigmalloc allocated memory, instead of running tag tests.

  This is a bit of a hack, but its the easiest solution.

2 years agokernel - xhci cleanup, lock attach
Matthew Dillon [Tue, 16 Jan 2018 00:40:31 +0000 (16:40 -0800)]
kernel - xhci cleanup, lock attach

* Lock xhci during attach to avoid spurious interrupts from
  hitting the interrupt routine too early.

* Install interrupt after controller startup, but before
  the main usb code begins querying it.

* Cleanup syntax

2 years agokernel - Add a global priority hack for ACPI
Matthew Dillon [Tue, 16 Jan 2018 00:37:35 +0000 (16:37 -0800)]
kernel - Add a global priority hack for ACPI

* Allows ACPI to fully probe and attach all acpi devices before
  attaching any non-ACPI devices.

* May improve device attach stability.

* Currently only implemented at the top-level of the acpi
  device tree.

2 years agokernel - Handle ig4 controller startup errors
Matthew Dillon [Tue, 16 Jan 2018 00:34:06 +0000 (16:34 -0800)]
kernel - Handle ig4 controller startup errors

* Fail the attach on controller startup errors.  For some reason the
  dell xps 13 says there's I2C controller, but the controller appears
  to be permanente disabled and will refuse to enable.

2 years agocpucontrol - Add amd10h support
Matthew Dillon [Tue, 16 Jan 2018 00:28:21 +0000 (16:28 -0800)]
cpucontrol - Add amd10h support

* Add support for ryzen and later microcodes.

* Adds general support for AMD microcodes in their
  packed format.  No need to unpack AMD microcode any
  more, cpucontrol will parse the distribution file
  from AMD.

Taken-from: FreeBSD

2 years agokernel: Add acpi and a number of related drivers to our default config.
Sascha Wildner [Mon, 15 Jan 2018 18:43:39 +0000 (19:43 +0100)]
kernel: Add acpi and a number of related drivers to our default config.

These are: gpio_acpi, gpio_intel, smbus and smbacpi. Leave
ichiic (aka ig4) commented out for now because it seems to have
issues with latest generation Intel CPUs.

Adjust the manual page a bit and remove an obsolete comment in LINT64.

In-discussion-with: dillon, ivadasz

2 years agosbin/mount_autofs: Change include path from fs/ to vfs/
Tomohiro Kusumi [Mon, 15 Jan 2018 17:23:55 +0000 (19:23 +0200)]
sbin/mount_autofs: Change include path from fs/ to vfs/

/usr/include/fs seems to exist as a symlink to vfs/,
but change include path to vfs.

2 years agosbin/mount_autofs: Port mount_autofs(8) from NetBSD
Tomohiro Kusumi [Mon, 15 Jan 2018 15:37:53 +0000 (17:37 +0200)]
sbin/mount_autofs: Port mount_autofs(8) from NetBSD

Christos added this to NetBSD, so why not for DragonFly.
One will write something simlar to this when porting autofs,
until autofs(5)/automount(8)/automountd(8) become usable enough.

While I try to minimize diff from FreeBSD for autofs userspace
by not making trivial style fixes, new things from NetBSD are
appreciated.

-o getargs support is dropped since unsupported on DragonFly.

2 years agokernel/ath_hal: Add missing header to fix build with -Wundef.
Sascha Wildner [Mon, 15 Jan 2018 10:04:15 +0000 (11:04 +0100)]
kernel/ath_hal: Add missing header to fix build with -Wundef.

2 years agokernel/my: Fix -Wundef.
Sascha Wildner [Mon, 15 Jan 2018 09:58:10 +0000 (10:58 +0100)]
kernel/my: Fix -Wundef.

2 years agos/NO_MAN/NOMAN/ in various Makefiles.
Sascha Wildner [Mon, 15 Jan 2018 08:42:53 +0000 (09:42 +0100)]
s/NO_MAN/NOMAN/ in various Makefiles.

2 years agoSimplify some Makefiles.
Sascha Wildner [Mon, 15 Jan 2018 08:31:30 +0000 (09:31 +0100)]
Simplify some Makefiles.

If there is just one source file that is named ${PROG}.c, SRCS does
not need to be set.

2 years agoRemove test/dsched*. This doesn't build anymore after 3573cf7bf66147.
Sascha Wildner [Mon, 15 Jan 2018 07:55:34 +0000 (08:55 +0100)]
Remove test/dsched*. This doesn't build anymore after 3573cf7bf66147.

2 years agoUpdate the pciconf(8) database.
Sascha Wildner [Mon, 15 Jan 2018 06:56:04 +0000 (07:56 +0100)]
Update the pciconf(8) database.

January 14, 2018 snapshot from http://pciids.sourceforge.net/

2 years agosys/vfs/autofs: prevent assert on unmount.
Tomohiro Kusumi [Sun, 14 Jan 2018 14:14:46 +0000 (16:14 +0200)]
sys/vfs/autofs: prevent assert on unmount.

Bring in below commit from NetBSD/autofs. This hasn't existed in
FreeBSD and DragonFly. This at least avoids potential panic via
assertion failure on unmount like PR 3062. Note that the assertion
in autofs_node_delete() is good. There might be mkdir related bug.

The GitHub link below may not be a valid URL in the future.

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/fs/autofs/autofs_vfsops.c.diff?r1=1.2&r2=1.3
(https://github.com/NetBSD/src/commit/59fdd9b6d94c045e89f22f06c9a6f6d6c0fd60f2)

2 years agokernel: Fix some -Wundef warnings in oce(4) and mps(4).
Sascha Wildner [Sat, 13 Jan 2018 22:37:38 +0000 (23:37 +0100)]
kernel: Fix some -Wundef warnings in oce(4) and mps(4).

__FreeBSD_version is not defined in DragonFly, so make it clearer
which path we take.

2 years agosyscons - Skip drawing of the border, when switching to a graphics vty.
Imre Vadász [Sat, 13 Jan 2018 20:37:40 +0000 (21:37 +0100)]
syscons - Skip drawing of the border, when switching to a graphics vty.

* When the target vty in a vty switch is in graphics mode, and we have
  a dumb framebuffer (sc->fbi != NULL), we definitely don't need to
  call sc_set_border().

2 years agosyscons - Use COL and ROW #define constants.
Imre Vadász [Sat, 13 Jan 2018 20:11:40 +0000 (21:11 +0100)]
syscons - Use COL and ROW #define constants.

2 years agoAdd __attribute__((__noreturn__)) to various function prototypes in usr.sbin/.
Sascha Wildner [Sat, 13 Jan 2018 20:37:56 +0000 (21:37 +0100)]
Add __attribute__((__noreturn__)) to various function prototypes in usr.sbin/.

This general cleanup is useful in various ways. It helps the compiler
optimize better and it also helps later GCCs detect better when to give
-Wimplicit-fallthrough warnings and when not.

Found-with: -Wsuggest-attribute=noreturn

2 years agoftp-proxy(8): exit_daemon() never returns, do do not pretend it does.
Sascha Wildner [Fri, 12 Jan 2018 14:02:59 +0000 (15:02 +0100)]
ftp-proxy(8): exit_daemon() never returns, do do not pretend it does.

2 years agodntpd(8): client_main() never returns, so do not pretend it does.
Sascha Wildner [Thu, 11 Jan 2018 10:19:17 +0000 (11:19 +0100)]
dntpd(8): client_main() never returns, so do not pretend it does.

2 years agoautofs: main_auto{,un}mountd() never return, so do not pretend they do.
Sascha Wildner [Wed, 10 Jan 2018 08:09:12 +0000 (09:09 +0100)]
autofs: main_auto{,un}mountd() never return, so do not pretend they do.

2 years agowatchdogd(8): Staticize.
Sascha Wildner [Sat, 13 Jan 2018 12:28:22 +0000 (13:28 +0100)]
watchdogd(8): Staticize.

2 years agotraceroute6(8): Staticize and remove unused variables/functions.
Sascha Wildner [Sat, 13 Jan 2018 12:25:43 +0000 (13:25 +0100)]
traceroute6(8): Staticize and remove unused variables/functions.

2 years agotraceroute(8): Staticize.
Sascha Wildner [Sat, 13 Jan 2018 12:20:06 +0000 (13:20 +0100)]
traceroute(8): Staticize.

2 years agotimed(8): slave() never returns, so don't pretend it does.
Sascha Wildner [Sat, 13 Jan 2018 12:10:47 +0000 (13:10 +0100)]
timed(8): slave() never returns, so don't pretend it does.

2 years agotimed(8): master() never returns, so don't pretend it does.
Sascha Wildner [Sat, 13 Jan 2018 12:08:16 +0000 (13:08 +0100)]
timed(8): master() never returns, so don't pretend it does.

2 years agosensorsd(8): Staticize.
Sascha Wildner [Sat, 13 Jan 2018 11:37:07 +0000 (12:37 +0100)]
sensorsd(8): Staticize.

2 years agorwhod(8): Staticize.
Sascha Wildner [Sat, 13 Jan 2018 11:33:10 +0000 (12:33 +0100)]
rwhod(8): Staticize.

2 years agoroute6d(8): Staticize and remove unused variables/functions.
Sascha Wildner [Sat, 13 Jan 2018 10:35:54 +0000 (11:35 +0100)]
route6d(8): Staticize and remove unused variables/functions.

While here, use __printflike(), fix a va_end() after exit() case and
print strerror() in fatal() only if errno is actually set (this last
one was taken from FreeBSD).

2 years agomld6query(8): Staticize and raise WARNS to 6.
Sascha Wildner [Sat, 13 Jan 2018 09:57:06 +0000 (10:57 +0100)]
mld6query(8): Staticize and raise WARNS to 6.

2 years agomld6query(8): Rename mld6.c -> mld6query.c
Sascha Wildner [Sat, 13 Jan 2018 09:53:53 +0000 (10:53 +0100)]
mld6query(8): Rename mld6.c -> mld6query.c

2 years agogifconfig(8): Staticize and remove some unused variables.
Sascha Wildner [Sat, 13 Jan 2018 09:26:23 +0000 (10:26 +0100)]
gifconfig(8): Staticize and remove some unused variables.

2 years agousr.sbin/autofs: Make automount(8) call chdir("/") before create_directory()
Tomohiro Kusumi [Fri, 12 Jan 2018 19:46:53 +0000 (21:46 +0200)]
usr.sbin/autofs: Make automount(8) call chdir("/") before create_directory()

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224601

Unlike automountd where the daemon is daemonized or lesser-daemonized,
an automount process isn't necessarily at /, and this results in
creating unneeded directories at the current directory.

In the example below, mounting autofs on /mnt/media fails because the
command mkdirs mnt/media instead of /mnt/media. If /mnt/media already
exists the command can mount autofs on /mnt/media, but it still mkdirs
unneeded directories mnt/media.

Calling chdir("/") before creation and restoring the directory after
creation avoids this.

--
[root@]~# automount -L
/mnt/media                -nosuid               -media               # indirect map referenced at /etc/auto_master:8
[root@]~# ls mnt
ls: mnt: No such file or directory
[root@]~# automount
automount: cannot mount map -media on /mnt/media: No such file or directory
[root@]~# mount | grep autofs
[root@]~# ls mnt
media
[root@]~# tree mnt
mnt
`-- media