dragonfly.git
19 years agoenomem() is only used in one file, make it static.
Max Okumoto [Thu, 6 Jan 2005 21:06:25 +0000 (21:06 +0000)]
enomem() is only used in one file, make it static.

19 years agoRemoved unused routines:
Max Okumoto [Thu, 6 Jan 2005 21:04:20 +0000 (21:04 +0000)]
Removed unused routines:
Buf_GetByte()
Buf_GetBytes()
Buf_UngetByte()
Buf_UngetBytes()

19 years agoStyle(9):
Chris Pressey [Thu, 6 Jan 2005 21:00:33 +0000 (21:00 +0000)]
Style(9):
- braces around multiline blocks
- no blank line at start of function
- remove extraneous semicolon.

19 years agoNow that I understand the poorly written BSD routing code and what
Jeffrey Hsu [Thu, 6 Jan 2005 17:59:32 +0000 (17:59 +0000)]
Now that I understand the poorly written BSD routing code and what
it was trying to do, rewrite it in a clear and concise manner.

The old rtalloc1() code written by CSRG had a number of problems:
  1. it was not clear which route was being returned
  2. it was not clear what was being reported
  3. it hid the essential radix tree lookup operation inside a series of
      conditional tests and inline assignments
  4. it had multiple gotos to the inside of if statements
  5. it intermixed reporting code with the operational logic of lookup
      and cloning
  6. it assigns multiple times to key variables
  7. it has unnecessary assignments to key variables
  8. it overloaded the "report" argument parameter, to have two
      different semantics
  9. it misnamed the key route lookup function "rtalloc1", obscuring all uses
      of route lookup.

In contrast to the rtalloc1 code in FreeBSD 4 or the even more convoluted
rtalloc1 code in FreeBSD 5, the DragonFlyBSD version
  A. has a clear control flow that makes the common case obvious
      by highlighting the core call to the radix tree look up function,
      eliminating gotos into if statements,
      and completely separating out the special-case cloning logic
  B. makes it clear which route is being returned
      by only assigning once to the key "rt" variable
      and by expliciting returning "rt" or "clonedroute"
  C. abstracts out the reporting code into its own reporting API
  D. cleans up the semantics of the "report" argument parameter to
      only indicate whether to report a miss and not whether to clone
  E. introduces a simple single-argument API for caller that want to clone
      and those that do not.

19 years agoFix compile error.
Jeffrey Hsu [Thu, 6 Jan 2005 17:54:35 +0000 (17:54 +0000)]
Fix compile error.

19 years agoMove a global variable into local scope for MP safety.
Jeffrey Hsu [Thu, 6 Jan 2005 17:38:26 +0000 (17:38 +0000)]
Move a global variable into local scope for MP safety.

19 years agostyle(9) cleanup.
Joerg Sonnenberger [Thu, 6 Jan 2005 17:34:25 +0000 (17:34 +0000)]
style(9) cleanup.

19 years agoAdd _DIAGASSERT macro for library internal usage. This is not active by
Joerg Sonnenberger [Thu, 6 Jan 2005 17:32:44 +0000 (17:32 +0000)]
Add _DIAGASSERT macro for library internal usage. This is not active by
default.

Obtained-from: NetBSD

19 years ago- Fix a comment typo.
Sascha Wildner [Thu, 6 Jan 2005 14:54:57 +0000 (14:54 +0000)]
- Fix a comment typo.

- Fix bogus ${FOO:Mbar} tests where the actual intent is to check
  if the result set is empty.  While here, replace non-bogus empty
  string comparisons with equivalent empty() checks.
  [FreeBSD rev. 1.68]

19 years agoHiding pointer in typedefs is evil. 'Buffer *' -> 'Buffer'
Max Okumoto [Thu, 6 Jan 2005 13:18:58 +0000 (13:18 +0000)]
Hiding pointer in typedefs is evil. 'Buffer *' -> 'Buffer'

19 years agoAdd missing header files to CVS, for check in on 2005/01/06 10:52:59.
Max Okumoto [Thu, 6 Jan 2005 11:41:47 +0000 (11:41 +0000)]
Add missing header files to CVS, for check in on 2005/01/06 10:52:59.

19 years agoMerge the remaining lst routines into a single file, and remove
Max Okumoto [Thu, 6 Jan 2005 11:35:27 +0000 (11:35 +0000)]
Merge the remaining lst routines into a single file, and remove
the single function files.

19 years agoClean up include header mess. Split nonints into separate header files.
Max Okumoto [Thu, 6 Jan 2005 10:53:00 +0000 (10:53 +0000)]
Clean up include header mess. Split nonints into separate header files.
Headers now only include other headers so they can compile.  Source
files include all required headers.

19 years agoCosmetic cleanups.
Jeffrey Hsu [Thu, 6 Jan 2005 09:14:13 +0000 (09:14 +0000)]
Cosmetic cleanups.

19 years agoAdd icmp6 alias.
Jeroen Ruigrok/asmodai [Thu, 6 Jan 2005 08:43:35 +0000 (08:43 +0000)]
Add icmp6 alias.

Submitted by: Jake Maciejewski

19 years agoGet rid of the register keyword.
Jeroen Ruigrok/asmodai [Thu, 6 Jan 2005 08:33:11 +0000 (08:33 +0000)]
Get rid of the register keyword.

Submitted by: Steve Mynott

19 years agoMake sure the temporary .c file generated from the .y file is properly
Matthew Dillon [Thu, 6 Jan 2005 05:23:45 +0000 (05:23 +0000)]
Make sure the temporary .c file generated from the .y file is properly
removed by the make clean target.

19 years agoRaise WARNS of newfs to 6:
Chris Pressey [Thu, 6 Jan 2005 03:21:00 +0000 (03:21 +0000)]
Raise WARNS of newfs to 6:
- Use static char buffer instead of string constant;
- Move and add some function prototypes;
- Don't reuse a scratch variable, use a real pid_t to hold the
  result of a fork();
- Cast variables as needed (mainly to u_long and u_int32) to avoid
  signed-unsigned comparison warnings;
- Rename some variables to avoid name clashes;
- Mark some parameters as unused;
- Add MOPT_NULL as a struct mntopt constant for terminating a list.

And apply some style(9):
- Move out some loop invariant code, for clarity;
- Remove `register' keywords;
- Make explicit some checks against NULL.

Based-on-patch-by: Peter Schuller
                   <peter_dot_schuller_at_infidyne_dot_com>
Tested-by: typical usage of installer
19 years agoReplace perl code with a sed script.
Sascha Wildner [Thu, 6 Jan 2005 01:20:01 +0000 (01:20 +0000)]
Replace perl code with a sed script.

19 years agoRemoved unintentional added macro.
Max Okumoto [Thu, 6 Jan 2005 00:24:37 +0000 (00:24 +0000)]
Removed unintentional added macro.

19 years agoFix compilation for the USE_KQUEUE case.
Max Okumoto [Wed, 5 Jan 2005 23:32:25 +0000 (23:32 +0000)]
Fix compilation for the USE_KQUEUE case.
Submitted by:   Emil Mikulic <emikulic@dmr.ath.cx>

Taken-from: FreeBSD
Author: harti

19 years agomaxJobs is declared extern in job.h so it cannot be static in job.c.
Max Okumoto [Wed, 5 Jan 2005 23:30:35 +0000 (23:30 +0000)]
maxJobs is declared extern in job.h so it cannot be static in job.c.
Submitted by: Andreas Jochens; Robert Millan <rmh@debian.org>
PR: bin/75210

Taken-from: FreeBSD
Author: harti

19 years agoRemove cleanup functions. There is no reason to free memory
Max Okumoto [Wed, 5 Jan 2005 23:28:20 +0000 (23:28 +0000)]
Remove cleanup functions. There is no reason to free memory
just before exiting (especially given the number of memory leaks) -
it just costs time.

Taken-from: FreeBSD
Author: harti

19 years agoReduce diff between FreeBSD. kqueue code doesn't crash the kernel.
Max Okumoto [Wed, 5 Jan 2005 22:21:46 +0000 (22:21 +0000)]
Reduce diff between FreeBSD.  kqueue code doesn't crash the kernel.

19 years agoUnhook Perl from build.
Joerg Sonnenberger [Wed, 5 Jan 2005 22:03:51 +0000 (22:03 +0000)]
Unhook Perl from build.

19 years agoMove VarREError() to different position in var.c to reduce diffs from FReeBSD.
Max Okumoto [Wed, 5 Jan 2005 20:10:40 +0000 (20:10 +0000)]
Move VarREError() to different position in var.c to reduce diffs from FReeBSD.

19 years ago- Remove both sys/wait.h & sys/types.h - unnecessary
Liam J. Foy [Wed, 5 Jan 2005 18:42:33 +0000 (18:42 +0000)]
- Remove both sys/wait.h & sys/types.h - unnecessary
- Remove registers
- Static functions & Constify arguments

19 years agoMove sa_X macros under _KERNEL protection for now.
Joerg Sonnenberger [Wed, 5 Jan 2005 18:21:20 +0000 (18:21 +0000)]
Move sa_X macros under _KERNEL protection for now.

19 years ago- UNIX conformance: If -r -f on non-existent directory, don't emit error.
Liam J. Foy [Wed, 5 Jan 2005 16:24:19 +0000 (16:24 +0000)]
- UNIX conformance: If -r -f on non-existent directory, don't emit error.
  (FreeBSD, 1.52)
- Constify

Ok'ed by: Joerg@

19 years agoMark binutils-2.14 as dead.
Joerg Sonnenberger [Wed, 5 Jan 2005 15:33:11 +0000 (15:33 +0000)]
Mark binutils-2.14 as dead.

19 years agoWARNS=6 safeness:
Joerg Sonnenberger [Wed, 5 Jan 2005 15:26:05 +0000 (15:26 +0000)]
WARNS=6 safeness:
- GC myname, not used
- constify a lot of string references
- remove done(), use atexit instead
- fix the signal handler, it must not call fclose and can't use exit therefore
- rename local variables which collidate with globals

19 years agoMerge FreeBSD rev 1.70:
Joerg Sonnenberger [Wed, 5 Jan 2005 15:14:04 +0000 (15:14 +0000)]
Merge FreeBSD rev 1.70:
When specifying an interface to ifconfig, first look up the interface
index, then retrieve statistics for that index, rather than retrieving
all interfaces and then looking for a matching name.  This allows the
user to refer to an interface via an alias name.

19 years agoAdd ISO C99's _Exit, which is identical to _exit.
Joerg Sonnenberger [Wed, 5 Jan 2005 11:51:18 +0000 (11:51 +0000)]
Add ISO C99's _Exit, which is identical to _exit.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 5 Jan 2005 02:40:23 +0000 (02:40 +0000)]
Raise WARNS to 6:
- Constify some strings;
- Remove `register' and/or add `int' to variable declarations
  as appropriate.

19 years agoRaise WARNS to 6.
Chris Pressey [Wed, 5 Jan 2005 02:33:25 +0000 (02:33 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Wed, 5 Jan 2005 02:30:23 +0000 (02:30 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 5 Jan 2005 00:46:52 +0000 (00:46 +0000)]
Raise WARNS to 6:
- Mark a parameter as unused.

19 years agoRaise WARNS to 6.
Chris Pressey [Wed, 5 Jan 2005 00:45:31 +0000 (00:45 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Wed, 5 Jan 2005 00:38:38 +0000 (00:38 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 5 Jan 2005 00:34:36 +0000 (00:34 +0000)]
Raise WARNS to 6:
- Constify a string.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 5 Jan 2005 00:33:50 +0000 (00:33 +0000)]
Raise WARNS to 6:
- Constify the typecast in a macro.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 5 Jan 2005 00:32:50 +0000 (00:32 +0000)]
Raise WARNS to 6:
- Initialize a variable before use.

19 years agoWARNS 2->6 and a minor code readability cleanup.
Matthew Dillon [Tue, 4 Jan 2005 23:08:13 +0000 (23:08 +0000)]
WARNS 2->6 and a minor code readability cleanup.

Submitted-by: Jeandre du Toit <jeandre.dutoit@gmail.com>
19 years agoDon't install old GDB documentation.
Joerg Sonnenberger [Tue, 4 Jan 2005 22:25:26 +0000 (22:25 +0000)]
Don't install old GDB documentation.

19 years agoRIP
Joerg Sonnenberger [Tue, 4 Jan 2005 20:00:34 +0000 (20:00 +0000)]
RIP

19 years agoMerge from vendor branch DHCP:
Joerg Sonnenberger [Tue, 4 Jan 2005 19:58:53 +0000 (19:58 +0000)]
Merge from vendor branch DHCP:
Update isc-dhcp to 3.0.2rc3 using patch infrastructure.
Also include the server and relay, but currently without rcNG script.

Submitted-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
19 years agoUpdate isc-dhcp to 3.0.2rc3 using patch infrastructure.
Joerg Sonnenberger [Tue, 4 Jan 2005 19:58:54 +0000 (19:58 +0000)]
Update isc-dhcp to 3.0.2rc3 using patch infrastructure.
Also include the server and relay, but currently without rcNG script.

Submitted-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
19 years agoUpdate isc-dhcp to 3.0.2rc3 using patch infrastructure. vendor/DHCP
Joerg Sonnenberger [Tue, 4 Jan 2005 19:58:53 +0000 (19:58 +0000)]
Update isc-dhcp to 3.0.2rc3 using patch infrastructure.
Also include the server and relay, but currently without rcNG script.

Submitted-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
19 years agoSwitch from binutils 2.14 to binutils 2.15.
Joerg Sonnenberger [Tue, 4 Jan 2005 19:14:18 +0000 (19:14 +0000)]
Switch from binutils 2.14 to binutils 2.15.

19 years agoReplace sockstat(1) Perl script with the C version from FreeBSD 5.
Joerg Sonnenberger [Tue, 4 Jan 2005 18:56:58 +0000 (18:56 +0000)]
Replace sockstat(1) Perl script with the C version from FreeBSD 5.
This doesn't use the binary scan to determine the buffer size, but
calls the sysctl directly twice.

More work is needed to separate the lists again, but this can be
done in tree.

19 years agoMark old file as dead.
Joerg Sonnenberger [Tue, 4 Jan 2005 18:46:32 +0000 (18:46 +0000)]
Mark old file as dead.

19 years agoDon't build the gdb-related documents in binutils-2.15.
Joerg Sonnenberger [Tue, 4 Jan 2005 14:28:06 +0000 (14:28 +0000)]
Don't build the gdb-related documents in binutils-2.15.

19 years agoStyle(9) cleanup:
Chris Pressey [Tue, 4 Jan 2005 05:45:02 +0000 (05:45 +0000)]
Style(9) cleanup:
- Add braces to multi-line blocks;
- Remove casts to void when ignoring return values;
- Explicitly compare a pointer against NULL;
- Remove a blank line at the start of a function;
- Raise WARNS to 6.

Based-on-patch-submitted-by: Dion Blazakis
                             <dion_dot_blazakis_at_gmail_dot_com>

19 years agoStyle(9): remove `register' keywords.
Chris Pressey [Tue, 4 Jan 2005 05:27:47 +0000 (05:27 +0000)]
Style(9): remove `register' keywords.

Submitted-by: Steve Mynott <steve_dot_mynott_at_gmail_dot_com>
19 years agoClarify a run-on sentence by splitting it into two. snprintf() and
Chris Pressey [Tue, 4 Jan 2005 00:00:52 +0000 (00:00 +0000)]
Clarify a run-on sentence by splitting it into two.  snprintf() and
vsnprintf() can return negative values, at least in theory, so don't
make it sound like they can't.

19 years agoIgnore ENOENT when fetching the interface MIB. This can happen for
Joerg Sonnenberger [Mon, 3 Jan 2005 23:47:20 +0000 (23:47 +0000)]
Ignore ENOENT when fetching the interface MIB. This can happen for
sparse lists.

19 years agoCheck that the ifnet_addrs entry is actually used before dereferencing it.
Joerg Sonnenberger [Mon, 3 Jan 2005 23:25:25 +0000 (23:25 +0000)]
Check that the ifnet_addrs entry is actually used before dereferencing it.
Also protect the check with splnet() to avoid further race conditions.

19 years agoSet ip6_v6only to true by default. The administrators who want to use
Jeffrey Hsu [Mon, 3 Jan 2005 22:11:51 +0000 (22:11 +0000)]
Set ip6_v6only to true by default.  The administrators who want to use
IPv4-mapped IPv6 address should tweak the sysctl manually with knowledge
of the security concerns.

Obtained from KAME (itojun).
Reference:
    ftp://ftp.itojun.org/pub/paper/draft-itojun-v6ops-v4mapped-harmful-01.txt
Same as NetBSD rev 1.55 by briggs, FreeBSD rev 1.18 by ume.
Submitted by Hiroki Sato <hrs@allbsd.org>.

19 years agoCorrect a byte-order bug with fragment header scanning.
Jeffrey Hsu [Mon, 3 Jan 2005 22:03:26 +0000 (22:03 +0000)]
Correct a byte-order bug with fragment header scanning.

Obtained from KAME rev 1.331 by suz.
Same as FreeBSD rev 1.54 by ume.
Submitted by Hiroki Sato <hrs@allbsd.org>

19 years ago- Static functions/variables
Liam J. Foy [Mon, 3 Jan 2005 17:35:57 +0000 (17:35 +0000)]
- Static functions/variables
- Remove unused prototype
- Remove unused variable
- int -> pid_t
- Make clear what the 'outfile' is
- Silence GCC/Make WARNS 6 clean
- Constify

Makefile:
- Add WARNS 6
- Add $DragonFly$ tag

19 years agoAdd matching line for ATI Radeon RV280 9200SE.
Jeroen Ruigrok/asmodai [Mon, 3 Jan 2005 06:45:23 +0000 (06:45 +0000)]
Add matching line for ATI Radeon RV280 9200SE.

Submitted by: Gary Tivey [back in November]

19 years agoRaise WARNS to 6.
Chris Pressey [Mon, 3 Jan 2005 01:44:56 +0000 (01:44 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Mon, 3 Jan 2005 01:11:53 +0000 (01:11 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Mon, 3 Jan 2005 01:06:24 +0000 (01:06 +0000)]
Raise WARNS to 6:
- Constify a parameter.

While here, remove register keywords & make local functions static.

19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 22:47:48 +0000 (22:47 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 22:14:13 +0000 (22:14 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Sun, 2 Jan 2005 02:40:20 +0000 (02:40 +0000)]
Raise WARNS to 6:
- Remove unused variables.
- Mark a parameter as unused.

Based-on-patch-submitted-by: Peter Schuller
                             <peter_dot_schuller_at_infidyne_dot_com>

19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 01:45:20 +0000 (01:45 +0000)]
Raise WARNS to 6.

Submitted-by: Peter Schuller <peter_dot_schuller_at_infidyne_dot_com>
19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 01:40:45 +0000 (01:40 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Sun, 2 Jan 2005 01:35:13 +0000 (01:35 +0000)]
Raise WARNS to 6:
- Initialize an uninitialized variable.

19 years agoRaise WARNS to 6:
Chris Pressey [Sun, 2 Jan 2005 01:22:49 +0000 (01:22 +0000)]
Raise WARNS to 6:
- Un-nest a nested extern declaration.

19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 01:18:57 +0000 (01:18 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Sun, 2 Jan 2005 01:13:20 +0000 (01:13 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Sat, 1 Jan 2005 23:09:57 +0000 (23:09 +0000)]
Raise WARNS to 6:
- Constify a parameter;
- Remove unnecessary casts to u_int.

19 years agoRaise WARNS to 6:
Chris Pressey [Sat, 1 Jan 2005 23:02:42 +0000 (23:02 +0000)]
Raise WARNS to 6:
- Use a static character buffer instead of a string constant.

19 years agoRaise WARNS to 6:
Chris Pressey [Sat, 1 Jan 2005 22:06:25 +0000 (22:06 +0000)]
Raise WARNS to 6:
- Constify some strings;
- Make a temporary copy of a const string for parsing purposes.

19 years agoApply style(9):
Chris Pressey [Sat, 1 Jan 2005 22:00:15 +0000 (22:00 +0000)]
Apply style(9):
- Remove casts to void when ignoring return values;
- Use ANSI style function definitions;
- Use STD{IN,OUT,ERR}_FILENO constants for readability;
- Consistently use parentheses after sizeof.

Also raise WARNS to 6:
- Use a static string instead of a string constant;
- Mark a parameter as unused.

19 years agoThere is no such thing as WARNS=7 (yet,) so use WARNS=6.
Chris Pressey [Sat, 1 Jan 2005 21:50:23 +0000 (21:50 +0000)]
There is no such thing as WARNS=7 (yet,) so use WARNS=6.

Pointed-out-by: liamfoy
19 years agoRaise WARNS to 6.
Chris Pressey [Sat, 1 Jan 2005 21:28:27 +0000 (21:28 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6.
Chris Pressey [Sat, 1 Jan 2005 21:24:07 +0000 (21:24 +0000)]
Raise WARNS to 6.

19 years agoRaise WARNS to 6:
Chris Pressey [Sat, 1 Jan 2005 21:10:43 +0000 (21:10 +0000)]
Raise WARNS to 6:
- Constify some strings.

19 years agoRaise WARNS to 6.
Chris Pressey [Sat, 1 Jan 2005 21:07:39 +0000 (21:07 +0000)]
Raise WARNS to 6.

19 years ago- Remove duplicate headers
Liam J. Foy [Sat, 1 Jan 2005 15:56:56 +0000 (15:56 +0000)]
- Remove duplicate headers

19 years agoSlap 2005 into the copyright. Happy New Year!
Hiten Pandya [Sat, 1 Jan 2005 11:15:44 +0000 (11:15 +0000)]
Slap 2005 into the copyright.  Happy New Year!

19 years agoSlap 2005 into the COPYRIGHT. Happy New Year!
Hiten Pandya [Sat, 1 Jan 2005 11:08:57 +0000 (11:08 +0000)]
Slap 2005 into the COPYRIGHT.  Happy New Year!

19 years agoFix double-free problem when sysctl net.inet.ip.rtexpire=0.
Jeffrey Hsu [Sat, 1 Jan 2005 09:20:05 +0000 (09:20 +0000)]
Fix double-free problem when sysctl net.inet.ip.rtexpire=0.

19 years agoFix double-free problem when sysctl net.inet.ip.rtexpire=0.
Jeffrey Hsu [Sat, 1 Jan 2005 09:19:40 +0000 (09:19 +0000)]
Fix double-free problem when sysctl net.inet.ip.rtexpire=0.

Obtained from:  KAME rev 1.24 by SUZUKI Shinsuke <suz@kame.net>
Equivalent to:  FreeBSD rev 1.1.2.4 by SUZUKI Shinsuke <suz@kame.net>
Submitted by:  Hiroki Sato <hrs@allbsd.org>

19 years agoStyle(9): the return type of strcmp() is not a boolean, so don't
Chris Pressey [Sat, 1 Jan 2005 01:36:02 +0000 (01:36 +0000)]
Style(9): the return type of strcmp() is not a boolean, so don't
treat it as one, explcitly compare it against zero instead.

19 years agoRaise WARNS to 6:
Chris Pressey [Sat, 1 Jan 2005 00:22:33 +0000 (00:22 +0000)]
Raise WARNS to 6:
- Include missing header files.

19 years agoUse real getopt() handling instead of the hand-rolled and IOCCC-worthy
Chris Pressey [Sat, 1 Jan 2005 00:13:49 +0000 (00:13 +0000)]
Use real getopt() handling instead of the hand-rolled and IOCCC-worthy
"Micro getopt()" macros.  In the process, clean up the option-handling
code:
- Sort the options in the switch statement;
- Plug piddling memory leaks when processing repeated options by
  freeing strings before allocating them for a second time;
- Die with a fatal error if the requested report file cannot be
  opened for appending;
- Don't call init() before usage() (to prevent the usage message
  being mangled by changes to the terminal settings;)
- Raise WARNS to 6.

19 years agoJournaling layer work. Add shims and skeleton code for most of the
Matthew Dillon [Fri, 31 Dec 2004 23:48:08 +0000 (23:48 +0000)]
Journaling layer work.  Add shims and skeleton code for most of the
remaining modifying VFS ops.

19 years agoClean up the usage message, both in usage() and in the main program
Chris Pressey [Fri, 31 Dec 2004 23:30:27 +0000 (23:30 +0000)]
Clean up the usage message, both in usage() and in the main program
comment, both stylistically (sort and combine options) and for
accuracy (following the manual page, make note of the -s and -S flags,
and use the term 'send' instead of 'say' to reduce confusion (SAY is
the name of a command for output to the user, not the connection.))

19 years agoMerge with FreeBSD revision 1.21 (kientzle):
Chris Pressey [Fri, 31 Dec 2004 22:31:18 +0000 (22:31 +0000)]
Merge with FreeBSD revision 1.21 (kientzle):

"Rename logf --> chat_logf  to avoid naming conflicts
 with GCC built-in (and with C90 reserved library name).

 Approved by: gordon (Mentor)"

19 years agoRestore b_data prior to calling relpbuf(). This isn't really necessary but
Matthew Dillon [Fri, 31 Dec 2004 22:30:19 +0000 (22:30 +0000)]
Restore b_data prior to calling relpbuf().  This isn't really necessary but
it's a good cleanup to do in case the pbuf API changes later on.

Submitted-by: Found in Chris Pressey's tree, source is a mystery!
19 years agoMake an example follow the recommendation given in the immediately
Chris Pressey [Fri, 31 Dec 2004 21:43:20 +0000 (21:43 +0000)]
Make an example follow the recommendation given in the immediately
preceding paragraph, i.e. that function prototypes in userland
code should not include parameter names.

19 years agoMerge with FreeBSD revision 1.20 (markm):
Chris Pressey [Fri, 31 Dec 2004 21:16:09 +0000 (21:16 +0000)]
Merge with FreeBSD revision 1.20 (markm):

"Big cleanup. Remove unused stuff, make closer to style(9).

 OK'ed by: peter (long time ago)"

In detail:
- Reorder #includes.
- Assume stdarg.h, remove __V() macro.
- Assume TERMIOS, remove TERMIO code.
- Remove SUNOS-specific, SOL2-specific, and ultrix-specific code.
- Remove unused code.
- Remove `register' keywords.
- Add `__unused' to unused function parameters.
- Reduce warnings.

19 years agoApply some style(9):
Chris Pressey [Fri, 31 Dec 2004 20:58:17 +0000 (20:58 +0000)]
Apply some style(9):
- Remove casts to void when ignoring return values.
- Make local functions and prototypes static.
- Use array of gid_t, not array of int, for getgroups()
  (same as FreeBSD revision 1.22.)

Submitted-by: Alexander 'alxl' Lobachov <alxl_at_alxl_dot_info>
19 years agoRaise WARNS to 7 and apply some style(9):
Chris Pressey [Fri, 31 Dec 2004 20:32:59 +0000 (20:32 +0000)]
Raise WARNS to 7 and apply some style(9):
- Remove casts to void when ignoring return values
- Remove `register' keywords.

Submitted-by: Alexander 'alxl' Lobachov <alxl_at_alxl_dot_info>
19 years agoMerge with FreeBSD revision 1.18 (jmallett):
Chris Pressey [Fri, 31 Dec 2004 19:53:51 +0000 (19:53 +0000)]
Merge with FreeBSD revision 1.18 (jmallett):

"Remove local prototypes for main()."

and with revision 1.19 (charnier):

"Replace various spelling with FALLTHROUGH which is lint()able"

19 years agoMerge with FreeBSD revision 1.16 (sheldonh):
Chris Pressey [Fri, 31 Dec 2004 19:32:02 +0000 (19:32 +0000)]
Merge with FreeBSD revision 1.16 (sheldonh):

"Use STD{ERR,IN,OUT}_FILENO instead of their numeric values.  The
 definitions are more readable, and it's possible that they're
 more portable to pathalogical platforms.

 Submitted by:   David Hill <david@phobia.ms>"