dragonfly.git
19 years agomkdep(1) seems to want the current directory on the include path,
Chris Pressey [Wed, 12 Jan 2005 04:03:46 +0000 (04:03 +0000)]
mkdep(1) seems to want the current directory on the include path,
so reinstate it in the Makefile.

Reported-by: drhodus
19 years agoNow that we have dhcpd and dhcrelay in base, fix the inherited rcNG scripts
Joerg Sonnenberger [Wed, 12 Jan 2005 02:32:15 +0000 (02:32 +0000)]
Now that we have dhcpd and dhcrelay in base, fix the inherited rcNG scripts
and install them.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 12 Jan 2005 01:36:50 +0000 (01:36 +0000)]
Raise WARNS to 6:
- Initialize a variable that GCC can't tell will never be used
  uninitialized.

19 years agoRaise WARNS to 6:
Chris Pressey [Wed, 12 Jan 2005 01:20:26 +0000 (01:20 +0000)]
Raise WARNS to 6:
- Use a fully-specified NULL-filled entry to terminate an array
  initializer;
- Remove an inner-block redeclaration of a variable with the same
  name and purpose as the local in the outer block.

19 years agoRaise WARNS to 6.
Chris Pressey [Wed, 12 Jan 2005 01:17:54 +0000 (01:17 +0000)]
Raise WARNS to 6.

Advised-by: joerg
19 years agoReduce warnings when compiled under WARNS=6:
Chris Pressey [Wed, 12 Jan 2005 00:26:03 +0000 (00:26 +0000)]
Reduce warnings when compiled under WARNS=6:
- Constify many char *'s;
- Rename a local variable;
- Initialize an option list element using strdup (as is done elsewhere)
  instead of directly assigning a string constant to it.

19 years agoCorrectly reset place in getopt_long_only the next time it is used.
Joerg Sonnenberger [Wed, 12 Jan 2005 00:08:13 +0000 (00:08 +0000)]
Correctly reset place in getopt_long_only the next time it is used.
Remove unused retval in getopt wrapper.

19 years agoRaise WARNS to 3:
Chris Pressey [Wed, 12 Jan 2005 00:03:40 +0000 (00:03 +0000)]
Raise WARNS to 3:
- Make an int variable unsigned;
- Use WARNS level instead of hand-specifying warning flags;
- Remove unneeded -I. -I${.CURDIR} from CFLAGS in Makefile.

19 years agoRaise WARNS to 6:
Chris Pressey [Tue, 11 Jan 2005 23:58:55 +0000 (23:58 +0000)]
Raise WARNS to 6:
- Constify several char *'s.
- Mark unused parameters as __unused.
- Rename local variables.
- Format function prototypes and remove parameter names.
- Expand a macro that was only used twice (on the same
  parameter) into a real variable to eliminate signed
  versus unsigned comparison warning [1].

Submitted-by: Larry Lansing <lansil_at_fuzzynerd_dot_com>
Additional-work-by: cpressey [1]
19 years agoDon't write the name of the sysctl to a temporary variable and truncate
Joerg Sonnenberger [Tue, 11 Jan 2005 23:36:39 +0000 (23:36 +0000)]
Don't write the name of the sysctl to a temporary variable and truncate
it on the '=' there. If the argument is actually longer than the buffer,
this would result in a NULL reference. Instead, allocate the necessary
buffer with alloca and copy the name part.

Discovered-by: Suleiman Souhlal <ssouhlal@FreeBSD.org>
19 years agounknown_incoming may be customized so we only install it if it doesn't
Sascha Wildner [Tue, 11 Jan 2005 23:01:31 +0000 (23:01 +0000)]
unknown_incoming may be customized so we only install it if it doesn't
already exist.

Noticed-by: Joerg Anslik <joerg@anslik.de>
19 years ago- Add WARNS?=6 and $DragonFly$ to Makefile.
Max Okumoto [Tue, 11 Jan 2005 22:20:52 +0000 (22:20 +0000)]
- Add WARNS?=6 and $DragonFly$ to Makefile.

19 years ago- Add back marco that joerg added that I deleted, because I thought
Max Okumoto [Tue, 11 Jan 2005 21:27:13 +0000 (21:27 +0000)]
- Add back marco that joerg added that I deleted, because I thought
  I added it by accident. :-)

19 years agoScheduled mdoc(7) sweep.
Max Okumoto [Tue, 11 Jan 2005 21:21:09 +0000 (21:21 +0000)]
Scheduled mdoc(7) sweep.

Taken-from: FreeBSD
Author: ru

19 years ago- Clean up wc (remove (void) etc)
Liam J. Foy [Tue, 11 Jan 2005 20:03:11 +0000 (20:03 +0000)]
- Clean up wc (remove (void) etc)
- Remove unnecessary cast
- Add WARNS 6

Submitted by: Alexander 'alxl' Lobachov <alxl@alxl.info>

19 years agoAdd some documentation for ntpd_flags.
Sascha Wildner [Tue, 11 Jan 2005 20:01:07 +0000 (20:01 +0000)]
Add some documentation for ntpd_flags.

19 years ago- Remove unnecessary headers
Liam J. Foy [Tue, 11 Jan 2005 19:36:09 +0000 (19:36 +0000)]
- Remove unnecessary headers
- Remove main proto
- Constify
- Add WARNS 6
- Minor cleans

19 years agontpdate(8) is gone and has been replaced by rdate(8).
Sascha Wildner [Tue, 11 Jan 2005 19:14:58 +0000 (19:14 +0000)]
ntpdate(8) is gone and has been replaced by rdate(8).

19 years agoAdd default if_re_load line.
Joerg Sonnenberger [Tue, 11 Jan 2005 18:29:38 +0000 (18:29 +0000)]
Add default if_re_load line.

19 years agotypo
Joerg Sonnenberger [Tue, 11 Jan 2005 15:03:48 +0000 (15:03 +0000)]
typo

19 years agoAdd gmp handling to upgrade_etc.
Joerg Sonnenberger [Tue, 11 Jan 2005 14:44:15 +0000 (14:44 +0000)]
Add gmp handling to upgrade_etc.

19 years agoRemove LIBGMP and LIBMP.
Joerg Sonnenberger [Tue, 11 Jan 2005 14:36:49 +0000 (14:36 +0000)]
Remove LIBGMP and LIBMP.

19 years agoDeorbit libgmp.
Joerg Sonnenberger [Tue, 11 Jan 2005 14:36:02 +0000 (14:36 +0000)]
Deorbit libgmp.

19 years agoConvert to keyserv, telnetd and telnet to libcrypto's BIGNUM
Joerg Sonnenberger [Tue, 11 Jan 2005 13:22:41 +0000 (13:22 +0000)]
Convert to keyserv, telnetd and telnet to libcrypto's BIGNUM
implementatation.

19 years agoRemove another Perl left over.
Joerg Sonnenberger [Tue, 11 Jan 2005 13:12:32 +0000 (13:12 +0000)]
Remove another Perl left over.

Submitted-by: Chris Pressey <cpressey@catseye.mine.nu>
19 years agoRemove some debugging printfs. Fix an error message.
Joerg Sonnenberger [Tue, 11 Jan 2005 13:08:35 +0000 (13:08 +0000)]
Remove some debugging printfs. Fix an error message.

19 years ago- Swap location of Buf_Expand() function.
Max Okumoto [Tue, 11 Jan 2005 05:51:46 +0000 (05:51 +0000)]
- Swap location of Buf_Expand() function.

19 years ago- Pass NULL as 2nd param to Buf_GetAll(buf, &len), the callers don't need
Max Okumoto [Tue, 11 Jan 2005 05:13:33 +0000 (05:13 +0000)]
- Pass NULL as 2nd param to Buf_GetAll(buf, &len), the callers don't need
  that info.

19 years agoAdd forgotten cast back. This code depends on BASE being short and
Joerg Sonnenberger [Tue, 11 Jan 2005 01:08:06 +0000 (01:08 +0000)]
Add forgotten cast back. This code depends on BASE being short and
signed.

19 years agoSwitch chkey/newkey to use libcrypto instead of libmp for the internal
Joerg Sonnenberger [Tue, 11 Jan 2005 00:58:23 +0000 (00:58 +0000)]
Switch chkey/newkey to use libcrypto instead of libmp for the internal
PK generation.

Submitted-by: Dmitri Nikulin <setagllib@optusnet.com.au>
Additional cleanups and bugfixes by myself.

19 years agoWARNS=6 cleaness.
Joerg Sonnenberger [Tue, 11 Jan 2005 00:51:11 +0000 (00:51 +0000)]
WARNS=6 cleaness.

19 years ago- Inline Buf_OvAddByte() since it is only used in one place.
Max Okumoto [Tue, 11 Jan 2005 00:30:22 +0000 (00:30 +0000)]
- Inline Buf_OvAddByte() since it is only used in one place.

19 years agoMake newkey WARNS=6 clean.
Joerg Sonnenberger [Tue, 11 Jan 2005 00:29:12 +0000 (00:29 +0000)]
Make newkey WARNS=6 clean.

19 years agoMark OpenSSL 0.9.7d as dead.
Joerg Sonnenberger [Mon, 10 Jan 2005 22:36:43 +0000 (22:36 +0000)]
Mark OpenSSL 0.9.7d as dead.

19 years agoAdd splitpatch.
Joerg Sonnenberger [Mon, 10 Jan 2005 22:20:27 +0000 (22:20 +0000)]
Add splitpatch.

19 years agoAdd local_syms script. Nice for cleaning the kernel namespace.
Joerg Sonnenberger [Mon, 10 Jan 2005 22:13:45 +0000 (22:13 +0000)]
Add local_syms script. Nice for cleaning the kernel namespace.

19 years agoUpdate OpenBSD tags to reflect which revisions we are synced with.
Sascha Wildner [Mon, 10 Jan 2005 21:45:33 +0000 (21:45 +0000)]
Update OpenBSD tags to reflect which revisions we are synced with.

19 years agoRaise WARNS to 6 and generally clean up:
Chris Pressey [Mon, 10 Jan 2005 20:27:51 +0000 (20:27 +0000)]
Raise WARNS to 6 and generally clean up:
- Constify and use size_t instead of int;
- Merge and add variables as appropriate;
- Use more appropriate printf() format specifier, and replace
  printf() with fwrite() in one instance;
- Replace name2oid() with sysctlnametomib().  Retain old error
  message when the sysctl's name cannot be resolved to a MIB.

Based-on-coincident-patches-by: myself, and Peter Schuller
                        <peter_dot_schuller_at_infidyne_dot_com>
Refined-with-input-from: joerg
OK'ed-by: joerg

19 years agoRemove perl's man path.
Joerg Sonnenberger [Mon, 10 Jan 2005 19:57:05 +0000 (19:57 +0000)]
Remove perl's man path.

19 years agoRemove documentation of NOPERL, it's the default now. Don't create an
Joerg Sonnenberger [Mon, 10 Jan 2005 19:56:17 +0000 (19:56 +0000)]
Remove documentation of NOPERL, it's the default now. Don't create an
include hierachie for perl.

19 years agoRemove wx(4) man page as well.
Joerg Sonnenberger [Mon, 10 Jan 2005 19:38:08 +0000 (19:38 +0000)]
Remove wx(4) man page as well.

19 years agoRemove wx(4). It's been superseded by em(4).
Joerg Sonnenberger [Mon, 10 Jan 2005 19:37:23 +0000 (19:37 +0000)]
Remove wx(4). It's been superseded by em(4).

19 years ago- Nothing modifies outPtr in the Buffer object. Since it is set to
Max Okumoto [Mon, 10 Jan 2005 18:50:12 +0000 (18:50 +0000)]
- Nothing modifies outPtr in the Buffer object.  Since it is set to
  buffer when the object is created, replace references to it with
  buffer, and remove outPtr field.

19 years agoBetter diagnostic for getopt_long_only.
Joerg Sonnenberger [Mon, 10 Jan 2005 18:30:00 +0000 (18:30 +0000)]
Better diagnostic for getopt_long_only.

19 years agoFix two small bugs in getopt_long_only handling:
Joerg Sonnenberger [Mon, 10 Jan 2005 17:40:32 +0000 (17:40 +0000)]
Fix two small bugs in getopt_long_only handling:
- a short option followed by a long option is parsed as that
  (inspired by OpenBSD)
- the place variable has to be reset after long option parsing failed

19 years agoAdd support for getopt_long_only. It allows using long options with a single
Joerg Sonnenberger [Mon, 10 Jan 2005 16:45:15 +0000 (16:45 +0000)]
Add support for getopt_long_only. It allows using long options with a single
dash by prefering them over aggregated short options.

19 years ago- Move code into buff.c by converting #define macros to real functions.
Max Okumoto [Mon, 10 Jan 2005 16:21:14 +0000 (16:21 +0000)]
- Move code into buff.c by converting #define macros to real functions.

19 years agoMove the handling of '--' as argument into getopt_internal. Add a parameter
Joerg Sonnenberger [Mon, 10 Jan 2005 15:38:16 +0000 (15:38 +0000)]
Move the handling of '--' as argument into getopt_internal. Add a parameter
to getopt_internal and getopt_internal_short to activate support for long
options. Disable the special 'W' handling for getopt(). Correctly handle
long option like arguments ('--l') as arguments '-' and 'l'.

19 years agoMove short option parsing into its own function. Constify the local char *
Joerg Sonnenberger [Mon, 10 Jan 2005 14:11:40 +0000 (14:11 +0000)]
Move short option parsing into its own function. Constify the local char *
pointer.

19 years ago- Replace Buf_Discard(buf, size) with Buf_Clear(buf). This simplifies
Max Okumoto [Mon, 10 Jan 2005 12:36:06 +0000 (12:36 +0000)]
- Replace Buf_Discard(buf, size) with Buf_Clear(buf).  This simplifies
  the code, and make clear what is taking place.

19 years ago- clean up a leftover in binutils215/ld
YONETANI Tomokazu [Mon, 10 Jan 2005 05:00:37 +0000 (05:00 +0000)]
- clean up a leftover in binutils215/ld
- rm: /usr/libexec/binutils214: is a directory

Noticed-by: David Rhodus
19 years ago- Last of the easy constifications.
Max Okumoto [Mon, 10 Jan 2005 01:07:42 +0000 (01:07 +0000)]
- Last of the easy constifications.

19 years ago- Constify more functions.
Max Okumoto [Sun, 9 Jan 2005 23:14:42 +0000 (23:14 +0000)]
- Constify more functions.

19 years ago- Cleanup white space. style(9)
Max Okumoto [Sun, 9 Jan 2005 23:03:28 +0000 (23:03 +0000)]
- Cleanup white space. style(9)

19 years agoRIP Perl.
Joerg Sonnenberger [Sun, 9 Jan 2005 22:50:10 +0000 (22:50 +0000)]
RIP Perl.

19 years ago- Moved unused argc, temp variable into small scope.
Max Okumoto [Sun, 9 Jan 2005 22:23:25 +0000 (22:23 +0000)]
- Moved unused argc, temp variable into small scope.

19 years agoIncrease WARNS to 6
Max Okumoto [Sun, 9 Jan 2005 18:32:28 +0000 (18:32 +0000)]
Increase WARNS to 6

19 years ago- Move sh_builtin string array into shellneed(). It is the only
Max Okumoto [Sun, 9 Jan 2005 17:05:33 +0000 (17:05 +0000)]
- Move sh_builtin string array into shellneed().  It is the only
  function that uses it.

- Correct comment describing shellneed() function.

- Since shellneed() can never return -1, remove code that checks
  for it in the caller.

19 years ago- Add WARNS 6 and make WARNS 6 clean
Liam J. Foy [Sun, 9 Jan 2005 16:20:54 +0000 (16:20 +0000)]
- Add WARNS 6 and make WARNS 6 clean
- Remove registers
- Move global variables into main()
- Static utmpcmp()
- Remove cast in switch()
- Remove duplicate utmpcmp prototype
- Minor cleanup (ANSI, remove (void))
- Add $DragonFly$ tag

Submitted by: Richard Bradshaw <theglassishalfempty@gmail.com>

19 years agoDon't create binutils 2.14 and perl directories. Remove perl and
Joerg Sonnenberger [Sun, 9 Jan 2005 16:01:23 +0000 (16:01 +0000)]
Don't create binutils 2.14 and perl directories. Remove perl and
binutils214 [later only, if gcc34 and binutils215 are installed].

19 years agoIt's WARNS?=6, not WARNS=6.
Joerg Sonnenberger [Sun, 9 Jan 2005 15:41:38 +0000 (15:41 +0000)]
It's WARNS?=6, not WARNS=6.

Noticed-by: corecode.
19 years ago- Add WARNS 6
Liam J. Foy [Sun, 9 Jan 2005 13:38:52 +0000 (13:38 +0000)]
- Add WARNS 6

19 years ago- Add -k option for whois.krnic.net (hold details of IP address
Liam J. Foy [Sun, 9 Jan 2005 13:30:06 +0000 (13:30 +0000)]
- Add -k option for whois.krnic.net (hold details of IP address
  allocations within Korea) - FreeBSD
- Remove unnecessary casts
- Constify
- Update man page to reflect new option (-k)

19 years agoRaise WARNS to 6:
Chris Pressey [Sun, 9 Jan 2005 04:43:33 +0000 (04:43 +0000)]
Raise WARNS to 6:
- Add function prototypes.
- Rename a parameter.

Submitted-by: Larry Lansing <lansil_at_fuzzynerd_dot_com>
19 years agoAdd /sbin/mountctl to the build.
Matthew Dillon [Sun, 9 Jan 2005 03:06:48 +0000 (03:06 +0000)]
Add /sbin/mountctl to the build.

19 years agoRevamp the argument format a bit, add basic suppot for creating, deleting,
Matthew Dillon [Sun, 9 Jan 2005 03:06:14 +0000 (03:06 +0000)]
Revamp the argument format a bit, add basic suppot for creating, deleting,
and listing journals.  None of the option features can be specified yet,
and the journaling code is only logging a few VOPs at the moment for testing
purposes, but you can actually create a journaling stream now.

19 years agoAdd support for retrieving the journal status via mountctl. Increase some
Matthew Dillon [Sun, 9 Jan 2005 03:04:53 +0000 (03:04 +0000)]
Add support for retrieving the journal status via mountctl.  Increase some
of the buffer limits.

19 years agoThis is the initial skeleton for the new mountctl utility. Manual page,
Matthew Dillon [Sat, 8 Jan 2005 23:22:35 +0000 (23:22 +0000)]
This is the initial skeleton for the new mountctl utility.  Manual page,
options parsing, sanity checks, and the scan-callback framework.

19 years agoConstify more functions.
Max Okumoto [Sat, 8 Jan 2005 22:27:02 +0000 (22:27 +0000)]
Constify more functions.

19 years agoConstifying functions.
Max Okumoto [Sat, 8 Jan 2005 21:58:23 +0000 (21:58 +0000)]
Constifying functions.

19 years agoANSIfy. Fix various warnings. Statify.
Joerg Sonnenberger [Sat, 8 Jan 2005 21:33:34 +0000 (21:33 +0000)]
ANSIfy. Fix various warnings. Statify.

Submitted-by: Peter Schuller <peter.schuller@infidyne.com>
19 years agoConstify more functions.
Max Okumoto [Sat, 8 Jan 2005 20:17:05 +0000 (20:17 +0000)]
Constify more functions.

19 years agoFurther cleanup:
Chris Pressey [Sat, 8 Jan 2005 19:39:40 +0000 (19:39 +0000)]
Further cleanup:
- When fs_Bytes is zero, assign NULL (rather than "") to fs_Data.
- Check that fs_Bytes is nonzero before subsequently using fs_Data.

Requested-by: dillon
Tested-by: typical usage of installer
19 years agoDon't clobber match_str in buildmatch by strdup'ing the string internally.
Joerg Sonnenberger [Sat, 8 Jan 2005 19:19:26 +0000 (19:19 +0000)]
Don't clobber match_str in buildmatch by strdup'ing the string internally.

Submitted-by: Peter Schuller <peter.schuller@infidyne.com>
Additionally remove func_name define, use __func__ instead.

19 years agoFix a memory leak in regex.
Matthew Dillon [Sat, 8 Jan 2005 19:17:01 +0000 (19:17 +0000)]
Fix a memory leak in regex.

Submitted-by: Steve Mynott <steve.mynott@gmail.com>
Taken-from: http://www.freebsd.org/cgi/query-pr.cgi?pr=75656

19 years agoFix one of probably several smbfs issues. smbfs is improperly tracking
Matthew Dillon [Sat, 8 Jan 2005 18:57:48 +0000 (18:57 +0000)]
Fix one of probably several smbfs issues.  smbfs is improperly tracking
open() and close() calls and closing the remote FID on the last close().
This appears to be done due to the limited number of FIDs available.
The problem is that the vnode might still be referenced and used by mapped
memory (mmap), so smbfs_getpages and putpages will seg-fault the user
program if there is no open descriptor on the file.

For now temporarily reopen and reclose the file.  This is inefficient, but
it should work.  The whole tracking section of smbfs really needs a rewrite.

There are guarenteed to be many other issues with smbfs.

Reported-by: Rumko <rumcic@gmail.com>
19 years agoAdd missing #include
Max Okumoto [Sat, 8 Jan 2005 13:13:22 +0000 (13:13 +0000)]
Add missing #include

19 years agoConstify more functions.
Max Okumoto [Sat, 8 Jan 2005 12:38:32 +0000 (12:38 +0000)]
Constify more functions.

19 years agoDo not specify the -B option when executing the sub-make. In the BSD
Matthew Dillon [Sat, 8 Jan 2005 11:58:46 +0000 (11:58 +0000)]
Do not specify the -B option when executing the sub-make.  In the BSD
make, -B is a compatibility option to execute shell commands one per line.
In GNU make (as of vers 3.80) -B is --always-make, which forces all targets
to be made regardless of whether they are out of date or not.

Since both GNU make and our make use MAKEFLAGS to pass build flags between
invocations, -B gets propogated down the chain into the gnu make and blows
everything to itsy bitsy little pieces.

19 years agoConstify more functions.
Max Okumoto [Sat, 8 Jan 2005 11:40:46 +0000 (11:40 +0000)]
Constify more functions.

19 years agoIncrease the default TCP maximum segment size from 512 to 1460.
Jeffrey Hsu [Sat, 8 Jan 2005 09:50:17 +0000 (09:50 +0000)]
Increase the default TCP maximum segment size from 512 to 1460.
The modern consensus is that 1500 is a safe MTU to use for the Internet.

19 years agoRemove the sysctl options for altering the initial TCP congestion window size.
Jeffrey Hsu [Sat, 8 Jan 2005 09:46:17 +0000 (09:46 +0000)]
Remove the sysctl options for altering the initial TCP congestion window size.
They violate the TCP spec and don't really buy the user anything, especially
now that we have RFC3390 support for larger initial window sizes on by default.

19 years agoRemove the sysctl options for altering the initial TCP congestion window size.
Jeffrey Hsu [Sat, 8 Jan 2005 09:26:32 +0000 (09:26 +0000)]
Remove the sysctl options for altering the initial TCP congestion window size.
They violate the TCP spec and don't really buy the user anything, especially
now that we have RFC3390 support for larger initial window sizes on by default.

19 years agoFix copyright notice.
Jeffrey Hsu [Sat, 8 Jan 2005 03:27:21 +0000 (03:27 +0000)]
Fix copyright notice.

Same as FreeBSD rev 1.9 to uthread_mattr_init.c and rev 1.8 to
uthread_mattr_kind_np.c.

19 years agoWhile removing a memory leak, rev 1.32 introduced a
Matthew Dillon [Fri, 7 Jan 2005 20:30:21 +0000 (20:30 +0000)]
While removing a memory leak, rev 1.32 introduced a
free-memory-and-reuse-it-after. Correct both problems and
make rcp -r work again under /etc/malloc.conf -> AJ.

Submitted-by: Xin LI <delphij@frontfree.net>
Taken-From: FreeBSD/1.37 charnier
PR: FreeBSD:bin/54969

19 years agoCorrect two bugs that may result in incorrect CBCP response for
Matthew Dillon [Fri, 7 Jan 2005 20:19:54 +0000 (20:19 +0000)]
Correct two bugs that may result in incorrect CBCP response for
administrator specified number.

The implementation in our version transmits extra zero byte that is a
violation of the Microsoft PPP Callback Control Protocol section 3.2[1].
This can lead to incorrect behavior on certain devices, as reported
in bin/50613.

Confirmed with: cbcp.c in ppp's cvs, rev. 1.4 and 1.15 [2]

Submitted-by: Xin LI <delphij@frontfree.net>
Taken-From: FreeBSD/rev1.7
Submitted-to-FreeBSD-by: Dmitry Pryanishnikov <dmitry at atlantis.dp.ua>
PR: FreeBSD:bin/50613

19 years agoMerge of FreeBSD rev. 1.36+1.37 of ip_nat.c. Conditionalize declarations
Matthew Dillon [Fri, 7 Jan 2005 20:15:47 +0000 (20:15 +0000)]
Merge ... FreeBSD rev. 1.36+1.37 of ip_nat.c.  Conditionalize declarations
properly when LARGE_NAT is not defined.

Submitted-by: Xin LI <delphij@frontfree.net>
19 years agoChange variable name from retstr to ret. Reduce diffs between FreeBSD
Max Okumoto [Fri, 7 Jan 2005 11:46:31 +0000 (11:46 +0000)]
Change variable name from retstr to ret. Reduce diffs between FreeBSD

19 years agoCatch up to recent rtlookup() changes.
Jeffrey Hsu [Fri, 7 Jan 2005 05:42:59 +0000 (05:42 +0000)]
Catch up to recent rtlookup() changes.

Submitted by: Tim Wickberg <me@k9mach3.org>

19 years agoRaise WARNS to 6:
Chris Pressey [Fri, 7 Jan 2005 02:43:41 +0000 (02:43 +0000)]
Raise WARNS to 6:
- Constify a string variable;
- Parentheses around an assignment in a test.

And style(9):
- Remove casts to void when ignoring return values;
- Remove `register' keywords;
- Make check against '\0' explicit.

19 years agoRaise WARNS to 6:
Chris Pressey [Fri, 7 Jan 2005 02:32:50 +0000 (02:32 +0000)]
Raise WARNS to 6:
- Make an extern declaration global.

And style(9):
- Remove `register' keywords;
- Braces around multiline blocks;
- Remove casts to void when ignoring return values;
- Make tests against NULL and 0 explicit;
- Untangle a particularly convoluted conditional printf().

19 years agoAdd missing prototype that I missed with spliting up nonints.h
Max Okumoto [Thu, 6 Jan 2005 23:29:09 +0000 (23:29 +0000)]
Add missing prototype that I missed with spliting up nonints.h

19 years agoClarify/clean up code, make fewer assumptions about types:
Chris Pressey [Thu, 6 Jan 2005 22:37:46 +0000 (22:37 +0000)]
Clarify/clean up code, make fewer assumptions about types:
- Store pids/gids/uids/devs in a union instead of casting to a long;
- Don't use the nonspecific LT_GENERIC list type;
- Add a more specific LT_PPID list type for parent pids;
- Use NODEV to indicate the lack of a specified device;
- Make the makelist() function more straightforward:
  - use only one switch statement instead of two cascading ones;
  - introduce a helper function parse_pid() to parse pids;
- No functional changes.

19 years agoFix a kernel crash that occurs when the SMB protocol stack is used. The
Matthew Dillon [Thu, 6 Jan 2005 22:31:16 +0000 (22:31 +0000)]
Fix a kernel crash that occurs when the SMB protocol stack is used.  The
SMB protocol stack is still hacked to create a kernel thread with a
process structure attached to it (when we really ought to be using a pure
kernel thread... this is the only subsystem that still doesn't).  However,
the SMB code was not properly cleaning the process structure up on exit
resulting in a corrupt process a list.  A 'ps' equivalent occuring after
this situation occurs can crash the kernel.

Reported-by: Rumko <rumcic@gmail.com>
19 years agoenomem() is only used in one file, make it static.
Max Okumoto [Thu, 6 Jan 2005 21:06:25 +0000 (21:06 +0000)]
enomem() is only used in one file, make it static.

19 years agoRemoved unused routines:
Max Okumoto [Thu, 6 Jan 2005 21:04:20 +0000 (21:04 +0000)]
Removed unused routines:
Buf_GetByte()
Buf_GetBytes()
Buf_UngetByte()
Buf_UngetBytes()

19 years agoStyle(9):
Chris Pressey [Thu, 6 Jan 2005 21:00:33 +0000 (21:00 +0000)]
Style(9):
- braces around multiline blocks
- no blank line at start of function
- remove extraneous semicolon.

19 years agoNow that I understand the poorly written BSD routing code and what
Jeffrey Hsu [Thu, 6 Jan 2005 17:59:32 +0000 (17:59 +0000)]
Now that I understand the poorly written BSD routing code and what
it was trying to do, rewrite it in a clear and concise manner.

The old rtalloc1() code written by CSRG had a number of problems:
  1. it was not clear which route was being returned
  2. it was not clear what was being reported
  3. it hid the essential radix tree lookup operation inside a series of
      conditional tests and inline assignments
  4. it had multiple gotos to the inside of if statements
  5. it intermixed reporting code with the operational logic of lookup
      and cloning
  6. it assigns multiple times to key variables
  7. it has unnecessary assignments to key variables
  8. it overloaded the "report" argument parameter, to have two
      different semantics
  9. it misnamed the key route lookup function "rtalloc1", obscuring all uses
      of route lookup.

In contrast to the rtalloc1 code in FreeBSD 4 or the even more convoluted
rtalloc1 code in FreeBSD 5, the DragonFlyBSD version
  A. has a clear control flow that makes the common case obvious
      by highlighting the core call to the radix tree look up function,
      eliminating gotos into if statements,
      and completely separating out the special-case cloning logic
  B. makes it clear which route is being returned
      by only assigning once to the key "rt" variable
      and by expliciting returning "rt" or "clonedroute"
  C. abstracts out the reporting code into its own reporting API
  D. cleans up the semantics of the "report" argument parameter to
      only indicate whether to report a miss and not whether to clone
  E. introduces a simple single-argument API for caller that want to clone
      and those that do not.

19 years agoFix compile error.
Jeffrey Hsu [Thu, 6 Jan 2005 17:54:35 +0000 (17:54 +0000)]
Fix compile error.

19 years agoMove a global variable into local scope for MP safety.
Jeffrey Hsu [Thu, 6 Jan 2005 17:38:26 +0000 (17:38 +0000)]
Move a global variable into local scope for MP safety.