From 07e80f3b8a2db4239a07f7bffd71f2c92c0f35b5 Mon Sep 17 00:00:00 2001 From: "Liam J. Foy" Date: Sat, 5 Mar 2005 19:41:38 +0000 Subject: [PATCH] - Remove unnecessary header - Remove unnecessary cast - Style(9) - Do not implicitly treat NUL characters, NULL pointers, or 0-valued integers as false-valued booleans; use explicit tests instead. (Missed from previous commit) --- bin/kill/kill.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/bin/kill/kill.c b/bin/kill/kill.c index a6049f7749..de40ec74e9 100644 --- a/bin/kill/kill.c +++ b/bin/kill/kill.c @@ -33,27 +33,26 @@ * @(#) Copyright (c) 1988, 1993, 1994 The Regents of the University of California. All rights reserved. * @(#)kill.c 8.4 (Berkeley) 4/28/95 * $FreeBSD: src/bin/kill/kill.c,v 1.11.2.2 2002/07/28 10:19:57 tjr Exp $ - * $DragonFly: src/bin/kill/kill.c,v 1.6 2004/11/11 21:16:46 cpressey Exp $ + * $DragonFly: src/bin/kill/kill.c,v 1.7 2005/03/05 19:41:38 liamfoy Exp $ */ #include #include -#include #include #include #include #include -static void nosig(const char *); -static void printsignals(FILE *); -static int signame_to_signum(const char *); -static void usage(void); +static void nosig(const char *); +static void printsignals(FILE *); +static int signame_to_signum(const char *); +static void usage(void); int main(int argc, char **argv) { int errors, numsig; - pid_t pid; + pid_t pid; char *ep; if (argc < 2) @@ -119,7 +118,7 @@ main(int argc, char **argv) for (errors = 0; argc; argc--, argv++) { pid = (pid_t)strtol(*argv, &ep, 10); - if (!**argv || *ep) { + if (**argv == '\0' || *ep != '\0') { warnx("illegal process id: %s", *argv); errors = 1; } else if (kill(pid, numsig) == -1) { @@ -136,7 +135,7 @@ signame_to_signum(const char *sig) { int n; - if (strncasecmp(sig, "sig", (size_t)3) == 0) + if (strncasecmp(sig, "sig", 3) == 0) sig += 3; for (n = 1; n < sys_nsig; n++) { if (strcasecmp(sys_signame[n], sig) == 0) -- 2.41.0