Fix compiler warnings with open_to_operation.c
authorngie <ngie@FreeBSD.org>
Fri, 30 Oct 2015 10:09:04 +0000 (10:09 +0000)
committerngie <ngie@FreeBSD.org>
Fri, 30 Oct 2015 10:09:04 +0000 (10:09 +0000)
commit0cf826b2c10c13f1d5658649a5442da68e5a614c
tree8834fee2668ed46eb0ea50fcad8bcb23604bb7fc
parentdf9dbd12ce851f3a35bbb614e3122adfb6db09c2
Fix compiler warnings with open_to_operation.c

Other sidenotes:
- Remove unused variables with main(..)
- Convert errx/exit with -1 to errx/exit with 1
- Fix a bogus test in try_directory_open
  (expected_errno == expected_errno -> errno == expected_errno) [*]
- Fix some warnings related to discarded qualifiers
- Remove a bogus else-statement at the end of check_mmap_exec(..) in the
  successful case. mmap(2), POSIX, Linux, etc all don't state what the
  behavior is when mixing O_WRONLY + PROT_EXEC, so assume success for now to
  get the test program to pass again.

PR: 201286 [*]
MFC after: 1 week
Submitted by: David Binderman <dcb314@hotmail.com>
Sponsored by: EMC / Isilon Storage Division
tools/regression/security/open_to_operation/Makefile
tools/regression/security/open_to_operation/open_to_operation.c