rmlock: Add a required compiler membar to the rlock slow path
authorMark Johnston <markj@FreeBSD.org>
Wed, 24 Feb 2021 02:15:50 +0000 (21:15 -0500)
committerMark Johnston <markj@FreeBSD.org>
Wed, 24 Feb 2021 02:17:12 +0000 (21:17 -0500)
commit1d44514fcd68809cfd493a7352ace29ddad443d6
treea01c4ace8173624b4eb85a9590e535cec793b984
parent6ab923cbca8759503a08683a5978b9ebf5efd607
rmlock: Add a required compiler membar to the rlock slow path

The tracker flags need to be loaded only after the tracker is removed
from its per-CPU queue.  Otherwise, readers may fail to synchronize with
pending writers attempting to propagate priority to active readers, and
readers and writers deadlock on each other.  This was observed in a
stable/12-based armv7 kernel where the compiler had reordered the load
of rmp_flags to before the stores updating the queue.

Reviewed by: rlibby, scottl
Discussed with: kib
Sponsored by: Rubicon Communications, LLC ("Netgate")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D28821
sys/kern/kern_rmlock.c