heimdal: asn1: Use unsigned bitfields for named bitsets
authorDimitry Andric <dim@FreeBSD.org>
Wed, 17 Apr 2024 17:49:30 +0000 (19:49 +0200)
committerDimitry Andric <dim@FreeBSD.org>
Wed, 17 Apr 2024 17:49:30 +0000 (19:49 +0200)
commit219b6e442308d5353b2af5f0771ce9b887b70754
treece69511dba510719655fb4a4bc6d20dc35d12d1d
parent1b7487592987c91020063a311a14dc15b6e58075
heimdal: asn1: Use unsigned bitfields for named bitsets

Import upstream 6747e1628:

  asn1: Use unsigned bitfields for named bitsets

  Signed 1-bit bitfields are undefined in C.

This should fix the following warnings, which for unknown reasons are
errors in CI:

  /usr/src/crypto/heimdal/lib/hx509/ca.c:1020:22: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
   1020 |         ku.digitalSignature = 1;
        |                             ^ ~
  /usr/src/crypto/heimdal/lib/hx509/ca.c:1021:21: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
   1021 |         ku.keyEncipherment = 1;
        |                            ^ ~
  /usr/src/crypto/heimdal/lib/hx509/ca.c:1028:17: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
   1028 |         ku.keyCertSign = 1;
        |                        ^ ~
  /usr/src/crypto/heimdal/lib/hx509/ca.c:1029:13: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
   1029 |         ku.cRLSign = 1;
        |                    ^ ~

PR: 276960
Fixes: 1b7487592987
MFC after: 1 week
crypto/heimdal/lib/asn1/gen.c