ZTS: normalize on use of `sync_pool` and `sync_all_pools`
authorAllan Jude <allan@klarasystems.com>
Thu, 6 Jan 2022 18:57:09 +0000 (13:57 -0500)
committerGitHub <noreply@github.com>
Thu, 6 Jan 2022 18:57:09 +0000 (10:57 -0800)
commit7454275a533e260e717a478a36af54d39beddecc
tree5fd31a123f013c82270fa1f323fbc6f9436ebc84
parent6b2e32019ec34d0c4e79397fe16b97c877ad8abc
ZTS: normalize on use of `sync_pool` and `sync_all_pools`

- Replaces use of manual `zpool sync`
- Don't use `log_must sync_pool` as `sync_pool` uses it internally
- Replace many (but not all) uses of `sync` with `sync_pool`

This makes the tests more consistent, and makes searching easier.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #12894
95 files changed:
tests/zfs-tests/include/blkdev.shlib
tests/zfs-tests/include/libtest.shlib
tests/zfs-tests/tests/functional/alloc_class/alloc_class_012_pos.ksh
tests/zfs-tests/tests/functional/alloc_class/alloc_class_013_pos.ksh
tests/zfs-tests/tests/functional/arc/dbufstats_001_pos.ksh
tests/zfs-tests/tests/functional/arc/dbufstats_002_pos.ksh
tests/zfs-tests/tests/functional/channel_program/synctask_core/tst.get_written.ksh
tests/zfs-tests/tests/functional/cli_root/zdb/zdb_block_size_histogram.ksh
tests/zfs-tests/tests/functional/cli_root/zdb/zdb_object_range_neg.ksh
tests/zfs-tests/tests/functional/cli_root/zdb/zdb_object_range_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zdb/zdb_recover.ksh
tests/zfs-tests/tests/functional/cli_root/zdb/zdb_recover_2.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_copies/zfs_copies_002_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_clone_livelist_condense_and_disable.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_clone_livelist_condense_races.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_clone_livelist_dedup.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_destroy_clone_livelist.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_destroy_common.kshlib
tests/zfs-tests/tests/functional/cli_root/zfs_destroy/zfs_destroy_dev_removal_condense.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_mount/zfs_mount_remount.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_004_neg.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_011_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_rollback/zfs_rollback_common.kshlib
tests/zfs-tests/tests/functional/cli_root/zfs_send/zfs_send_007_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool/zpool_colors.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_clear/zpool_clear_001_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_events/zpool_events_clear_retained.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_events/zpool_events_duplicates.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_events/zpool_events_errors.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_initialize/zpool_initialize_verify_checksums.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_labelclear/zpool_labelclear_removed.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_online/zpool_online_001_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_reopen/zpool_reopen_001_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_reopen/zpool_reopen_002_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_reopen/zpool_reopen_003_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_reopen/zpool_reopen_004_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_reopen/zpool_reopen_005_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_resilver/zpool_resilver_restart.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_scrub/zpool_scrub_002_pos.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_scrub/zpool_scrub_multiple_copies.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_resilver.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_trim/zpool_trim_partial.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_trim/zpool_trim_verify_checksums.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_wait/scan/zpool_wait_replace_cancel.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_wait/zpool_wait_freeing.ksh
tests/zfs-tests/tests/functional/deadman/deadman_sync.ksh
tests/zfs-tests/tests/functional/deadman/deadman_zio.ksh
tests/zfs-tests/tests/functional/delegate/delegate_common.kshlib
tests/zfs-tests/tests/functional/events/events_common.kshlib
tests/zfs-tests/tests/functional/fault/auto_offline_001_pos.ksh
tests/zfs-tests/tests/functional/fault/decompress_fault.ksh
tests/zfs-tests/tests/functional/fault/zpool_status_-s.ksh
tests/zfs-tests/tests/functional/features/async_destroy/async_destroy_001_pos.ksh
tests/zfs-tests/tests/functional/log_spacemap/log_spacemap_import_logs.ksh
tests/zfs-tests/tests/functional/mmp/mmp_reset_interval.ksh
tests/zfs-tests/tests/functional/no_space/enospc_002_pos.ksh
tests/zfs-tests/tests/functional/online_offline/online_offline_001_pos.ksh
tests/zfs-tests/tests/functional/online_offline/online_offline_002_neg.ksh
tests/zfs-tests/tests/functional/online_offline/online_offline_003_neg.ksh
tests/zfs-tests/tests/functional/procfs/procfs_list_basic.ksh
tests/zfs-tests/tests/functional/procfs/procfs_list_concurrent_readers.ksh
tests/zfs-tests/tests/functional/procfs/procfs_list_stale_read.ksh
tests/zfs-tests/tests/functional/projectquota/projectquota_006_pos.ksh
tests/zfs-tests/tests/functional/projectquota/projectquota_common.kshlib
tests/zfs-tests/tests/functional/projectquota/projectspace_001_pos.ksh
tests/zfs-tests/tests/functional/projectquota/projectspace_002_pos.ksh
tests/zfs-tests/tests/functional/refquota/refquota_007_neg.ksh
tests/zfs-tests/tests/functional/removal/removal.kshlib
tests/zfs-tests/tests/functional/removal/remove_expanded.ksh
tests/zfs-tests/tests/functional/replacement/rebuild_multiple.ksh
tests/zfs-tests/tests/functional/replacement/resilver_restart_001.ksh
tests/zfs-tests/tests/functional/replacement/resilver_restart_002.ksh
tests/zfs-tests/tests/functional/replacement/scrub_cancel.ksh
tests/zfs-tests/tests/functional/rsend/send-wR_encrypted_zvol.ksh
tests/zfs-tests/tests/functional/rsend/send_encrypted_files.ksh
tests/zfs-tests/tests/functional/rsend/send_encrypted_truncated_files.ksh
tests/zfs-tests/tests/functional/slog/slog_014_pos.ksh
tests/zfs-tests/tests/functional/slog/slog_replay_volume.ksh
tests/zfs-tests/tests/functional/snapshot/rollback_001_pos.ksh
tests/zfs-tests/tests/functional/snapshot/rollback_003_pos.ksh
tests/zfs-tests/tests/functional/trim/autotrim_integrity.ksh
tests/zfs-tests/tests/functional/trim/autotrim_trim_integrity.ksh
tests/zfs-tests/tests/functional/trim/trim.kshlib
tests/zfs-tests/tests/functional/trim/trim_integrity.ksh
tests/zfs-tests/tests/functional/truncate/truncate_002_pos.ksh
tests/zfs-tests/tests/functional/userquota/groupspace_001_pos.ksh
tests/zfs-tests/tests/functional/userquota/groupspace_002_pos.ksh
tests/zfs-tests/tests/functional/userquota/groupspace_003_pos.ksh
tests/zfs-tests/tests/functional/userquota/userquota_007_pos.ksh
tests/zfs-tests/tests/functional/userquota/userquota_common.kshlib
tests/zfs-tests/tests/functional/userquota/userspace_001_pos.ksh
tests/zfs-tests/tests/functional/userquota/userspace_002_pos.ksh
tests/zfs-tests/tests/functional/userquota/userspace_003_pos.ksh
tests/zfs-tests/tests/functional/vdev_zaps/vdev_zaps_005_pos.ksh
tests/zfs-tests/tests/functional/zvol/zvol_misc/zvol_misc_002_pos.ksh