Cy Schubert [Tue, 27 Oct 2020 23:03:15 +0000 (23:03 +0000)]
MFV r367082:
Update unbound 1.11.0 --> 1.12.0.
MFC after: 1 month.
Vincenzo Maffione [Tue, 27 Oct 2020 21:53:33 +0000 (21:53 +0000)]
iflib: add per-tx-queue netmap timer
The way netmap TX is handled in iflib when TX interrupts are not
used (IFC_NETMAP_TX_IRQ not set) has some issues:
- The netmap_tx_irq() function gets called by iflib_timer(), which
gets scheduled with tick granularity (hz). This is not frequent
enough for 10Gbps NICs and beyond (e.g., ixgbe or ixl). The end
result is that the transmitting netmap application is not woken
up fast enough to saturate the link with small packets.
- The iflib_timer() functions also calls isc_txd_credits_update()
to ask for more TX completion updates. However, this violates
the netmap requirement that only txsync can access the TX queue
for datapath operations. Only netmap_tx_irq() may be called out
of the txsync context.
This change introduces per-tx-queue netmap timers, using microsecond
granularity to ensure that netmap_tx_irq() can be called often enough
to allow for maximum packet rate. The timer routine simply calls
netmap_tx_irq() to wake up the netmap application. The latter will
wake up and call txsync to collect TX completion updates.
This change brings back line rate speed with small packets for ixgbe.
For the time being, timer expiration is hardcoded to 90 microseconds,
in order to avoid introducing a new sysctl.
We may eventually implement an adaptive expiration period or use another
deferred work mechanism in place of timers.
Also, fix the timers usage to make sure that each queue is serviced
by a different CPU.
PR: 248652
Reported by: sg@efficientip.com
MFC after: 2 weeks
Gordon Bergling [Tue, 27 Oct 2020 18:30:43 +0000 (18:30 +0000)]
Use my FreeBSD.org mail address in man pages I have written
MFC after: 3 days
Mateusz Guzik [Tue, 27 Oct 2020 18:13:09 +0000 (18:13 +0000)]
vfs: tidy up vnlru_free
Apart from cosmeatic changes make sure to only decrease the recycled counter
if vtryrecycle succeeded.
Tested by: pho
Mateusz Guzik [Tue, 27 Oct 2020 18:12:07 +0000 (18:12 +0000)]
vfs: fix vnode reclaim races against getnwevnode
All vnodes allocated by UMA are present on the global list used by
vnlru. getnewvnode modifies the state of the vnode (most notably
altering v_holdcnt) but never locks it. Moreover filesystems also
modify it in arbitrary manners sometimes before taking the vnode
lock or adding any other indicator that the vnode can be used.
Picking up such a vnode by vnlru would be problematic.
To that end there are 2 fixes:
- vlrureclaim, not recycling v_holdcnt == 0 vnodes, takes the
interlock and verifies that v_mount has been set. It is an
invariant that the vnode lock is held by that point, providing
the necessary serialisation against locking after vhold.
- vnlru_free_locked, only wanting to free v_holdcnt == 0 vnodes,
now makes sure to only transition the count 0->1 and newly allocated
vnodes start with v_holdcnt == VHOLD_NO_SMR. getnewvnode will only
transition VHOLD_NO_SMR->1 once more making the hold fail
Tested by: pho
Mateusz Guzik [Tue, 27 Oct 2020 18:11:11 +0000 (18:11 +0000)]
refcount: make it atomic-clean
While here consistently use 'old' in all places.
Tested by: pho
Alan Cox [Tue, 27 Oct 2020 18:08:33 +0000 (18:08 +0000)]
Revise the description of MAP_STACK. In particular, describe the guard
in more detail.
Reviewed by: bcr, kib, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D26908
Ruslan Bukin [Tue, 27 Oct 2020 15:29:53 +0000 (15:29 +0000)]
o Add the domain member to the struct bus_dma_tag_common as required by
busdma_iommu.c.
o Add tag_set_domain() pointer to the struct bus_dma_impl as well.
Sponsored by: Innovate DSbD
Ruslan Bukin [Tue, 27 Oct 2020 15:18:10 +0000 (15:18 +0000)]
Take the ITS device lock around gicv3_its_release_irqsrc() since that
function checks that the mutex lock is owned.
This fixes 'devctl disable re0' operation.
Sponsored by: Innovate DSbD
Differential Revision: https://reviews.freebsd.org/D26904
Cy Schubert [Tue, 27 Oct 2020 15:09:16 +0000 (15:09 +0000)]
Vendor import of Unbound 1.12.0.
Mark Johnston [Tue, 27 Oct 2020 13:27:47 +0000 (13:27 +0000)]
arm64: Remove a racy KASSERT from pmap_remove_pages()
PCPU_GET(curpmap) expands to multiple instructions on arm64, and if the
current thread is migrated in between execution of those instructions, a
stale value may be used in the assertion condition.
Diagnosed by: mmel
Reported by: mmel, Bob Prohaska <fbsd@www.zefox.net>
Submitted by: alc
MFC after: 1 week
Edward Tomasz Napierala [Tue, 27 Oct 2020 12:49:40 +0000 (12:49 +0000)]
Fix misnomer - linux_to_bsd_errno() does the exact opposite.
Reported by: arichardson
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D26965
Kristof Provost [Tue, 27 Oct 2020 12:44:49 +0000 (12:44 +0000)]
riscv: Minor cleanup in startup code
- remove setting of register value which is not used until the next value is
set
- Use the L2_SHIFT constant when setting up L2 superpages
Submitted by: Antonin Houska <ah AT melesmeles DOT cz>
Fernando Apesteguía [Tue, 27 Oct 2020 12:32:17 +0000 (12:32 +0000)]
renice(8): Clarify "who" parameters.
There was a question raised in freebsd-questions@ mail list[1] about the
"who" parameters in this man page. It seems OpenBSD[2] amd NetBSD[3]
both have more legible descriptions so I borrowed some of their ideas to try
and make this page clearer.
[1] https://lists.freebsd.org/pipermail/freebsd-questions/2020-October/291914.html
[2] https://man.bsd.lv/renice
[3] https://man.netbsd.org/renice.8
Approved by: manpages (bcr@)
Differential Revision: https://reviews.freebsd.org/D26950
Kyle Evans [Tue, 27 Oct 2020 12:27:26 +0000 (12:27 +0000)]
diff: don't force the format to 'context' with -p immediately
Instead, leave the fomat as unspecified (if it hasn't been) and use the
-p flag as a hint to 'context' if no other formatting option is specified.
This fixes `diff -purw`, used frequently by emaste, and matches the behavior
of its GNU counterpart.
PR: 250015
Reviewed by: emaste
MFC after: 1 week
Stefan Eßer [Tue, 27 Oct 2020 11:29:11 +0000 (11:29 +0000)]
Replace literal uses of /usr/local in C sources with _PATH_LOCALBASE
Literal references to /usr/local exist in a large number of files in
the FreeBSD base system. Many are in contributed software, in configuration
files, or in the documentation, but 19 uses have been identified in C
source files or headers outside the contrib and sys/contrib directories.
This commit makes it possible to set _PATH_LOCALBASE in paths.h to use
a different prefix for locally installed software.
In order to avoid changes to openssh source files, LOCALBASE is passed to
the build via Makefiles under src/secure. While _PATH_LOCALBASE could have
been used here, there is precedent in the construction of the path used to
a xauth program which depends on the LOCALBASE value passed on the compiler
command line to select a non-default directory.
This could be changed in a later commit to make the openssh build
consistently use _PATH_LOCALBASE. It is considered out-of-scope for this
commit.
Reviewed by: imp
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D26942
Mateusz Piotrowski [Tue, 27 Oct 2020 09:53:49 +0000 (09:53 +0000)]
Do not recommend to install kyua with pkg in the tests README
Kyua is now available in the base system.
While here, reword the usage section a bit.
Mateusz Piotrowski [Tue, 27 Oct 2020 09:41:01 +0000 (09:41 +0000)]
Clean up backlight.8
- Sort flags
- Stylize incr|+ and decr|- properly
- Add a missing period at the end of the description
- Use the standard layout for the EXAMPLES section (remove the list macro
and add indentation to the code block)
Mateusz Piotrowski [Tue, 27 Oct 2020 09:32:06 +0000 (09:32 +0000)]
Mount devfs inside a beinstall(8) chroot
It turns out that without /dev/null beinstall is not able to complete and
instead exits with messages similar to these:
--------------------------------------------------------------
>>> Installing kernel GENERIC completed on Sun Oct 25 17:47:37 CET 2020
--------------------------------------------------------------
/tmp/beinstall.JleGoP/mnt: Inspecting dirs /usr/src /usr/obj/usr/src/amd64.amd64
--- installworld ---
make[1]: "/usr/obj/usr/src/amd64.amd64/toolchain-metadata.mk" line 1: Using cached toolchain metadata from build at t480 on Sun Oct 25 15:53:28 CET 2020
make[2]: "/dev/null" line 2: Need an operator
make[2]: Fatal errors encountered -- cannot continuemake[1]: "/usr/src/Makefile.inc1" line 593: CPUTYPE global should be set with ?=.
Cleaning up ...
umount -f /tmp/beinstall.JleGoP/mnt/usr/src /tmp/beinstall.JleGoP/mnt/usr/obj/usr/src/amd64.amd64 /tmp/beinstall.JleGoP/mnt
Destroyed successfully
error: Installworld failed!
Upon a bit of debugging, it turns out that /dev/null inside the chroot
environment is full random bytes, which cause "make -f /dev/null" to
misbehave. Mounting a proper devfs inside the chroot seems to be the most
appropriate way to fix it.
will@ also noted that this change requires that whatever is needed in devfs
must exist in the old kernel.
Approved by: will
MFC after: 2 week
Differential Revision: https://reviews.freebsd.org/D26944
Warner Losh [Tue, 27 Oct 2020 06:43:24 +0000 (06:43 +0000)]
Remove frontstuff
Nothing implements this in the tree. Remove the ioctl and the
conversion to the geom atttribute stuff.
This was introduced in r94287 in 2002 and was retired in r113390
2003. It appeared in FreeBSD 5.0, but no other releases. This is a
vestige that was missed at the time and overlooked until now. No
compat is provided for this reason. And there's no implementation of
it today. And it was never part of a release from a stable branch.
Reviewed by: phk@
Differential Revision: https://reviews.freebsd.org/D26967
Cy Schubert [Tue, 27 Oct 2020 04:35:47 +0000 (04:35 +0000)]
Remove a random equal sign from the example. It should not be there.
It's a syntax error.
PR: 210303
Reported by: leventelist at gmail.com
MFC after: 3 days
Cy Schubert [Tue, 27 Oct 2020 04:35:36 +0000 (04:35 +0000)]
Continued ipfilter #ifdef cleanup. The r343701 log entry contains a
complete description.
MFC after: 3 days
Mitchell Horne [Mon, 26 Oct 2020 19:13:22 +0000 (19:13 +0000)]
riscv: make use of SBI legacy replacement extensions
Version 0.2 of the SBI specification [1] marked the existing SBI
functions as "legacy" in order to move to a newer calling convention. It
also introduced a set of replacement extensions for some of the legacy
functionality. In particular, the TIME, IPI, and RFENCE extensions
implement and extend the semantics of their legacy counterparts, while
conforming to the newer version of the spec.
Update our SBI code to use the new replacement extensions when
available, and fall back to the legacy ones. These will eventually be
dropped, when support for version 0.2 is ubiquitous.
[1] https://github.com/riscv/riscv-sbi-doc/blob/master/riscv-sbi.adoc
Submitted by: Danjel Q. <danq1222@gmail.com>
Reviewed by: kp
Differential Revision: https://reviews.freebsd.org/D26953
Mitchell Horne [Mon, 26 Oct 2020 19:06:30 +0000 (19:06 +0000)]
riscv: remove sbi_clear_ipi()
S-mode software has write access to the SIP.SSIP bit, so instead of
making a second round-trip through the SBI we can clear it ourselves.
The SBI spec has deprecated this function for this exactly this reason.
Submitted by: Danjel Q. <danq1222@gmail.com
Reviewed by: kp
Differential Revision: https://reviews.freebsd.org/D26952
Mateusz Guzik [Mon, 26 Oct 2020 18:03:50 +0000 (18:03 +0000)]
linux: silence renameat2 flags warning
Hogs the console while building the Linux kernel in a Ubuntu Focal jail.
Mateusz Guzik [Mon, 26 Oct 2020 18:02:52 +0000 (18:02 +0000)]
linux: add missing conversions for compat.linux.use_emul_path handling
Mateusz Guzik [Mon, 26 Oct 2020 18:01:18 +0000 (18:01 +0000)]
cache: add missing NIRES_ABS handling
Brooks Davis [Mon, 26 Oct 2020 17:52:28 +0000 (17:52 +0000)]
Key decleration of union semun on src version
__FreeBSD__ is defined by the compiler derived from the triple. When
building FreeBSD 11 on a FreeBSD 12 with a CROSS_TOOLCHAIN=llvm10,
__FreeBSD__ was set to 12 when building lib32 (for some reason no triple
is being passed which seems to mean that we're taking default values
from the build system). This in turn meant we end up with a double
decleration of union semun which is a build error.
Reviewed by: gshapiro, dim
Differential Revision: https://reviews.freebsd.org/D26902
Kyle Evans [Mon, 26 Oct 2020 17:30:17 +0000 (17:30 +0000)]
audit: also correctly audit linux_execve()
Linux execve() gets audited as AUE_EXECVE as well, we should also interpret
the return from this correctly for the same reasoning as in r367002.
MFC with: r367002
Eric van Gyzen [Mon, 26 Oct 2020 16:42:53 +0000 (16:42 +0000)]
db_search_symbol: prevent pollution from bogus symbols
The kernel will never map the first page, so any symbols in that
range cannot refer to addresses. Some third-party assembly files
define internal constants which appear in their symbol table.
Avoiding the lookup for those symbols avoids replacing small offsets
with those symbols during disassembly.
Reported by: Anton Rang <rang%acm.org>
Reviewed by: Anton Rang <rang%acm.org>, markj
MFC after: 2 weeks
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D26895
Mateusz Guzik [Mon, 26 Oct 2020 08:17:41 +0000 (08:17 +0000)]
zfs: remove unused support for zfs_znode_move
Scott Long [Mon, 26 Oct 2020 05:22:52 +0000 (05:22 +0000)]
Correct calendar entry for myself
Alexander Motin [Mon, 26 Oct 2020 04:04:06 +0000 (04:04 +0000)]
Enable bioq 'car limit' added at r335066 at 128 bios.
Without the 'car limit' enabled (before this), running sequential ZFS scrub
on HDD without command queuing support, I've measured latency on concurrent
random reads reaching 4 seconds (surprised that not more). Enabling this
reduced the latency to 65 milliseconds, while scrub still doing ~180MB/s.
For disks with command queuing this does not make much difference (if any),
since most time all the requests are queued down to the disk or HBA, leaving
nothing in the queue to sort. And even if something does not fit, staying on
the queue, it is likely not for long. To not limit sorting in such bursty
scenarios I've added batched counter zeroing when the queue is getting empty.
The internal scheduler of the SAS HDD I was testing seems to be even more
loyal to random I/O, reducing the scrub speed to ~120MB/s. So in case
somebody worried this is limit is too strict -- it actually looks relaxed.
MFC after: 2 weeks
Sponsored by: iXsystems, Inc.
Warner Losh [Mon, 26 Oct 2020 03:26:18 +0000 (03:26 +0000)]
calendar: remove all datafiles except freebsd one
Move all the data files for the calendar(1) program, except
calendar.freebsd to the calendar-data package. When a file
can't be found, and /usr/local/share/calendar doesn't exist
provide a helpful hint to install this package.
Reviewed by: se@
Differential Revision: https://reviews.freebsd.org/D26926
John-Mark Gurney [Mon, 26 Oct 2020 00:37:31 +0000 (00:37 +0000)]
update write(2)'s iovec limit w/ info about the iosize_max_clamp sysctl...
Kirk McKusick [Sun, 25 Oct 2020 21:04:07 +0000 (21:04 +0000)]
Use proper type (ino_t) for inode numbers to avoid improper sign extention
in the Pass 5 checks. The manifestation was fsck_ffs exiting with this error:
** Phase 5 - Check Cyl groups
fsck_ffs: inoinfo: inumber
18446744071562087424 out of range
The error only manifests itself for filesystems bigger than about 100Tb.
Reported by: Nikita Grechikhin <ngrechikhin at yandex.ru>
MFC after: 2 weeks
Sponsored by: Netflix
Alexander Motin [Sun, 25 Oct 2020 19:34:02 +0000 (19:34 +0000)]
Introduce support of SCSI Command Priority.
SAM-3 specification introduced concept of Task Priority, that was renamed
to Command Priority in SAM-4, and supported by all modern SCSI transports.
It provides 15 levels of relative priorities: 1 - highest, 15 - lowest and
0 - default. SAT specification for SATA devices translates priorities 1-3
into NCQ high priority.
This change adds new "priority" field into empty spots of struct ccb_scsiio
and struct ccb_accept_tio of CAM and struct ctl_scsiio of CTL. Respective
support is added into iscsi(4), isp(4), mpr(4), mps(4) and ocs_fc(4) drivers
for both initiator and where applicable target roles. Minimal support was
added to CTL to receive the priority value from different frontends, pass it
between HA controllers and report in few places.
This patch does not add consumers of this functionality, so nothing should
really change yet, since the field is still set to 0 (default) on initiator
and not actively used on target. Those are to be implemented separately.
I've confirmed priority working on WD Red SATA disks connected via mpr(4)
and properly transferred to CTL target via iscsi(4), isp(4) and ocs_fc(4).
While there, added missing tag_action support to ocs_fc(4) initiator role.
MFC after: 1 month
Relnotes: yes
Sponsored by: iXsystems, Inc.
Ed Maste [Sun, 25 Oct 2020 18:27:21 +0000 (18:27 +0000)]
rc.d/syscons: remove spaces before tab
Ed Maste [Sun, 25 Oct 2020 18:06:45 +0000 (18:06 +0000)]
mergemaster: Clarify installed and updated versions
Describe "diff installed new" as "Displaying differences between
installed and new." Previously mergemaster described them in the
opposite order.
PR: 249214
Reported by: Yuri Victorovich
MFC after: 2 weeks
Alexander Motin [Sun, 25 Oct 2020 16:58:48 +0000 (16:58 +0000)]
Fix incorrect constants of target tag action.
ocs_scsi_recv_cmd() receives the flags after ocs_get_flags_fcp_cmd(),
which translates them from FCP_TASK_ATTR_* to OCS_SCSI_CMD_*. As result
non-SIMPLE requests turned into HEAD or ORDERED depending on direction.
MFC after: 2 weeks
Mateusz Piotrowski [Sun, 25 Oct 2020 16:01:03 +0000 (16:01 +0000)]
calendar.1: Fix locale of the month in Dd ;)
Mateusz Piotrowski [Sun, 25 Oct 2020 15:01:01 +0000 (15:01 +0000)]
ifconfig.8: Remove spurious commas
Correct misuse of commas/parentheses in an enumeration that makes the
number of actual parameters more important than expected.
PR: 250526
Submitted by: Samy Mahmoudi <samy.mahmoudi__gmail_com>
MFC after: 1 week
Edward Tomasz Napierala [Sun, 25 Oct 2020 14:09:00 +0000 (14:09 +0000)]
Remove the check that prevents creating "loops" from mount_nullfs(8).
Reviewed by: kib
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D26921
Ruslan Bukin [Sun, 25 Oct 2020 10:08:46 +0000 (10:08 +0000)]
Add IOMMU support to GICv3 Interrupt Translation Service (ITS) driver.
Submitted by: andrew
Sponsored by: Innovate DSbD
Differential Revision: https://reviews.freebsd.org/D26878
Kirk McKusick [Sun, 25 Oct 2020 01:36:33 +0000 (01:36 +0000)]
Filesystem utilities that modify the filesystem (growfs(8), tunefs(8),
and fsirand(8)) should check the filesystem status and require that
fsck(8) be run if it is unclean. This requirement is not imposed on
fsdb(8) or clri(8) since they may be used to clean up a filesystem.
MFC after: 2 weeks
Sponsored by: Netflix
Kirk McKusick [Sun, 25 Oct 2020 00:43:48 +0000 (00:43 +0000)]
Various new check-hash checks have been added to the UFS filesystem
over various major releases. Superblock check hashes were added for
the 12 release and cylinder-group and inode check hashes will appear
in the 13 release.
When a disk with a UFS filesystem is writably mounted, the kernel
clears the feature flags for anything that it does not support. For
example, if a UFS disk from a 12-stable kernel is mounted on an
11-stable system, the 11-stable kernel will clear the flag in the
filesystem superblock that indicates that superblock check-hashs
are being maintained. Thus if the disk is later moved back to a
12-stable system, the 12-stable system will know to ignore its
incorrect check-hash.
If the only filesystem modification done on the earlier kernel is
to run a utility such as growfs(8) that modifies the superblock but
neither updates the check-hash nor clears the feature flag indicating
that it does not support the check-hash, the disk will fail to mount
if it is moved back to its original newer kernel.
This patch moves the code that clears the filesystem feature flags
from the mount code (ffs_mountfs()) to the code that reads the
superblock (ffs_sbget()). As ffs_sbget() is used by the kernel mount
code and is imported into libufs(3), all the filesystem utilities
will now also clear these flags when they make modifications to the
filesystem.
As suggested by John Baldwin, fsck_ffs(8) has been changed to accept
and repair bad superblock check-hashes rather than refusing to run.
This change allows fsck to recover filesystems that have been impacted
by utilities older than those created after this change and is a
sensible thing to do in any event.
Reported by: John Baldwin (jhb@)
MFC after: 2 weeks
Sponsored by: Netflix
Mitchell Horne [Sat, 24 Oct 2020 23:21:51 +0000 (23:21 +0000)]
Fix build after r367020
DTrace also relies on these definitions.
Reported by: jenkins
Warner Losh [Sat, 24 Oct 2020 23:21:31 +0000 (23:21 +0000)]
cdefs.h: remove intel_compiler support
The age of the intel compiler support is so old as to be
uninteresting. No recent recports of intel compiler support have been
received. Remove all the special case workarounds for the Intel
compiler. Should there be interest in supporting the compiler, contact
me and I'll work with people to make it happen, though I suspect these
instances are more likely to be in the way than to be helpful.
Reviewed by: cem, emaste, vangyzen, dim
Differential Revision: https://reviews.freebsd.org/D26817
Warner Losh [Sat, 24 Oct 2020 23:21:27 +0000 (23:21 +0000)]
Remove support for intel compiler from i386 in_cksum
We no longer support building the kernel with the old intel
compiler. Remove support for it from in_cksum. Should there be
interest in reviving it, this is as likely to get in the way as to
help anyway.
Warner Losh [Sat, 24 Oct 2020 23:21:22 +0000 (23:21 +0000)]
Remove intel compiler support from math.h
The intel compiler support has badly decayed over the years. Stop
pretending that we support it. Note, I've stopped short of requiring
gcc builtin support with this commit since other compilers may be used
to build non-base software and we need to support those so more
investigation is needed before simplifying further.
Warner Losh [Sat, 24 Oct 2020 23:21:18 +0000 (23:21 +0000)]
Remove support for ancient compilers
We don't support building the kernel from such old compilers, nor with
the Intel Compiler specifically. Remove support for this old construct
that was copied from stdbool.h and not relevant here.
Warner Losh [Sat, 24 Oct 2020 23:21:06 +0000 (23:21 +0000)]
Remove obsolete check for GCC < 3 and support for Intel Compiler
We no longer support old versions of GCC. Remove this check by
assuming it's false. That will make the entire expression false. Also
remove support for Intel compiler, it's badly bitrotted. Technically,
this removes support for C89 and K&R from compilers that don't define
_Bool in those compilation environments as well. I'm unaware of any
working compiler today for which that would be relevant (pcc has it
and tcc sadly isn't working for other reasons), though if one
pops up in ports, I'll work to resolve the issue.
Rick Macklem [Sat, 24 Oct 2020 22:52:29 +0000 (22:52 +0000)]
Update man page for -R option added by r376026.
This is a content change.
Reviewed by: bcr
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D26746
Rick Macklem [Sat, 24 Oct 2020 22:48:28 +0000 (22:48 +0000)]
Add "-R" option to tell mountd to not register with rpcbind.
rpcbind is now considered a security risk for some sites.
Since an NFSv4 only NFS server does not need rpcbind,
it makes sense to have an option that implements this.
This patch adds a "-R" option that disables the Mount
protocol (not used by NFSv4) and does not register
with rpcbind.
Changes are required to /etc/rc.d/mountd and /etc/rc.d/nfsd.
Those will be in a separate commit.
Reviewed by: freqlabs, asomers
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D26746
Ryan Moeller [Sat, 24 Oct 2020 22:36:20 +0000 (22:36 +0000)]
sockstat: Fix error message when jail_attach fails
jail_errmsg is for libjail, jail_attach() is a system call.
Richard Scheffenegger [Sat, 24 Oct 2020 21:10:53 +0000 (21:10 +0000)]
Add network QoS support for PCP to iscsi target.
Mak the Ethernet PCP codepoint configurable
for L2 local traffic, to allow lower latency for
iSCSI block IO. This addresses the target
side only.
Reviewed by: mav, trasz, bcr
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D26740
Richard Scheffenegger [Sat, 24 Oct 2020 21:07:13 +0000 (21:07 +0000)]
Add network QoS support for PCP to iscsi initiator.
Make the Ethernet PCP codepoint configurable
for L2 local traffic, to allow lower latency for
iSCSI block IO. This addresses the initiator
side only.
Reviewed by: mav, trasz, bcr
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D26739
Alexander Motin [Sat, 24 Oct 2020 21:07:10 +0000 (21:07 +0000)]
Fix asymmetry in devstat(9) calls by GEOM.
Before this GEOM passed bio pointer to transaction start, but not end.
It was irrelevant until devstat(9) got DTrace hooks, that appeared to
provide bio pointer on I/O completion, but not on submission.
MFC after: 2 weeks
Sponsored by: iXsystems, Inc.
Richard Scheffenegger [Sat, 24 Oct 2020 21:01:18 +0000 (21:01 +0000)]
Make use of IP_VLAN_PCP setsockopt in ping and ping6.
In order to validate the proper marking and use of a different
ethernet priority class, add the new session-specific PCP
feature to the ping/ping6 utilities.
Reviewed by: mav, bcr
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D26627
Mitchell Horne [Sat, 24 Oct 2020 20:57:13 +0000 (20:57 +0000)]
riscv: improve exception code naming
The existing names were inherited from arm64, but we should prefer
RISC-V terminology. Change the prefix to SCAUSE, and further change the
names to better match the RISC-V spec and be more consistent with one
another. Also, remove two codes that are not defined for S-mode (machine
and hypervisor ecall).
While here, apply style(9) to some condition checks.
Reviewed by: kp
Discussed with: jrtc27
Differential Revision: https://reviews.freebsd.org/D26918
Ruslan Bukin [Sat, 24 Oct 2020 20:09:27 +0000 (20:09 +0000)]
o Add iommu de-initialization method for MSI interface.
o Add iommu_unmap_msi() to release the msi GAS entry.
o Provide default implementations for iommu init/deinit methods.
Reviewed by: kib
Sponsored by: Innovate DSbD
Differential Revision: https://reviews.freebsd.org/D26906
Ryan Moeller [Sat, 24 Oct 2020 17:08:59 +0000 (17:08 +0000)]
flua: Add a libjail module
libjail is pretty small, so it makes for a good proof of concept demonstrating
how a system library can be wrapped to create a loadable Lua module for flua.
* Introduce 3lua section for man pages
* Add libjail module
Reviewed by: kevans, manpages
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D26080
Fernando Apesteguía [Sat, 24 Oct 2020 16:42:35 +0000 (16:42 +0000)]
pwd(1): Add EXAMPLES section
Small EXAMPLES section.
Add reference to realpath(1) due to similarity.
Approved by: manpages (gbe@)
Differential Revision: https://reviews.freebsd.org/D26862
Fernando Apesteguía [Sat, 24 Oct 2020 16:40:34 +0000 (16:40 +0000)]
getent(1): Add EXAMPLES section
Add 3 small examples to the EXAMPLES section.
Approved by: manpages (gbe@)
Differential Revision: https://reviews.freebsd.org/D26866
Ryan Moeller [Sat, 24 Oct 2020 16:25:52 +0000 (16:25 +0000)]
Skip RAW kstat sysctls by default
hese kstats are often expensive to compute so we want to avoid them
unless specifically requested.
The following kstats are affected by this change:
kstat.zfs.${pool}.multihost
kstat.zfs.${pool}.misc.state
kstat.zfs.${pool}.txgs
kstat.zfs.misc.fletcher_4_bench
kstat.zfs.misc.vdev_raidz_bench
kstat.zfs.misc.dbufs
kstat.zfs.misc.dbgmsg
PR: 249258
Reported by: mjg
Reviewed by: mjg, allanjude
Obtained from: https://github.com/openzfs/zfs/pull/11099
Sponsored by: iXsystems, Inc.
Ryan Moeller [Sat, 24 Oct 2020 16:17:07 +0000 (16:17 +0000)]
sysctl+kern_sysctl: Honor SKIP for descendant nodes
Ensure we also skip descendants of SKIP nodes when iterating through children
of an explicitly specified node.
Reported by: np
Reviewed by: np
MFC after: 1 week
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D26833
Richard Scheffenegger [Sat, 24 Oct 2020 16:11:46 +0000 (16:11 +0000)]
TCP Cubic: improve reaction to (and rollback from) RTO
1. fix compliancy issue of CUBIC RTO handling according to RFC8312 section 4.7
2. add CUBIC CC_RTO_ERR handling
Submitted by: chengc_netapp.com
Reviewed by: rrs, tuexen, rscheff
MFC after: 2 weeks
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D26808
Richard Scheffenegger [Sat, 24 Oct 2020 16:09:18 +0000 (16:09 +0000)]
tcp: move cwnd and ssthresh updates into cc modules
This will pave the way of setting ssthresh differently in TCP CUBIC, according
to RFC8312 section 4.7.
No functional change, only code movement.
Submitted by: chengc_netapp.com
Reviewed by: rrs, tuexen, rscheff
MFC after: 2 weeks
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D26807
Ryan Moeller [Sat, 24 Oct 2020 16:05:37 +0000 (16:05 +0000)]
sysctl: Misc code cleanup
* Use defined SYS_SYSCTL names
* Use memcmp instead of explicit loop
* Use NULL instead of 0 for pointer value
* Use __FBSDID
* Reformat, improve comments in parse()
No functional changes.
Reviewed by: imp
MFC after: 1 week
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D26832
Xin LI [Sat, 24 Oct 2020 15:58:42 +0000 (15:58 +0000)]
MFV r366990: less v563.
MFC after: 2 weeks
Relnotes: yes
Kyle Evans [Sat, 24 Oct 2020 15:38:04 +0000 (15:38 +0000)]
backlight(9): compile with COMPAT_LINUXKPI as well
This would be more accurately expressed as COMPAT_LINUXKPI implying or
requiring backlight, but config(8) doesn't really have a way to express
that. This fixes the build with COMPAT_LINUXKPI specified in one's kernel
config.
Ryan Moeller [Sat, 24 Oct 2020 14:46:38 +0000 (14:46 +0000)]
kern_sysctl: Misc code cleanup
Remove unused oidpp parameter from sysctl_sysctl_next_ls and
add high level comments to describe how it works.
No functional change.
Reviewed by: imp
MFC after: 1 week
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D26854
Kyle Evans [Sat, 24 Oct 2020 14:39:17 +0000 (14:39 +0000)]
audit: correct reporting of *execve(2) success
r326145 corrected do_execve() to return EJUSTRETURN upon success so that
important registers are not clobbered. This had the side effect of tapping
out 'failures' for all *execve(2) audit records, which is less than useful
for auditing purposes.
Audit exec returns earlier, where we can know for sure that EJUSTRETURN
translates to success. Note that this unsets TDP_AUDITREC as we commit the
audit record, so the usual audit in the syscall return path will do nothing.
PR: 249179
Reported by: Eirik Oeverby <ltning-freebsd anduin net>
Reviewed by: csjp, kib
MFC after: 1 week
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D26922
Edward Tomasz Napierala [Sat, 24 Oct 2020 14:25:38 +0000 (14:25 +0000)]
Tweak linux(4) socket(2) debug messages.
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D26900
Edward Tomasz Napierala [Sat, 24 Oct 2020 14:23:44 +0000 (14:23 +0000)]
Further improve prctl(2) debug.
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D26916
Mateusz Guzik [Sat, 24 Oct 2020 13:31:40 +0000 (13:31 +0000)]
cache: assorted typo fixes
Mateusz Guzik [Sat, 24 Oct 2020 13:31:25 +0000 (13:31 +0000)]
cache: add the missing NC_NOMAKEENTRY and NC_KEEPPOSENTRY to lockless lookup
They are de facto ignored.
Mateusz Guzik [Sat, 24 Oct 2020 13:30:37 +0000 (13:30 +0000)]
vfs: fix a race where reclaim vholds freed vnodes
Reported by: pho
Tested by: pho (previous version)
Fixes: r366974 ("vfs: stop taking the interlock in vnode reclaim")
Hans Petter Selasky [Sat, 24 Oct 2020 13:16:10 +0000 (13:16 +0000)]
Implement xa_init() in the LinuxKPI as a wrapper for xa_init_flags().
MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking
Hans Petter Selasky [Sat, 24 Oct 2020 13:07:50 +0000 (13:07 +0000)]
More style fixes (partial revert of r366994).
Suggested by: danfe@
Differential Revision: https://reviews.freebsd.org/D26254
MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking
Hans Petter Selasky [Sat, 24 Oct 2020 10:52:09 +0000 (10:52 +0000)]
Fix order of header files:
sys/systm.h should come right after sys/param.h
Suggested by: kib@
Differential Revision: https://reviews.freebsd.org/D26254
MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking
Hans Petter Selasky [Sat, 24 Oct 2020 10:23:21 +0000 (10:23 +0000)]
Run code through "clang-format -style=file" with some additional fixes.
No functional change.
Suggested by: kib@ and emaste@
Differential Revision: https://reviews.freebsd.org/D26254
MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking
Alan Somers [Sat, 24 Oct 2020 05:52:29 +0000 (05:52 +0000)]
nfsstat: delete unused fields
Ever since r192762 nfsstat has included a few fields whose values were
always 0. They were copied from OpenBSD, but have never been used on
FreeBSD. Don't display them.
Reviewed by: rmacklem
Sponsored by: Axcient
Differential Revision: https://reviews.freebsd.org/D26920
Xin LI [Sat, 24 Oct 2020 05:25:54 +0000 (05:25 +0000)]
Vendor import of less v563.
Warner Losh [Sat, 24 Oct 2020 01:59:01 +0000 (01:59 +0000)]
nvme: Remove compat code for older kernels
Remove code that supported pre-2011 kernels. CTLTYPE_S64 was defined
in rev 217616. All supported branches have it, so remove its compat
definition as OBE.
Mateusz Guzik [Sat, 24 Oct 2020 01:14:52 +0000 (01:14 +0000)]
cache: batch updates to numcache in case of mass removal
Mateusz Guzik [Sat, 24 Oct 2020 01:14:17 +0000 (01:14 +0000)]
cache: refactor alloc/free
This in particular centralizes manipulation of numcache.
Mateusz Guzik [Sat, 24 Oct 2020 01:13:47 +0000 (01:13 +0000)]
cache: fold branch prediction into cache_ncp_canuse
Mateusz Guzik [Sat, 24 Oct 2020 01:13:16 +0000 (01:13 +0000)]
cache: fix some typos
Mateusz Guzik [Sat, 24 Oct 2020 01:13:02 +0000 (01:13 +0000)]
cache: drop write-only vars
Warner Losh [Sat, 24 Oct 2020 00:03:11 +0000 (00:03 +0000)]
warnx: fix needless static
I noticed after the review that these shouldn't be static. Remove the
'static' from them, otherwise concurrent calls to warn* might see a
similar but to the original.
Warner Losh [Fri, 23 Oct 2020 23:56:00 +0000 (23:56 +0000)]
warnx: Save errno across calls that might change it.
When warn() family of functions is being used after err_set_file() has
been set to, for example, /dev/null, errno is being clobbered,
rendering it unreliable after, for example, procstat_getpathname()
when it is supposed to emit a warning. Then the errno is changed to
Inappropriate ioctl for device, destroying the original value (via
calls to fprintf()functions).
Submitted by: Juraj Lutter
Differential Revision: https://reviews.freebsd.org/D26871
Brooks Davis [Fri, 23 Oct 2020 22:27:45 +0000 (22:27 +0000)]
Only use ASAN when using the in-tree compiler
When building FreeBSD 11 on a FreeBSD 12 system with
CROSS_TOOLCHAIN=llvm10 we end up trying to link against the packaged
version of the sanitizer library. This resulted in a requirement for
getentropy(3) which is not present in FreeBSD 11.
Reviewed by: emaste
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D26903
Ruslan Bukin [Fri, 23 Oct 2020 21:27:48 +0000 (21:27 +0000)]
Move the iommu stubs to a generic place, so they are available on all the
platforms.
This allows to not depend on the IOMMU macro in AHCI driver.
Requested by: kib
Suggested by: andrew
Reviewed by: kib
Sponsored by: Innovate DSbD
Differential Revision: https://reviews.freebsd.org/D26887
Konstantin Belousov [Fri, 23 Oct 2020 18:18:45 +0000 (18:18 +0000)]
xhci: Handle the case when MSI-X BAR is the same as IO BAR.
PCIe allows for MSI-X BAR to be either dedicated, or MSI-X Table may
be co-located in some functional BAR. In the later case xhci(4) is
unable to allocate active resource for the table because BAR is
already activated.
Handle it by checking for this special case, and not try to alloc
resource if MSI-X BAR is IO.
Reported and tested by: emaste
Reviewed by: emaste, hselasky
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Differential revision: https://reviews.freebsd.org/D26913
Ed Maste [Fri, 23 Oct 2020 16:35:23 +0000 (16:35 +0000)]
libelf: add compression header support
GNU and Oracle libelf implementations added support for section
compression, intended to reduce the size of DWARF debug info (which
might be an order of magnitude larger than the code).
There are two compressed ELF section formats:
1. Old GNU - sections are renmaed to start with 'z'. Section contains
a magic number, uncompressed size, and compressed data.
2. Oracle and New GNU - compressed sections use the SHF_COMPRESSED flag.
The compression header contains the compression type, uncompressed
size, and uncompressed alignment.
The second style is preferred and this change implements only that one.
Submitted by: Tiger Gao <tig@FreeBSDFoundation.org>
Reviewed by: markj
MFC after: 2 weeks
Relnotes: Yes
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D24566
Mateusz Guzik [Fri, 23 Oct 2020 15:56:22 +0000 (15:56 +0000)]
cache: reduce memory waste in struct namecache
The previous scheme for calculating the total size was doing sizeof
on the struct and then adding the wanted space for the buffer.
nc_name is at offset 58 while sizeof(struct namecache) is 64.
With CACHE_PATH_CUTOFF of 39 bytes and 1 byte of padding we were
allocating 104 bytes for the entry and never accounting for the 6
byte padding, wasting that space.
Mateusz Guzik [Fri, 23 Oct 2020 15:50:49 +0000 (15:50 +0000)]
vfs: drop spurious cache_purge on rmdir
The removed directory gets cache_purged which is sufficient to remove any entries
related to the parent.
Note only tmpfs, ufs and zfs are patched.
Mateusz Guzik [Fri, 23 Oct 2020 15:49:18 +0000 (15:49 +0000)]
vfs: stop taking the interlock in vnode reclaim
It no longer protects any of tested fields, keeping all the checks racy.
While here make vtryrecycle drop the vnode on its own. Avoids an additional
lock trip.
Mark Johnston [Fri, 23 Oct 2020 15:12:06 +0000 (15:12 +0000)]
ntb: Fix the 32-bit build after r366969
Reported by: Jenkins
MFC with: r366969