KVM: arm/arm64: vgic: Fix potential double free dist->spis in __kvm_vgic_destroy()
authorMiaohe Lin <linmiaohe@huawei.com>
Thu, 28 Nov 2019 06:38:48 +0000 (14:38 +0800)
committerMarc Zyngier <maz@kernel.org>
Fri, 6 Dec 2019 11:41:29 +0000 (11:41 +0000)
commit0bda9498dd45280e334bfe88b815ebf519602cc3
treea37aeba177df126b8cf962535fef129621e44500
parent7e0befd521b6d40af1d08fcdb29d4dbf30236624
KVM: arm/arm64: vgic: Fix potential double free dist->spis in __kvm_vgic_destroy()

In kvm_vgic_dist_init() called from kvm_vgic_map_resources(), if
dist->vgic_model is invalid, dist->spis will be freed without set
dist->spis = NULL. And in vgicv2 resources clean up path,
__kvm_vgic_destroy() will be called to free allocated resources.
And dist->spis will be freed again in clean up chain because we
forget to set dist->spis = NULL in kvm_vgic_dist_init() failed
path. So double free would happen.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/1574923128-19956-1-git-send-email-linmiaohe@huawei.com
virt/kvm/arm/vgic/vgic-init.c