nfsd: apply umask on fs without ACL support
authorJ. Bruce Fields <bfields@redhat.com>
Tue, 16 Jun 2020 20:43:18 +0000 (16:43 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 17 Jun 2020 14:48:58 +0000 (10:48 -0400)
commit22cf8419f1319ff87ec759d0ebdff4cbafaee832
tree38b086b429708ea788f7d4f0bce9d807cbba5884
parentb3a9e3b9622ae10064826dccb4f7a52bd88c7407
nfsd: apply umask on fs without ACL support

The server is failing to apply the umask when creating new objects on
filesystems without ACL support.

To reproduce this, you need to use NFSv4.2 and a client and server
recent enough to support umask, and you need to export a filesystem that
lacks ACL support (for example, ext4 with the "noacl" mount option).

Filesystems with ACL support are expected to take care of the umask
themselves (usually by calling posix_acl_create).

For filesystems without ACL support, this is up to the caller of
vfs_create(), vfs_mknod(), or vfs_mkdir().

Reported-by: Elliott Mitchell <ehem+debian@m5p.com>
Reported-by: Salvatore Bonaccorso <carnil@debian.org>
Tested-by: Salvatore Bonaccorso <carnil@debian.org>
Fixes: 47057abde515 ("nfsd: add support for the umask attribute")
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/vfs.c