dmaengine: xilinx: xdma: Fix initialization location of desc in xdma_channel_isr()
authorNathan Chancellor <nathan@kernel.org>
Fri, 22 Dec 2023 18:06:45 +0000 (11:06 -0700)
committerVinod Koul <vkoul@kernel.org>
Fri, 19 Jan 2024 11:34:02 +0000 (17:04 +0530)
commit620a7e4c1f03a84e10c8c3fa0ae1aab03ef84294
treea91fbb6f7c1850f74914c47f2d6ca2c361469e7f
parentfe0d495e759cee0dbfff4348b5791f21b6f56655
dmaengine: xilinx: xdma: Fix initialization location of desc in xdma_channel_isr()

Clang warns (or errors with CONFIG_WERROR=y):

  drivers/dma/xilinx/xdma.c:894:3: error: variable 'desc' is uninitialized when used here [-Werror,-Wuninitialized]
    894 |                 desc->error = true;
        |                 ^~~~

The initialization of desc was moved too far forward, move it back so
that this assignment does not result in a potential crash at runtime
while clearing up the warning.

Closes: https://github.com/ClangBuiltLinux/linux/issues/1972
Fixes: 2f8f90cd2f8d ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20231222-dma-xilinx-xdma-clang-fixes-v1-2-84a18ff184d2@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/xdma.c