lockd: lockd server-side shouldn't set fl_ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 20 Aug 2021 21:01:59 +0000 (17:01 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 21 Aug 2021 15:48:34 +0000 (11:48 -0400)
commit7de875b231edb807387a81cde288aa9e1015ef9e
tree02169570bb90ee052d40396055746bd5dca67cba
parent400edd8c0455b9de91d079a4141ff20ba2d221f2
lockd: lockd server-side shouldn't set fl_ops

Locks have two sets of op arrays, fl_lmops for the lock manager (lockd
or nfsd), fl_ops for the filesystem.  The server-side lockd code has
been setting its own fl_ops, which leads to confusion (and crashes) in
the reexport case, where the filesystem expects to be the only one
setting fl_ops.

And there's no reason for it that I can see-the lm_get/put_owner ops do
the same job.

Reported-by: Daire Byrne <daire@dneg.com>
Tested-by: Daire Byrne <daire@dneg.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/lockd/svclock.c