scsi: ufs: core: Leave space for '\0' in utf8 desc string
authorDaniel Mentz <danielmentz@google.com>
Tue, 17 Oct 2023 18:20:26 +0000 (11:20 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 25 Oct 2023 02:46:33 +0000 (22:46 -0400)
commita75a16c62a2540f11eeae4f2b50e95deefb652ea
tree56358c2e03d8b0ea869c1a2bfa2fc59ba16d9bab
parent6997283f64d968cf6bc8a68876930f67f48e1a6c
scsi: ufs: core: Leave space for '\0' in utf8 desc string

utf16s_to_utf8s does not NULL terminate the output string. For us to be
able to add a NULL character when utf16s_to_utf8s returns, we need to make
sure that there is space for such NULL character at the end of the output
buffer. We can achieve this by passing an output buffer size to
utf16s_to_utf8s that is one character less than what we allocated.

Other call sites of utf16s_to_utf8s appear to be using the same technique
where they artificially reduce the buffer size by one to leave space for a
NULL character or line feed character.

Fixes: 4b828fe156a6 ("scsi: ufs: revamp string descriptor reading")
Reviewed-by: Mars Cheng <marscheng@google.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Yen-lin Lai <yenlinlai@google.com>
Signed-off-by: Daniel Mentz <danielmentz@google.com>
Link: https://lore.kernel.org/r/20231017182026.2141163-1-danielmentz@google.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c