rtc: max31335: Fix comparison in max31335_volatile_reg()
authorNathan Chancellor <nathan@kernel.org>
Wed, 17 Jan 2024 17:54:16 +0000 (10:54 -0700)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 17 Jan 2024 23:59:32 +0000 (00:59 +0100)
commitdd7fe5d9fd6a27531e985e3812ef4031bd316b01
tree2367f284c6f38b937cbca3b458f231ddb6fed30f
parentb7d450d98b0f9917cac31b39ba459a4aee26c8b1
rtc: max31335: Fix comparison in max31335_volatile_reg()

Clang warns (or errors with CONFIG_WERROR=y):

    drivers/rtc/rtc-max31335.c:211:36: error: use of logical '||' with constant operand [-Werror,-Wconstant-logical-operand]
      211 |         if (reg == MAX31335_TEMP_DATA_MSB || MAX31335_TEMP_DATA_LSB)
          |                                           ^  ~~~~~~~~~~~~~~~~~~~~~~
    drivers/rtc/rtc-max31335.c:211:36: note: use '|' for a bitwise operation
      211 |         if (reg == MAX31335_TEMP_DATA_MSB || MAX31335_TEMP_DATA_LSB)
          |                                           ^~
          |                                           |
    1 error generated.

This clearly should be a comparison against reg. Fix the comparison so
that max31335_volatile_reg() does not always return true.

Closes: https://github.com/ClangBuiltLinux/linux/issues/1980
Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20240117-rtc-max3133-fix-comparison-v1-1-91e98b29d564@kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-max31335.c