udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 22 Feb 2022 13:42:51 +0000 (16:42 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Feb 2022 12:35:00 +0000 (12:35 +0000)
commitde7b2efacf4e83954aed3f029d347dfc0b7a4f49
tree58d477ad157b3fb31785e9c74528e9dc4dd1850b
parenta58da53ffd70294ebea8ecd0eb45fd0d74add9f9
udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister()

This test is checking if we exited the list via break or not.  However
if it did not exit via a break then "node" does not point to a valid
udp_tunnel_nic_shared_node struct.  It will work because of the way
the structs are laid out it's the equivalent of
"if (info->shared->udp_tunnel_nic_info != dev)" which will always be
true, but it's not the right way to test.

Fixes: 74cc6d182d03 ("udp_tunnel: add the ability to share port tables")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_tunnel_nic.c