2 * Copyright (c) 1999 Cameron Grant <cg@freebsd.org>
5 * Derived from the public domain Linux driver
7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions
10 * 1. Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
12 * 2. Redistributions in binary form must reproduce the above copyright
13 * notice, this list of conditions and the following disclaimer in the
14 * documentation and/or other materials provided with the distribution.
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
17 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
18 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
19 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
20 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
21 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
22 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
23 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHERIN CONTRACT, STRICT
24 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
25 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THEPOSSIBILITY OF
29 #ifdef HAVE_KERNEL_OPTION_HEADERS
33 #include <dev/sound/pcm/sound.h>
34 #include <dev/sound/pcm/ac97.h>
35 #include <dev/sound/pci/neomagic.h>
36 #include <dev/sound/pci/neomagic-coeff.h>
38 #include <bus/pci/pcireg.h>
39 #include <bus/pci/pcivar.h>
41 SND_DECLARE_FILE("$FreeBSD: head/sys/dev/sound/pci/neomagic.c 254263 2013-08-12 23:30:01Z scottl $");
43 /* -------------------------------------------------------------------- */
45 #define NM_BUFFSIZE 16384
47 #define NM256AV_PCI_ID 0x800510c8
48 #define NM256ZX_PCI_ID 0x800610c8
52 /* channel registers */
54 int active, spd, dir, fmt;
55 u_int32_t blksize, wmark;
56 struct snd_dbuf *buffer;
57 struct pcm_channel *channel;
58 struct sc_info *parent;
61 /* device private data */
66 struct resource *reg, *irq, *buf;
67 int regid, irqid, bufid;
70 u_int32_t ac97_base, ac97_status, ac97_busy;
71 u_int32_t buftop, pbuf, rbuf, cbuf, acbuf;
72 u_int32_t playint, recint, misc1int, misc2int;
73 u_int32_t irsz, badintr;
75 struct sc_chinfo pch, rch;
78 /* -------------------------------------------------------------------- */
85 static int nm_loadcoeff(struct sc_info *sc, int dir, int num);
86 static int nm_setch(struct sc_chinfo *ch);
87 static int nm_init(struct sc_info *);
88 static void nm_intr(void *);
90 /* talk to the card */
91 static u_int32_t nm_rd(struct sc_info *, int, int);
92 static void nm_wr(struct sc_info *, int, u_int32_t, int);
93 static u_int32_t nm_rdbuf(struct sc_info *, int, int);
94 static void nm_wrbuf(struct sc_info *, int, u_int32_t, int);
96 static u_int32_t badcards[] = {
102 #define NUM_BADCARDS (sizeof(badcards) / sizeof(u_int32_t))
104 /* The actual rates supported by the card. */
105 static int samplerates[9] = {
117 /* -------------------------------------------------------------------- */
119 static u_int32_t nm_fmt[] = {
120 SND_FORMAT(AFMT_U8, 1, 0),
121 SND_FORMAT(AFMT_U8, 2, 0),
122 SND_FORMAT(AFMT_S16_LE, 1, 0),
123 SND_FORMAT(AFMT_S16_LE, 2, 0),
126 static struct pcmchan_caps nm_caps = {4000, 48000, nm_fmt, 0};
128 /* -------------------------------------------------------------------- */
132 nm_rd(struct sc_info *sc, int regno, int size)
134 bus_space_tag_t st = rman_get_bustag(sc->reg);
135 bus_space_handle_t sh = rman_get_bushandle(sc->reg);
139 return bus_space_read_1(st, sh, regno);
141 return bus_space_read_2(st, sh, regno);
143 return bus_space_read_4(st, sh, regno);
150 nm_wr(struct sc_info *sc, int regno, u_int32_t data, int size)
152 bus_space_tag_t st = rman_get_bustag(sc->reg);
153 bus_space_handle_t sh = rman_get_bushandle(sc->reg);
157 bus_space_write_1(st, sh, regno, data);
160 bus_space_write_2(st, sh, regno, data);
163 bus_space_write_4(st, sh, regno, data);
169 nm_rdbuf(struct sc_info *sc, int regno, int size)
171 bus_space_tag_t st = rman_get_bustag(sc->buf);
172 bus_space_handle_t sh = rman_get_bushandle(sc->buf);
176 return bus_space_read_1(st, sh, regno);
178 return bus_space_read_2(st, sh, regno);
180 return bus_space_read_4(st, sh, regno);
187 nm_wrbuf(struct sc_info *sc, int regno, u_int32_t data, int size)
189 bus_space_tag_t st = rman_get_bustag(sc->buf);
190 bus_space_handle_t sh = rman_get_bushandle(sc->buf);
194 bus_space_write_1(st, sh, regno, data);
197 bus_space_write_2(st, sh, regno, data);
200 bus_space_write_4(st, sh, regno, data);
205 /* -------------------------------------------------------------------- */
208 nm_waitcd(struct sc_info *sc)
214 if (nm_rd(sc, sc->ac97_status, 2) & sc->ac97_busy) {
225 nm_initcd(kobj_t obj, void *devinfo)
227 struct sc_info *sc = (struct sc_info *)devinfo;
229 nm_wr(sc, 0x6c0, 0x01, 1);
232 * The following code-line may cause a hang for some chipsets, see
234 * In case of a bugreport without this line have a look at the PR and
235 * conditionize the code-line based upon the specific version of
238 nm_wr(sc, 0x6cc, 0x87, 1);
240 nm_wr(sc, 0x6cc, 0x80, 1);
241 nm_wr(sc, 0x6cc, 0x00, 1);
246 nm_rdcd(kobj_t obj, void *devinfo, int regno)
248 struct sc_info *sc = (struct sc_info *)devinfo;
251 if (!nm_waitcd(sc)) {
252 x = nm_rd(sc, sc->ac97_base + regno, 2);
256 device_printf(sc->dev, "ac97 codec not ready\n");
262 nm_wrcd(kobj_t obj, void *devinfo, int regno, u_int32_t data)
264 struct sc_info *sc = (struct sc_info *)devinfo;
267 if (!nm_waitcd(sc)) {
269 nm_wr(sc, sc->ac97_base + regno, data, 2);
270 if (!nm_waitcd(sc)) {
276 device_printf(sc->dev, "ac97 codec not ready\n");
280 static kobj_method_t nm_ac97_methods[] = {
281 KOBJMETHOD(ac97_init, nm_initcd),
282 KOBJMETHOD(ac97_read, nm_rdcd),
283 KOBJMETHOD(ac97_write, nm_wrcd),
286 AC97_DECLARE(nm_ac97);
288 /* -------------------------------------------------------------------- */
291 nm_ackint(struct sc_info *sc, u_int32_t num)
293 if (sc->type == NM256AV_PCI_ID) {
294 nm_wr(sc, NM_INT_REG, num << 1, 2);
295 } else if (sc->type == NM256ZX_PCI_ID) {
296 nm_wr(sc, NM_INT_REG, num, 4);
301 nm_loadcoeff(struct sc_info *sc, int dir, int num)
306 addr = (dir == PCMDIR_PLAY)? 0x01c : 0x21c;
307 if (dir == PCMDIR_REC)
309 sz = coefficientSizes[num];
312 ofs+= coefficientSizes[num];
313 for (i = 0; i < sz; i++)
314 nm_wrbuf(sc, sc->cbuf + i, coefficients[ofs + i], 1);
315 nm_wr(sc, addr, sc->cbuf, 4);
316 if (dir == PCMDIR_PLAY)
318 nm_wr(sc, addr + 4, sc->cbuf + sz, 4);
323 nm_setch(struct sc_chinfo *ch)
325 struct sc_info *sc = ch->parent;
329 for (x = 0; x < 8; x++)
330 if (ch->spd < (samplerates[x] + samplerates[x + 1]) / 2)
333 if (x == 8) return 1;
335 ch->spd = samplerates[x];
336 nm_loadcoeff(sc, ch->dir, x);
340 if (ch->fmt & AFMT_16BIT) x |= NM_RATE_BITS_16;
341 if (AFMT_CHANNEL(ch->fmt) > 1) x |= NM_RATE_STEREO;
343 base = (ch->dir == PCMDIR_PLAY)? NM_PLAYBACK_REG_OFFSET : NM_RECORD_REG_OFFSET;
344 nm_wr(sc, base + NM_RATE_REG_OFFSET, x, 1);
348 /* channel interface */
350 nmchan_init(kobj_t obj, void *devinfo, struct snd_dbuf *b, struct pcm_channel *c, int dir)
352 struct sc_info *sc = devinfo;
353 struct sc_chinfo *ch;
356 chnbuf = (dir == PCMDIR_PLAY)? sc->pbuf : sc->rbuf;
357 ch = (dir == PCMDIR_PLAY)? &sc->pch : &sc->rch;
362 sndbuf_setup(ch->buffer, (u_int8_t *)rman_get_virtual(sc->buf) + chnbuf, NM_BUFFSIZE);
364 device_printf(sc->dev, "%s buf %p\n", (dir == PCMDIR_PLAY)?
365 "play" : "rec", sndbuf_getbuf(ch->buffer));
373 nmchan_free(kobj_t obj, void *data)
379 nmchan_setformat(kobj_t obj, void *data, u_int32_t format)
381 struct sc_chinfo *ch = data;
388 nmchan_setspeed(kobj_t obj, void *data, u_int32_t speed)
390 struct sc_chinfo *ch = data;
393 return nm_setch(ch)? 0 : ch->spd;
397 nmchan_setblocksize(kobj_t obj, void *data, u_int32_t blocksize)
399 struct sc_chinfo *ch = data;
401 ch->blksize = blocksize;
407 nmchan_trigger(kobj_t obj, void *data, int go)
409 struct sc_chinfo *ch = data;
410 struct sc_info *sc = ch->parent;
413 if (!PCMTRIG_COMMON(go))
416 ssz = (ch->fmt & AFMT_16BIT)? 2 : 1;
417 if (AFMT_CHANNEL(ch->fmt) > 1)
420 if (ch->dir == PCMDIR_PLAY) {
421 if (go == PCMTRIG_START) {
423 ch->wmark = ch->blksize;
424 nm_wr(sc, NM_PBUFFER_START, sc->pbuf, 4);
425 nm_wr(sc, NM_PBUFFER_END, sc->pbuf + NM_BUFFSIZE - ssz, 4);
426 nm_wr(sc, NM_PBUFFER_CURRP, sc->pbuf, 4);
427 nm_wr(sc, NM_PBUFFER_WMARK, sc->pbuf + ch->wmark, 4);
428 nm_wr(sc, NM_PLAYBACK_ENABLE_REG, NM_PLAYBACK_FREERUN |
429 NM_PLAYBACK_ENABLE_FLAG, 1);
430 nm_wr(sc, NM_AUDIO_MUTE_REG, 0, 2);
433 nm_wr(sc, NM_PLAYBACK_ENABLE_REG, 0, 1);
434 nm_wr(sc, NM_AUDIO_MUTE_REG, NM_AUDIO_MUTE_BOTH, 2);
437 if (go == PCMTRIG_START) {
439 ch->wmark = ch->blksize;
440 nm_wr(sc, NM_RECORD_ENABLE_REG, NM_RECORD_FREERUN |
441 NM_RECORD_ENABLE_FLAG, 1);
442 nm_wr(sc, NM_RBUFFER_START, sc->rbuf, 4);
443 nm_wr(sc, NM_RBUFFER_END, sc->rbuf + NM_BUFFSIZE, 4);
444 nm_wr(sc, NM_RBUFFER_CURRP, sc->rbuf, 4);
445 nm_wr(sc, NM_RBUFFER_WMARK, sc->rbuf + ch->wmark, 4);
448 nm_wr(sc, NM_RECORD_ENABLE_REG, 0, 1);
455 nmchan_getptr(kobj_t obj, void *data)
457 struct sc_chinfo *ch = data;
458 struct sc_info *sc = ch->parent;
460 if (ch->dir == PCMDIR_PLAY)
461 return nm_rd(sc, NM_PBUFFER_CURRP, 4) - sc->pbuf;
463 return nm_rd(sc, NM_RBUFFER_CURRP, 4) - sc->rbuf;
466 static struct pcmchan_caps *
467 nmchan_getcaps(kobj_t obj, void *data)
472 static kobj_method_t nmchan_methods[] = {
473 KOBJMETHOD(channel_init, nmchan_init),
474 KOBJMETHOD(channel_free, nmchan_free),
475 KOBJMETHOD(channel_setformat, nmchan_setformat),
476 KOBJMETHOD(channel_setspeed, nmchan_setspeed),
477 KOBJMETHOD(channel_setblocksize, nmchan_setblocksize),
478 KOBJMETHOD(channel_trigger, nmchan_trigger),
479 KOBJMETHOD(channel_getptr, nmchan_getptr),
480 KOBJMETHOD(channel_getcaps, nmchan_getcaps),
483 CHANNEL_DECLARE(nmchan);
485 /* The interrupt handler */
489 struct sc_info *sc = (struct sc_info *)p;
492 status = nm_rd(sc, NM_INT_REG, sc->irsz);
496 if (status & sc->playint) {
497 status &= ~sc->playint;
498 sc->pch.wmark += sc->pch.blksize;
499 sc->pch.wmark %= NM_BUFFSIZE;
500 nm_wr(sc, NM_PBUFFER_WMARK, sc->pbuf + sc->pch.wmark, 4);
502 nm_ackint(sc, sc->playint);
503 chn_intr(sc->pch.channel);
505 if (status & sc->recint) {
506 status &= ~sc->recint;
507 sc->rch.wmark += sc->rch.blksize;
508 sc->rch.wmark %= NM_BUFFSIZE;
509 nm_wr(sc, NM_RBUFFER_WMARK, sc->rbuf + sc->rch.wmark, 4);
511 nm_ackint(sc, sc->recint);
512 chn_intr(sc->rch.channel);
514 if (status & sc->misc1int) {
515 status &= ~sc->misc1int;
516 nm_ackint(sc, sc->misc1int);
517 x = nm_rd(sc, 0x400, 1);
518 nm_wr(sc, 0x400, x | 2, 1);
519 device_printf(sc->dev, "misc int 1\n");
521 if (status & sc->misc2int) {
522 status &= ~sc->misc2int;
523 nm_ackint(sc, sc->misc2int);
524 x = nm_rd(sc, 0x400, 1);
525 nm_wr(sc, 0x400, x & ~2, 1);
526 device_printf(sc->dev, "misc int 2\n");
529 nm_ackint(sc, status);
530 device_printf(sc->dev, "unknown int\n");
534 /* -------------------------------------------------------------------- */
537 * Probe and attach the card
541 nm_init(struct sc_info *sc)
545 if (sc->type == NM256AV_PCI_ID) {
546 sc->ac97_base = NM_MIXER_OFFSET;
547 sc->ac97_status = NM_MIXER_STATUS_OFFSET;
548 sc->ac97_busy = NM_MIXER_READY_MASK;
550 sc->buftop = 2560 * 1024;
553 sc->playint = NM_PLAYBACK_INT;
554 sc->recint = NM_RECORD_INT;
555 sc->misc1int = NM_MISC_INT_1;
556 sc->misc2int = NM_MISC_INT_2;
557 } else if (sc->type == NM256ZX_PCI_ID) {
558 sc->ac97_base = NM_MIXER_OFFSET;
559 sc->ac97_status = NM2_MIXER_STATUS_OFFSET;
560 sc->ac97_busy = NM2_MIXER_READY_MASK;
562 sc->buftop = (nm_rd(sc, 0xa0b, 2)? 6144 : 4096) * 1024;
565 sc->playint = NM2_PLAYBACK_INT;
566 sc->recint = NM2_RECORD_INT;
567 sc->misc1int = NM2_MISC_INT_1;
568 sc->misc2int = NM2_MISC_INT_2;
571 ofs = sc->buftop - 0x0400;
572 sc->buftop -= 0x1400;
575 device_printf(sc->dev, "buftop is 0x%08x\n", sc->buftop);
576 if ((nm_rdbuf(sc, ofs, 4) & NM_SIG_MASK) == NM_SIGNATURE) {
577 i = nm_rdbuf(sc, ofs + 4, 4);
578 if (i != 0 && i != 0xffffffff) {
580 device_printf(sc->dev, "buftop is changed to 0x%08x\n", i);
585 sc->cbuf = sc->buftop - NM_MAX_COEFFICIENT;
586 sc->rbuf = sc->cbuf - NM_BUFFSIZE;
587 sc->pbuf = sc->rbuf - NM_BUFFSIZE;
588 sc->acbuf = sc->pbuf - (NM_TOTAL_COEFF_COUNT * 4);
590 nm_wr(sc, 0, 0x11, 1);
591 nm_wr(sc, NM_RECORD_ENABLE_REG, 0, 1);
592 nm_wr(sc, 0x214, 0, 2);
598 nm_pci_probe(device_t dev)
600 struct sc_info *sc = NULL;
604 subdev = (pci_get_subdevice(dev) << 16) | pci_get_subvendor(dev);
605 switch (pci_get_devid(dev)) {
608 while ((i < NUM_BADCARDS) && (badcards[i] != subdev))
611 /* Try to catch other non-ac97 cards */
613 if (i == NUM_BADCARDS) {
614 if (!(sc = kmalloc(sizeof(*sc), M_DEVBUF, M_WAITOK | M_ZERO))) {
615 device_printf(dev, "cannot allocate softc\n");
619 sc->regid = PCIR_BAR(1);
620 sc->reg = bus_alloc_resource_any(dev, SYS_RES_MEMORY,
625 device_printf(dev, "unable to map register space\n");
631 * My Panasonic CF-M2EV needs resetting device
632 * before checking mixer is present or not.
633 * t.ichinoseki@nifty.com.
635 nm_wr(sc, 0, 0x11, 1); /* reset device */
636 if ((nm_rd(sc, NM_MIXER_PRESENCE, 2) &
637 NM_PRESENCE_MASK) != NM_PRESENCE_VALUE) {
638 i = 0; /* non-ac97 card, but not listed */
639 DEB(device_printf(dev, "subdev = 0x%x - badcard?\n",
642 bus_release_resource(dev, SYS_RES_MEMORY, sc->regid,
647 if (i == NUM_BADCARDS)
648 s = "NeoMagic 256AV";
650 DEB(device_printf(dev, "this is a non-ac97 NM256AV, not attaching\n"));
655 s = "NeoMagic 256ZX";
659 if (s) device_set_desc(dev, s);
664 nm_pci_attach(device_t dev)
667 struct ac97_info *codec = 0;
668 char status[SND_STATUSLEN];
670 sc = kmalloc(sizeof(*sc), M_DEVBUF, M_WAITOK | M_ZERO);
672 sc->type = pci_get_devid(dev);
674 pci_enable_busmaster(dev);
676 sc->bufid = PCIR_BAR(0);
677 sc->buf = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &sc->bufid,
679 sc->regid = PCIR_BAR(1);
680 sc->reg = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &sc->regid,
683 if (!sc->buf || !sc->reg) {
684 device_printf(dev, "unable to map register space\n");
688 if (nm_init(sc) == -1) {
689 device_printf(dev, "unable to initialize the card\n");
693 codec = AC97_CREATE(dev, sc, nm_ac97);
694 if (codec == NULL) goto bad;
695 if (mixer_init(dev, ac97_getmixerclass(), codec) == -1) goto bad;
698 sc->irq = bus_alloc_resource_any(dev, SYS_RES_IRQ, &sc->irqid,
699 RF_ACTIVE | RF_SHAREABLE);
700 if (!sc->irq || snd_setup_intr(dev, sc->irq, 0, nm_intr, sc, &sc->ih)) {
701 device_printf(dev, "unable to map interrupt\n");
705 ksnprintf(status, SND_STATUSLEN, "at memory 0x%lx, 0x%lx irq %ld %s",
706 rman_get_start(sc->buf), rman_get_start(sc->reg),
707 rman_get_start(sc->irq),PCM_KLDSTRING(snd_neomagic));
709 if (pcm_register(dev, sc, 1, 1)) goto bad;
710 pcm_addchan(dev, PCMDIR_REC, &nmchan_class, sc);
711 pcm_addchan(dev, PCMDIR_PLAY, &nmchan_class, sc);
712 pcm_setstatus(dev, status);
717 if (codec) ac97_destroy(codec);
718 if (sc->buf) bus_release_resource(dev, SYS_RES_MEMORY, sc->bufid, sc->buf);
719 if (sc->reg) bus_release_resource(dev, SYS_RES_MEMORY, sc->regid, sc->reg);
720 if (sc->ih) bus_teardown_intr(dev, sc->irq, sc->ih);
721 if (sc->irq) bus_release_resource(dev, SYS_RES_IRQ, sc->irqid, sc->irq);
727 nm_pci_detach(device_t dev)
732 r = pcm_unregister(dev);
736 sc = pcm_getdevinfo(dev);
737 bus_release_resource(dev, SYS_RES_MEMORY, sc->bufid, sc->buf);
738 bus_release_resource(dev, SYS_RES_MEMORY, sc->regid, sc->reg);
739 bus_teardown_intr(dev, sc->irq, sc->ih);
740 bus_release_resource(dev, SYS_RES_IRQ, sc->irqid, sc->irq);
747 nm_pci_suspend(device_t dev)
751 sc = pcm_getdevinfo(dev);
754 if (sc->pch.active) {
755 nm_wr(sc, NM_PLAYBACK_ENABLE_REG, 0, 1);
756 nm_wr(sc, NM_AUDIO_MUTE_REG, NM_AUDIO_MUTE_BOTH, 2);
759 if (sc->rch.active) {
760 nm_wr(sc, NM_RECORD_ENABLE_REG, 0, 1);
766 nm_pci_resume(device_t dev)
770 sc = pcm_getdevinfo(dev);
773 * Reinit audio device.
774 * Don't call nm_init(). It would change buftop if X ran or
775 * is running. This makes playing and recording buffer address
776 * shift but these buffers of channel layer are not changed.
777 * As a result of this inconsistency, periodic noise will be
778 * generated while playing.
780 nm_wr(sc, 0, 0x11, 1);
781 nm_wr(sc, 0x214, 0, 2);
784 if (mixer_reinit(dev) == -1) {
785 device_printf(dev, "unable to reinitialize the mixer\n");
788 /* restart playing */
789 if (sc->pch.active) {
790 nm_wr(sc, NM_PLAYBACK_ENABLE_REG, NM_PLAYBACK_FREERUN |
791 NM_PLAYBACK_ENABLE_FLAG, 1);
792 nm_wr(sc, NM_AUDIO_MUTE_REG, 0, 2);
794 /* restart recording */
795 if (sc->rch.active) {
796 nm_wr(sc, NM_RECORD_ENABLE_REG, NM_RECORD_FREERUN |
797 NM_RECORD_ENABLE_FLAG, 1);
802 static device_method_t nm_methods[] = {
803 /* Device interface */
804 DEVMETHOD(device_probe, nm_pci_probe),
805 DEVMETHOD(device_attach, nm_pci_attach),
806 DEVMETHOD(device_detach, nm_pci_detach),
807 DEVMETHOD(device_suspend, nm_pci_suspend),
808 DEVMETHOD(device_resume, nm_pci_resume),
812 static driver_t nm_driver = {
818 DRIVER_MODULE(snd_neomagic, pci, nm_driver, pcm_devclass, 0, 0);
819 MODULE_DEPEND(snd_neomagic, sound, SOUND_MINVER, SOUND_PREFVER, SOUND_MAXVER);
820 MODULE_VERSION(snd_neomagic, 1);