From 1b726affc868c4da5ba5b22c777757716bc6002e Mon Sep 17 00:00:00 2001 From: Sepherosa Ziehau Date: Wed, 15 Jun 2016 19:19:47 +0800 Subject: [PATCH] acpica: Interrupt resource lookup failure is fine. Add comment about it. --- sys/dev/acpica/acpi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c index ec6ad082b5..a4f4a3c12b 100644 --- a/sys/dev/acpica/acpi.c +++ b/sys/dev/acpica/acpi.c @@ -1135,12 +1135,16 @@ acpi_alloc_resource(device_t bus, device_t child, int type, int *rid, * parse the resources but have to defer it until a driver * actually allocates the interrupt via bus_alloc_resource(). * - * XXX: Should we handle the lookup failing? + * NB: Lookup failure is fine, since the device may add its + * own interrupt resources, e.g. MSI or MSI-X. */ - if (ACPI_SUCCESS(acpi_lookup_irq_resource(child, *rid, res, &ares))) + if (ACPI_SUCCESS( + acpi_lookup_irq_resource(child, *rid, res, &ares))) { acpi_config_intr(child, &ares); - else - kprintf("irq resource not found\n"); + } else { + if (bootverbose) + kprintf("irq resource not found\n"); + } break; } -- 2.41.0