freebsd.git
8 years agoPull in r270240 from upstream clang trunk (by me):
dim [Fri, 20 May 2016 17:38:45 +0000 (17:38 +0000)]
Pull in r270240 from upstream clang trunk (by me):

  Make __FreeBSD_cc_version predefined macro configurable at build time

  The `FreeBSDTargetInfo` class has always set the `__FreeBSD_cc_version`
  predefined macro to a rather static value, calculated from the major OS
  version.

  In the FreeBSD base system, we will start incrementing the value of this
  macro whenever we make any signifant change to clang, so we need a way
  to configure the macro's value at build time.

  Use `FREEBSD_CC_VERSION` for this, which we can define in the FreeBSD
  build system using either the `-D` command line option, or an include
  file.  Stock builds will keep the earlier value.

  Differential Revision: http://reviews.llvm.org/D20037

Follow-up commits will start using the __FreeBSD_cc_version to determine
whether a bootstrap compiler has to be built during buildworld.

8 years agoMerge bmake-20160512
sjg [Fri, 20 May 2016 17:35:39 +0000 (17:35 +0000)]
Merge bmake-20160512

8 years agoUpdate to ELF Tool Chain r3475
emaste [Fri, 20 May 2016 17:24:34 +0000 (17:24 +0000)]
Update to ELF Tool Chain r3475

Improvements include:

 * Add support for reporting and handling a number of new constants in
   various tools, including:
    * CloudABI OSABI
    * DT_TLSDESC_*
    * i386, MIPS, SPARC and amd64 relocations

 * C++ demangler bug fixes

 * Man page updates

 * Improved input validation in several tools

This update also reduces diffs against upstream as a number of fixes
included in upstream were previously cherry-picked into FreeBSD.

Sponsored by: The FreeBSD Foundation

8 years agoExtract the correct bits from the GICD_TYPER register. The interrupt count
andrew [Fri, 20 May 2016 15:43:51 +0000 (15:43 +0000)]
Extract the correct bits from the GICD_TYPER register. The interrupt count
is encoded in the bottom 5 bits.

Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation

8 years agopf: Fix fragment timeout
kp [Fri, 20 May 2016 15:41:05 +0000 (15:41 +0000)]
pf: Fix fragment timeout

We were inconsistent about the use of time_second vs. time_uptime.
Always use time_uptime so the value can be meaningfully compared.

Submitted by: "Max" <maximos@als.nnov.ru>
MFC after: 4 days

8 years agoGarbage collect unused prototype for clockintr().
rwatson [Fri, 20 May 2016 15:34:03 +0000 (15:34 +0000)]
Garbage collect unused prototype for clockintr().

MFC after: 3 days

8 years agoUse unsigned type for the loop index to make overflow checks effective.
kib [Fri, 20 May 2016 15:32:48 +0000 (15:32 +0000)]
Use unsigned type for the loop index to make overflow checks effective.

PR: 209661
Reported by: cturt
Sponsored by: The FreeBSD Foundation
MFC after: 3 days

8 years agogas/config/tc-arm.c: Minor re-sorting to match upstream history.
pfg [Fri, 20 May 2016 15:14:38 +0000 (15:14 +0000)]
gas/config/tc-arm.c: Minor re-sorting to match upstream history.

No functional change.

MFC after: 2 weeks

8 years agoRemove brk and sbrk from arm64. They were defined in The Single UNIX
andrew [Fri, 20 May 2016 15:04:48 +0000 (15:04 +0000)]
Remove brk and sbrk from arm64. They were defined in The Single UNIX
Specification, Version 2, but marked as legacy, and have been removed from
later specifications. After 12 years it is time to remove them from new
architectures when the main use for sbrk is an invalid method to attempt
to find how much memory has been allocated from malloc.

There are a few places in the tree that still call sbrk, however they are
not used on arm64. They will need to be fixed to cross build from arm64,
but these will be fixed in a follow up commit.

Old copies of binutils from ports called into sbrk, however this has been
fixed around 6 weeks ago. It is advised to update binutils on arm64 before
installing a world that includes this change.

Reviewed by: brooks, emaste
Obtained from: brooks
Relnotes: yes
Sponsored by: ABT Systems Ltd
Differential Revision: https://reviews.freebsd.org/D6464

8 years agoFix the regression introduced in r300143.
ae [Fri, 20 May 2016 15:00:12 +0000 (15:00 +0000)]
Fix the regression introduced in r300143.
When we are creating new dynamic state use MATCH_FORWARD direction to
correctly initialize protocol's state.

8 years agoGCC: Add support for named initializers for anonymous structs/unions.
pfg [Fri, 20 May 2016 14:36:49 +0000 (14:36 +0000)]
GCC: Add support for named initializers for anonymous structs/unions.

This is a C11 feature that is starting to get used in places such as Mesa.
This implementation takes a different approach to upstream and is
therefore not covered by GPLv3.

Obtained from: OpenBSD (CVS rev. 1.2)
MFC after: 3 weeks

8 years agoAdd more useful GICv3 register definitions. While here fix
andrew [Fri, 20 May 2016 13:11:07 +0000 (13:11 +0000)]
Add more useful GICv3 register definitions. While here fix
GITS_CBASER_CACHE_MASK to use the correct shift macro.

Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation

8 years agoFilter out BUS_DMASYNC_POSTWRITE sync operations, there is nothing for us
andrew [Fri, 20 May 2016 12:38:48 +0000 (12:38 +0000)]
Filter out BUS_DMASYNC_POSTWRITE sync operations, there is nothing for us
to do on these.

Reported by: wma
Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation

8 years agoRemove ip6 adjusting from the place where pointer couldn't be changed.
ae [Fri, 20 May 2016 12:17:40 +0000 (12:17 +0000)]
Remove ip6 adjusting from the place where pointer couldn't be changed.
And add comment after calling PFIL hooks, where it could be changed.

8 years agoRemove ip6 pointer initialization and strange check from the beginning
ae [Fri, 20 May 2016 12:09:10 +0000 (12:09 +0000)]
Remove ip6 pointer initialization and strange check from the beginning
of ip6_output(). It isn't used until the first time adjusted.
Remove the comment about adjusting where it is actually initialized.

8 years agoPass proper for 23xx arguments to isp_endcmd().
mav [Fri, 20 May 2016 11:56:16 +0000 (11:56 +0000)]
Pass proper for 23xx arguments to isp_endcmd().

8 years agoFix VNIC module unloading
wma [Fri, 20 May 2016 11:02:04 +0000 (11:02 +0000)]
Fix VNIC module unloading

Fix panics which were present when BGX and PF module were unloaded.

Reviewed by: zbb
Obtained from: Semihalf
Sponsored by: Cavium
Differential Revision: https://reviews.freebsd.org/D6346

8 years agoAllow building VNIC as a module
wma [Fri, 20 May 2016 11:00:06 +0000 (11:00 +0000)]
Allow building VNIC as a module

Add directory structure and fix dependencies to be able to
build and use Cavium VNIC driver as a module.

Reviewed by: zbb
Obtained from: Semihalf
Sponsored by: Cavium
Differential Revision: https://reviews.freebsd.org/D6345

8 years agoPass task management response information from CTL through CAM to isp(4),
mav [Fri, 20 May 2016 10:26:12 +0000 (10:26 +0000)]
Pass task management response information from CTL through CAM to isp(4),
utilizing previously unused arg field of struct ccb_notify_acknowledge.

This makes new QUERY TASK, QUERY TASK SET and QUERY ASYNC EVENT requests
really functional for CAM target mode drivers.

8 years agowi: fix a typo.
avos [Fri, 20 May 2016 08:58:06 +0000 (08:58 +0000)]
wi: fix a typo.

The max size of bitmask is IEEE80211_MODE_BYTES, not IEEE80211_MODE_MAX.

Reuse it in bwn(4) while I'm here.

Noticed by: kevlo

8 years agoEnable NEW_PCIB on arm64.
andrew [Fri, 20 May 2016 08:43:18 +0000 (08:43 +0000)]
Enable NEW_PCIB on arm64.

Obtained from: ABT Systems Ltd
Relnotes: yes
Sponsored by: The FreeBSD Foundation

8 years agoHandle PCI_RES_BUS on the generic and ThunderX PCIe drivers. This has been
andrew [Fri, 20 May 2016 08:29:00 +0000 (08:29 +0000)]
Handle PCI_RES_BUS on the generic and ThunderX PCIe drivers. This has been
tested on the Pass 1.1 and 2.0 ThunderX machines in the Netperf cluster.

Reviewed by: jhb
Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D6453

8 years agoRemove unneeded Giant locking around kthreads creation.
kib [Fri, 20 May 2016 08:28:11 +0000 (08:28 +0000)]
Remove unneeded Giant locking around kthreads creation.

Sponsored by: The FreeBSD Foundation

8 years agoRemoval of Giant droping wrappers for GEOM classes.
kib [Fri, 20 May 2016 08:25:37 +0000 (08:25 +0000)]
Removal of Giant droping wrappers for GEOM classes.

Sponsored by: The FreeBSD Foundation

8 years agoRemove asserts that Giant is not held on entrance into geom KPI, which
kib [Fri, 20 May 2016 08:22:20 +0000 (08:22 +0000)]
Remove asserts that Giant is not held on entrance into geom KPI, which
outlived their usefulness.  This allows to remove drop/pickup Giant
wrappers around GEOM calls.

Discussed with: alfred, imp, phk
Sponsored by: The FreeBSD Foundation

8 years agoVerify one sysctl parameter at a time. When a mlx5en sysctl parameter
hselasky [Fri, 20 May 2016 07:07:27 +0000 (07:07 +0000)]
Verify one sysctl parameter at a time. When a mlx5en sysctl parameter
is updated only verify the changed one instead of all.

No functional change.

Sponsored by: Mellanox Technologies
Tested by: Netflix
MFC after: 1 week

8 years agoOptimise use of doorbell and remove redundant NOPs
hselasky [Fri, 20 May 2016 06:59:38 +0000 (06:59 +0000)]
Optimise use of doorbell and remove redundant NOPs

Store the last doorbell write in the mlx5e_sq structure and write the
doorbell to the hardware when the transmit routine finishes
transmitting all queued mbufs.

Sponsored by: Mellanox Technologies
Tested by: Netflix
MFC after: 1 week

8 years agoImplement TX completion event interleaving.
hselasky [Fri, 20 May 2016 06:54:58 +0000 (06:54 +0000)]
Implement TX completion event interleaving.

This patch implements a sysctl which allows setting a factor, N, for
how many work queue elements can be generated before requiring a
completion event. When a completion event happens the code simulates N
completion events instead of only one. When draining a transmit queue,
N-1 NOPs are transmitted at most, to force generation of the final
completion event.  Further a timer is running every HZ ticks to flush
any remaining data off the transmit queue when the tx_completion_fact
> 1.

The goal of this feature is to reduce the PCI bandwidth needed when
transmitting data.

Sponsored by: Mellanox Technologies
Tested by: Netflix
MFC after: 1 week

8 years ago[ath] convert recent changes over to HAL format.
adrian [Fri, 20 May 2016 06:06:21 +0000 (06:06 +0000)]
[ath] convert recent changes over to HAL format.

This is needed to compile the ath tools, that includes this code
to run in userland.

Tested:

* Carambola 2, AR9331, STA mode

8 years agoFix a bug in the parsing code: always use the len and not 8.
imp [Fri, 20 May 2016 05:33:26 +0000 (05:33 +0000)]
Fix a bug in the parsing code: always use the len and not 8.

8 years agoMove IPv6 malloc tag definitions into the IPv6 code.
markj [Fri, 20 May 2016 04:45:08 +0000 (04:45 +0000)]
Move IPv6 malloc tag definitions into the IPv6 code.

8 years agoFix the style of the paging target predicates.
markj [Fri, 20 May 2016 04:43:56 +0000 (04:43 +0000)]
Fix the style of the paging target predicates.

Discussed with: alc, kib
MFC after: 1 week

8 years agoRemove extraneous blank line.
cy [Fri, 20 May 2016 03:22:41 +0000 (03:22 +0000)]
Remove extraneous blank line.

MFC after: 1 month
X-MFC with: r300259

8 years agoEnable the two ip_frag tuneables. The code is there but the two
cy [Fri, 20 May 2016 03:04:22 +0000 (03:04 +0000)]
Enable the two ip_frag tuneables. The code is there but the two
ip_frag tuneables aren't registered in the ipf_tuners linked list.
This commmit enables the two existing ip_frag tuneables by registering
them.

MFC after: 1 month

8 years agoiic_rdwr_data->nmsgs is uint32_t, so limit the allowable number of messages to preven...
jah [Fri, 20 May 2016 03:03:04 +0000 (03:03 +0000)]
iic_rdwr_data->nmsgs is uint32_t, so limit the allowable number of messages to prevent memory exhaustion and short allocations on 32-bit systems. Since iicrdwr is intended to be a workalike of a Linux i2c-dev call, use the same limit of 42 that Linux uses.

Also check the return value of copyin(9) to prevent unnecessary allocation in the failure case.

Submitted by: ngie
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D5155

8 years agoFixup the geliboot sector rounding code
allanjude [Fri, 20 May 2016 01:41:47 +0000 (01:41 +0000)]
Fixup the geliboot sector rounding code

Replace all rounding with the round{up,down}2 macros
a missing set of braces caused the previous code to be incorrect

replace alloca() with malloc() because alloca() can return an allocation
that is actually invalid, causing boot to fail

Reviewed by: emaste, ed
Thanks To: peter
Sponsored by: ScaleEngine Inc.
Differential Revision: https://reviews.freebsd.org/D6213

8 years agoRemove DTrace tooklkit from the mtree and add the files to remove
gnn [Fri, 20 May 2016 01:38:31 +0000 (01:38 +0000)]
Remove DTrace tooklkit from the mtree and add the files to remove
to the ObsoleteFiles list.

Sponsored by: DARPA, AFRL

8 years agoRemove dangling references to rman_await_resource().
jhb [Fri, 20 May 2016 01:17:38 +0000 (01:17 +0000)]
Remove dangling references to rman_await_resource().

This function was removed when RF_TIMESHARE was removed a couple of years
ago.

MFC after: 3 days

8 years ago[bhnd] Add BHND SoC support (only BCMA case)
adrian [Fri, 20 May 2016 01:02:58 +0000 (01:02 +0000)]
[bhnd] Add BHND SoC support (only BCMA case)

This patch introduces support of BHND on SoC: nexus-to-bhnd drivers.

bhnd_soc is attached under nexus and responsible for all BHND-style calls
from bhnd(4) bus to parents.

bcma_nexus is bhnd(4) bus, attached to bhnd_soc and implement all
nexus-style behaviour of BHND.

Submitted by: Michael Zhilin <mizhka@gmail.com>
Reviewed by: Landon Fuller <landonf@landonf.org>
Differential Revision: https://reviews.freebsd.org/D6248

8 years ago[bhnd] Add bhnd bridge support for bus_adjust_resource().
adrian [Fri, 20 May 2016 00:49:10 +0000 (00:49 +0000)]
[bhnd] Add bhnd bridge support for bus_adjust_resource().

Adds support for adjusting active bus resource allocations, limiting the
range to the constraints of the register window within which the resource
is mapped.

This is the final set of bhnd changes required to support delegating
ChipCommon's register space to child devices.

Submitted by: Landon Fuller <landonf@landonf.org>
Differential Revision: https://reviews.freebsd.org/D6470

8 years ago[bhnd] Add remaining bus_(read|write|set)_(1|2|4) APIs
adrian [Fri, 20 May 2016 00:45:16 +0000 (00:45 +0000)]
[bhnd] Add remaining bus_(read|write|set)_(1|2|4) APIs

This adds bhnd-compatible implementations of bus_(read|write|set)_(1|2|4) APIs,
and upgrades the SPROM parsing code to use bhnd_bus_read_region_stream_2().

This a precursor to bridge support for resource adjustment and the new
ChipCommon bus support.

Tested:

* Tested against BCM4331
* Kernel build verified via tinderbox.

Submitted by: Landon Fuller <landonf@landonf.org>
Differential Revision: https://reviews.freebsd.org/D6469

8 years agoImplement a proper detach method for the PCI-PCI bridge driver.
jhb [Fri, 20 May 2016 00:03:22 +0000 (00:03 +0000)]
Implement a proper detach method for the PCI-PCI bridge driver.

- Add a pcib_detach() function for the PCI-PCI bridge driver.  It
  tears down the NEW_PCIB and hotplug state including destroying
  resource managers, deleting child devices, and disabling hotplug
  events.
- Add a detach method to the ACPI PCI-PCI bridge driver which calls
  pcib_detach() and then frees the copy of the _PRT interrupt routing
  table.
- Add a detach method to the PCI-Cardbus bridge driver which frees
  the PCI bus resources in addition to calling cbb_detach().
- Explicitly clear any pending hotplug events during attach to ensure
  future events will generate an interrupt.
- If a the Command Completed bit is set in the slot status register
  when the command completion timeout fires, treat it as if the
  command completed and the completion interrupt was just lost rather
  than forcing a detach.
- Don't wait for a Command Completed notification if Command Completion
  interrupts are disabled.  The spec explicitly says no interrupt is
  enabled when clearing CCIE, and on my T400 no interrupt is generated
  when CCIE is changed from cleared to set, either.  In addition, the
  T400 doesn't appear to set the Command Completed bit in the cases
  where it doesn't generate an interrupt, so don't schedule the timer
  either.  (If the CC bit were always set, one could always set the timer
  and rely on the logic of treating CC set as a missed interrupt.)

Reviewed by: imp (older version)
Differential Revision: https://reviews.freebsd.org/D6424

8 years agoiwm: add 'opt_wlan.h' include into source files.
avos [Thu, 19 May 2016 23:31:00 +0000 (23:31 +0000)]
iwm: add 'opt_wlan.h' include into source files.

Include net80211 options file, so IEEE80211_DEBUG_REFCNT option will be
handled correctly.

8 years agoDocument new net.inet.tcp.ecn.enable sysctl settings.
truckman [Thu, 19 May 2016 23:03:07 +0000 (23:03 +0000)]
Document new net.inet.tcp.ecn.enable sysctl settings.

MFC after: 1 month (with r300240)

8 years agoath: refactor/split getchannels() method.
avos [Thu, 19 May 2016 23:00:30 +0000 (23:00 +0000)]
ath: refactor/split getchannels() method.

Split getchannels() method in ath_hal/ah_regdomain.c into a subset
of functions for better readability.

Note: due to different internal structure, it cannot use
ieee80211_add_channel*() (however, some parts are done in a
similar manner).

Differential Revision: https://reviews.freebsd.org/D6139

8 years agoiwm: restart device after watchdog timeouts.
avos [Thu, 19 May 2016 22:43:21 +0000 (22:43 +0000)]
iwm: restart device after watchdog timeouts.

8 years agomwl: switch to ieee80211_add_channel*().
avos [Thu, 19 May 2016 22:28:46 +0000 (22:28 +0000)]
mwl: switch to ieee80211_add_channel*().

8 years agoChange net.inet.tcp.ecn.enable sysctl mib from a binary off/on
truckman [Thu, 19 May 2016 22:20:35 +0000 (22:20 +0000)]
Change net.inet.tcp.ecn.enable sysctl mib from a binary off/on
control to a three way setting.
  0 - Totally disable ECN. (no change)
  1 - Enable ECN if incoming connections request it.  Outgoing
      connections will request ECN.  (no change from present != 0 setting)
  2 - Enable ECN if incoming connections request it.  Outgoing
      conections will not request ECN.

Change the default value of net.inet.tcp.ecn.enable from 0 to 2.

Linux version 2.4.20 and newer, Solaris, and Mac OS X 10.5 and newer have
similar capabilities.  The actual values above match Linux, and the default
matches the current Linux default.

Reviewed by: eadler
MFC after: 1 month
MFH: yes
Sponsored by: https://reviews.freebsd.org/D6386

8 years agoipw: switch to ieee80211_add_channel()
avos [Thu, 19 May 2016 22:19:35 +0000 (22:19 +0000)]
ipw: switch to ieee80211_add_channel()

- Convert to ieee80211_add_channel().
- Add ic_getradiocaps() method.

Differential Revision: https://reviews.freebsd.org/D6236

8 years agowi: switch to ieee80211_add_channel()
avos [Thu, 19 May 2016 22:14:35 +0000 (22:14 +0000)]
wi: switch to ieee80211_add_channel()

- Convert to ieee80211_add_channel().
- Add ic_getradiocaps() method.

Differential Revision: https://reviews.freebsd.org/D6235

8 years agonet80211: restore interface state check for IEEE80211_IOC_SCAN_REQ ioctl.
avos [Thu, 19 May 2016 22:02:03 +0000 (22:02 +0000)]
net80211: restore interface state check for IEEE80211_IOC_SCAN_REQ ioctl.

Do not try to start a scan when interface is not running.

How-to-reproduce:
1) ifconfig wlan0 create wlandev urtwn0
2) wlandebug -i wlan0 state
3) ifconfig wlan0 scan

8 years agonet80211: fix more compiler warnings.
avos [Thu, 19 May 2016 21:08:33 +0000 (21:08 +0000)]
net80211: fix more compiler warnings.

ieee80211.c:
add_chanlist(): 'error' variable will be uninitialized if
                no channels were passed; return '0' instead.
ieee80211_action.c:
ieee80211_send_action_register(): drop 'break' after 'return'.
ieee80211_crypto_none.c:
none_encap(): 'keyid' is not used in non-debug builds; hide it
              behind IEEE80211_DEBUG ifdef.
ieee80211_freebsd.c:
Staticize global 'ieee80211_debug' variable (used only in this
file).
ieee80211_hostap.c:
Fix a comment (associatio -> association).
ieee80211_ht.c:
ieee80211_setup_htrates(): initialize 'maxunequalmcs' to 0 to mute
                           compiler warning.
ieee80211_hwmp.c:
hwmp_recv_preq(): copy 'prep' between conditional blocks to fix
  -Wshadow warning.
ieee80211_mesh.c:
mesh_newstate(): remove duplicate 'ni' definition.
mesh_recv_group_data(): fix -Wempty-body warning in non-debug
builds.
ieee80211_phy.c:
ieee80211_compute_duration(): remove 'break' after panic() call.
ieee80211_scan_sta.c:
Hide some TDMA-specific macros under IEEE80211_SUPPORT_TDMA ifdef
adhoc_pick_bss(): remove 'ic' pointer redefinition.
ieee80211_sta.c:
sta_beacon_miss(): remove 'ic' pointer redefinition.
ieee80211_superg.c:
superg_ioctl_set80211(): drop unreachable return.

Tested with clang 3.8.0, gcc 4.6.4 and gcc 5.3.0.

8 years agoelf_common.h: add section header flag and dynamic types
emaste [Thu, 19 May 2016 21:04:59 +0000 (21:04 +0000)]
elf_common.h: add section header flag and dynamic types

SHF_COMPRESSED section contains compressed data
DT_TLSDESC_PLT Location of PLT entry for TLS descriptor resolver calls
DT_TLSDESC_GOT Location of GOT entry used by resolver PLT entry

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

8 years agoFixed memory leak in FDT overlay handling code
gonzo [Thu, 19 May 2016 20:51:47 +0000 (20:51 +0000)]
Fixed memory leak in FDT overlay handling code

Free both overlay and new fdt before returning after fdt_open_into error
PR: 209634
Submitted by: David Binderman

8 years agoImport ELF Tool Chain snapshot at revision 3475
emaste [Thu, 19 May 2016 20:06:56 +0000 (20:06 +0000)]
Import ELF Tool Chain snapshot at revision 3475

From http://svn.code.sf.net/p/elftoolchain/code/

8 years agoMake code compile when basename() is POSIX compliant.
ed [Thu, 19 May 2016 20:03:01 +0000 (20:03 +0000)]
Make code compile when basename() is POSIX compliant.

If basename() uses "char *", we shouldn't do the intermediate
assignment, as that field is of type "const char *". Simply call
basename() on the command line argument directly.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D6463

8 years agoRemove the old version of the DTraceToolkit from the source tree.
gnn [Thu, 19 May 2016 19:51:39 +0000 (19:51 +0000)]
Remove the old version of the DTraceToolkit from the source tree.
The DTraceToolkit is part of the Open DTrace effort and is supported
on FreeBSD as a port (sysutils/DTraceToolkit) which has been updated
to properly track toolkit development upstream.

Sponsored by: DARPA, AFRL

8 years agoClean up the handling of errors from vm_pager_get_pages(). Mostly, this
alc [Thu, 19 May 2016 19:27:33 +0000 (19:27 +0000)]
Clean up the handling of errors from vm_pager_get_pages().  Mostly, this
cleanup consists of fixes to comments.  However, there is one change to
code: Remove special-case handling of errors involving the kernel map.
We do not perform I/O on the kernel map, so there is no need for this
special case.

Reviewed by: kib (an earlier version)

8 years agoAdjust a couple of error cases in camdd(8).
ken [Thu, 19 May 2016 19:13:43 +0000 (19:13 +0000)]
Adjust a couple of error cases in camdd(8).

usr.sbin/camdd/camdd.c:
In camdd_probe_file(), fix an error case after fstat where
we were bailing out and leaving two lines of cleanup code
unexecuted.  Instead, just goto bailout_error.

In camdd_probe_pass(), fail if the sector size is 0.

Sponsored by: Spectra Logic
MFC after: 3 days

8 years agovm/vm_page.h: Fix trivial '-Wpointer-sign' warning
cem [Thu, 19 May 2016 17:54:14 +0000 (17:54 +0000)]
vm/vm_page.h: Fix trivial '-Wpointer-sign' warning

pq_vcnt, as a count of real things, has no business being negative.  It is only
ever initialized by a u_int counter.

The warning came from the atomic_add_int() in vm_pagequeue_cnt_add().

Rectify the warning by changing the variable to u_int.  No functional change.

Suggested by: Clang 3.3
Sponsored by: EMC / Isilon Storage Division

8 years agoFix delaying requests to unknown virtual ports 2s after init.
mav [Thu, 19 May 2016 17:48:56 +0000 (17:48 +0000)]
Fix delaying requests to unknown virtual ports 2s after init.

This code was originally implemented 7 years ago, but never really worked
due to trivial error.  I think this functionality may be not required.
Initiators supporting optional periodic command status checks detected
those terminated commands and retried them 3 seconds later.  But thinking
about less featured initiators and the fact that it is our race makes
virtual ports "unknown" it may be good to have this feature.

8 years agoDocument _umtx_op(2) interface for the implementation of robust mutexes.
kib [Thu, 19 May 2016 17:40:00 +0000 (17:40 +0000)]
Document _umtx_op(2) interface for the implementation of robust mutexes.
In libthr(3), list added knobs.

Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D6427

8 years agosys/vmmeter.h: Fix trivial '-Wsign-compare' warning in common header
cem [Thu, 19 May 2016 17:21:24 +0000 (17:21 +0000)]
sys/vmmeter.h: Fix trivial '-Wsign-compare' warning in common header

Frankly, it doesn't make sense for vm_pageout_wakeup_thresh to have a negative
value (it is only ever set to a fraction of v_free_min, which is unsigned and
also obviously non-negative).  But I'm not going to try and convert every
non-negative scalar in the VM to unsigned today, so just cast it for the
comparison.

Submitted by: Clang 3.3
Sponsored by: EMC / Isilon Storage Division

8 years agoAdjust the creation of tq_name so it can be freed correctly
scottl [Thu, 19 May 2016 17:14:24 +0000 (17:14 +0000)]
Adjust the creation of tq_name so it can be freed correctly

Reviewed by: jhb, allanjude
Differential Revision: D6454

8 years agoAdd proper reporting for early task management errors.
mav [Thu, 19 May 2016 17:02:33 +0000 (17:02 +0000)]
Add proper reporting for early task management errors.

This covers unknown requests and requests to unknown virtual ports.
Previously it "worked" only because of timeout handling on initiator.

8 years agoAdd IOCB debugging for ISPCTL_RESET_DEV and ISPCTL_ABORT_CMD.
mav [Thu, 19 May 2016 16:53:53 +0000 (16:53 +0000)]
Add IOCB debugging for ISPCTL_RESET_DEV and ISPCTL_ABORT_CMD.

8 years agoFix logic error so UEFI variables are reported correctly
imp [Thu, 19 May 2016 16:36:06 +0000 (16:36 +0000)]
Fix logic error so UEFI variables are reported correctly
without error at the end.

8 years agosys/net: more spelling.
pfg [Thu, 19 May 2016 16:28:05 +0000 (16:28 +0000)]
sys/net: more spelling.

8 years agosys/vmmeter.h: "desperate" spelling fix.
pfg [Thu, 19 May 2016 16:02:02 +0000 (16:02 +0000)]
sys/vmmeter.h: "desperate" spelling fix.

8 years agoWhen iscsid(8) is running in ICL proxy mode, don't try to send Logout PDUs.
trasz [Thu, 19 May 2016 14:59:21 +0000 (14:59 +0000)]
When iscsid(8) is running in ICL proxy mode, don't try to send Logout PDUs.
The kernel already does this for us when we ask it to terminate the session.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

8 years agoMake ICL proxy use kernel code for handling iSCSI sequence numbers
trasz [Thu, 19 May 2016 14:57:37 +0000 (14:57 +0000)]
Make ICL proxy use kernel code for handling iSCSI sequence numbers
for PDUs to/from iscsid(8).  This fixes StatSN for Logout PDUs sent
by iscsi_session_logout().

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

8 years agoFix error message.
trasz [Thu, 19 May 2016 14:45:34 +0000 (14:45 +0000)]
Fix error message.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

8 years agoMake it possible to interrupt proxy-mode iscsid receive.
trasz [Thu, 19 May 2016 14:37:24 +0000 (14:37 +0000)]
Make it possible to interrupt proxy-mode iscsid receive.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

8 years agoExclude BCM from universe build until it compiles again.
bz [Thu, 19 May 2016 14:19:01 +0000 (14:19 +0000)]
Exclude BCM from universe build until it compiles again.

8 years agoAdd support for managing Shingled Magnetic Recording (SMR) drives.
ken [Thu, 19 May 2016 14:08:36 +0000 (14:08 +0000)]
Add support for managing Shingled Magnetic Recording (SMR) drives.

This change includes support for SCSI SMR drives (which conform to the
Zoned Block Commands or ZBC spec) and ATA SMR drives (which conform to
the Zoned ATA Command Set or ZAC spec) behind SAS expanders.

This includes full management support through the GEOM BIO interface, and
through a new userland utility, zonectl(8), and through camcontrol(8).

This is now ready for filesystems to use to detect and manage zoned drives.
(There is no work in progress that I know of to use this for ZFS or UFS, if
anyone is interested, let me know and I may have some suggestions.)

Also, improve ATA command passthrough and dispatch support, both via ATA
and ATA passthrough over SCSI.

Also, add support to camcontrol(8) for the ATA Extended Power Conditions
feature set.  You can now manage ATA device power states, and set various
idle time thresholds for a drive to enter lower power states.

Note that this change cannot be MFCed in full, because it depends on
changes to the struct bio API that break compatilibity.  In order to
avoid breaking the stable API, only changes that don't touch or depend on
the struct bio changes can be merged.  For example, the camcontrol(8)
changes don't depend on the new bio API, but zonectl(8) and the probe
changes to the da(4) and ada(4) drivers do depend on it.

Also note that the SMR changes have not yet been tested with an actual
SCSI ZBC device, or a SCSI to ATA translation layer (SAT) that supports
ZBC to ZAC translation.  I have not yet gotten a suitable drive or SAT
layer, so any testing help would be appreciated.  These changes have been
tested with Seagate Host Aware SATA drives attached to both SAS and SATA
controllers.  Also, I do not have any SATA Host Managed devices, and I
suspect that it may take additional (hopefully minor) changes to support
them.

Thanks to Seagate for supplying the test hardware and answering questions.

sbin/camcontrol/Makefile:
Add epc.c and zone.c.

sbin/camcontrol/camcontrol.8:
Document the zone and epc subcommands.

sbin/camcontrol/camcontrol.c:
Add the zone and epc subcommands.

Add auxiliary register support to build_ata_cmd().  Make sure to
set the CAM_ATAIO_NEEDRESULT, CAM_ATAIO_DMA, and CAM_ATAIO_FPDMA
flags as appropriate for ATA commands.

Add a new get_ata_status() function to parse ATA result from SCSI
sense descriptors (for ATA passthrough over SCSI) and ATA I/O
requests.

sbin/camcontrol/camcontrol.h:
Update the build_ata_cmd() prototype

Add get_ata_status(), zone(), and epc().

sbin/camcontrol/epc.c:
Support for ATA Extended Power Conditions features.  This includes
support for all features documented in the ACS-4 Revision 12
specification from t13.org (dated February 18, 2016).

The EPC feature set allows putting a drive into a power power mode
immediately, or setting timeouts so that the drive will
automatically enter progressively lower power states after various
idle times.

sbin/camcontrol/fwdownload.c:
Update the firmware download code for the new build_ata_cmd()
arguments.

sbin/camcontrol/zone.c:
Implement support for Shingled Magnetic Recording (SMR) drives
via SCSI Zoned Block Commands (ZBC) and ATA Zoned Device ATA
Command Set (ZAC).

These specs were developed in concert, and are functionally
identical.  The primary differences are due to SCSI and ATA
differences.  (SCSI is big endian, ATA is little endian, for
example.)

This includes support for all commands defined in the ZBC and
ZAC specs.

sys/cam/ata/ata_all.c:
Decode a number of additional ATA command names in ata_op_string().

Add a new CCB building function, ata_read_log().

Add ata_zac_mgmt_in() and ata_zac_mgmt_out() CCB building
functions.  These support both DMA and NCQ encapsulation.

sys/cam/ata/ata_all.h:
Add prototypes for ata_read_log(), ata_zac_mgmt_out(), and
ata_zac_mgmt_in().

sys/cam/ata/ata_da.c:
Revamp the ada(4) driver to support zoned devices.

Add four new probe states to gather information needed for zone
support.

Add a new adasetflags() function to avoid duplication of large
blocks of flag setting between the async handler and register
functions.

Add new sysctl variables that describe zone support and paramters.

Add support for the new BIO_ZONE bio, and all of its subcommands:
DISK_ZONE_OPEN, DISK_ZONE_CLOSE, DISK_ZONE_FINISH, DISK_ZONE_RWP,
DISK_ZONE_REPORT_ZONES, and DISK_ZONE_GET_PARAMS.

sys/cam/scsi/scsi_all.c:
Add command descriptions for the ZBC IN/OUT commands.

Add descriptions for ZBC Host Managed devices.

Add a new function, scsi_ata_pass() to do ATA passthrough over
SCSI.  This will eventually replace scsi_ata_pass_16() -- it
can create the 12, 16, and 32-byte variants of the ATA
PASS-THROUGH command, and supports setting all of the
registers defined as of SAT-4, Revision 5 (March 11, 2016).

Change scsi_ata_identify() to use scsi_ata_pass() instead of
scsi_ata_pass_16().

Add a new scsi_ata_read_log() function to facilitate reading
ATA logs via SCSI.

sys/cam/scsi/scsi_all.h:
Add the new ATA PASS-THROUGH(32) command CDB.  Add extended and
variable CDB opcodes.

Add Zoned Block Device Characteristics VPD page.

Add ATA Return SCSI sense descriptor.

Add prototypes for scsi_ata_read_log() and scsi_ata_pass().

sys/cam/scsi/scsi_da.c:
Revamp the da(4) driver to support zoned devices.

Add five new probe states, four of which are needed for ATA
devices.

Add five new sysctl variables that describe zone support and
parameters.

The da(4) driver supports SCSI ZBC devices, as well as ATA ZAC
devices when they are attached via a SCSI to ATA Translation (SAT)
layer.  Since ZBC -> ZAC translation is a new feature in the T10
SAT-4 spec, most SATA drives will be supported via ATA commands
sent via the SCSI ATA PASS-THROUGH command.  The da(4) driver will
prefer the ZBC interface, if it is available, for performance
reasons, but will use the ATA PASS-THROUGH interface to the ZAC
command set if the SAT layer doesn't support translation yet.
As I mentioned above, ZBC command support is untested.

Add support for the new BIO_ZONE bio, and all of its subcommands:
DISK_ZONE_OPEN, DISK_ZONE_CLOSE, DISK_ZONE_FINISH, DISK_ZONE_RWP,
DISK_ZONE_REPORT_ZONES, and DISK_ZONE_GET_PARAMS.

Add scsi_zbc_in() and scsi_zbc_out() CCB building functions.

Add scsi_ata_zac_mgmt_out() and scsi_ata_zac_mgmt_in() CCB/CDB
building functions.  Note that these have return values, unlike
almost all other CCB building functions in CAM.  The reason is
that they can fail, depending upon the particular combination
of input parameters.  The primary failure case is if the user
wants NCQ, but fails to specify additional CDB storage.  NCQ
requires using the 32-byte version of the SCSI ATA PASS-THROUGH
command, and the current CAM CDB size is 16 bytes.

sys/cam/scsi/scsi_da.h:
Add ZBC IN and ZBC OUT CDBs and opcodes.

Add SCSI Report Zones data structures.

Add scsi_zbc_in(), scsi_zbc_out(), scsi_ata_zac_mgmt_out(), and
scsi_ata_zac_mgmt_in() prototypes.

sys/dev/ahci/ahci.c:
Fix SEND / RECEIVE FPDMA QUEUED in the ahci(4) driver.

ahci_setup_fis() previously set the top bits of the sector count
register in the FIS to 0 for FPDMA commands.  This is okay for
read and write, because the PRIO field is in the only thing in
those bits, and we don't implement that further up the stack.

But, for SEND and RECEIVE FPDMA QUEUED, the subcommand is in that
byte, so it needs to be transmitted to the drive.

In ahci_setup_fis(), always set the the top 8 bits of the
sector count register.  We need it in both the standard
and NCQ / FPDMA cases.

sys/geom/eli/g_eli.c:
Pass BIO_ZONE commands through the GELI class.

sys/geom/geom.h:
Add g_io_zonecmd() prototype.

sys/geom/geom_dev.c:
Add new DIOCZONECMD ioctl, which allows sending zone commands to
disks.

sys/geom/geom_disk.c:
Add support for BIO_ZONE commands.

sys/geom/geom_disk.h:
Add a new flag, DISKFLAG_CANZONE, that indicates that a given
GEOM disk client can handle BIO_ZONE commands.

sys/geom/geom_io.c:
Add a new function, g_io_zonecmd(), that handles execution of
BIO_ZONE commands.

Add permissions check for BIO_ZONE commands.

Add command decoding for BIO_ZONE commands.

sys/geom/geom_subr.c:
Add DDB command decoding for BIO_ZONE commands.

sys/kern/subr_devstat.c:
Record statistics for REPORT ZONES commands.  Note that the
number of bytes transferred for REPORT ZONES won't quite match
what is received from the harware.  This is because we're
necessarily counting bytes coming from the da(4) / ada(4) drivers,
which are using the disk_zone.h interface to communicate up
the stack.  The structure sizes it uses are slightly different
than the SCSI and ATA structure sizes.

sys/sys/ata.h:
Add many bit and structure definitions for ZAC, NCQ, and EPC
command support.

sys/sys/bio.h:
Convert the bio_cmd field to a straight enumeration.  This will
yield more space for additional commands in the future.  After
change r297955 and other related changes, this is now possible.
Converting to an enumeration will also prevent use as a bitmask
in the future.

sys/sys/disk.h:
Define the DIOCZONECMD ioctl.

sys/sys/disk_zone.h:
Add a new API for managing zoned disks.  This is very close to
the SCSI ZBC and ATA ZAC standards, but uses integers in native
byte order instead of big endian (SCSI) or little endian (ATA)
byte arrays.

This is intended to offer to the complete feature set of the ZBC
and ZAC disk management without requiring the application developer
to include SCSI or ATA headers.  We also use one set of headers
for ioctl consumers and kernel bio-level consumers.

sys/sys/param.h:
Bump __FreeBSD_version for sys/bio.h command changes, and inclusion
of SMR support.

usr.sbin/Makefile:
Add the zonectl utility.

usr.sbin/diskinfo/diskinfo.c
Add disk zoning capability to the 'diskinfo -v' output.

usr.sbin/zonectl/Makefile:
Add zonectl makefile.

usr.sbin/zonectl/zonectl.8
zonectl(8) man page.

usr.sbin/zonectl/zonectl.c
The zonectl(8) utility.  This allows managing SCSI or ATA zoned
disks via the disk_zone.h API.  You can report zones, reset write
pointers, get parameters, etc.

Sponsored by: Spectra Logic
Differential Revision: https://reviews.freebsd.org/D6147
Reviewed by: wblock (documentation)

8 years agoDefine PCI_RES_BUS for NEW_PCIB
andrew [Thu, 19 May 2016 14:00:18 +0000 (14:00 +0000)]
Define PCI_RES_BUS for NEW_PCIB

Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation

8 years agoAllow writing IP packets of length TUNMRU no matter if TUNSIFHEAD is set
tuexen [Thu, 19 May 2016 13:52:12 +0000 (13:52 +0000)]
Allow writing IP packets of length TUNMRU no matter if TUNSIFHEAD is set
or not.

8 years agoSince PFIL can change destination address, use its always actual value
ae [Thu, 19 May 2016 12:45:20 +0000 (12:45 +0000)]
Since PFIL can change destination address, use its always actual value
from mbuf when calculating path mtu. Remove now unused finaldst variable.
Also constify dst argument in ip6_getpmtu() and ip6_getpmtu_ctl().

Reviewed by: melifaro
Obtained from: Yandex LLC
Sponsored by: Yandex LLC

8 years agoAdd ta_flags initialization in old macros missed in 300113.
mav [Thu, 19 May 2016 11:19:37 +0000 (11:19 +0000)]
Add ta_flags initialization in old macros missed in 300113.

Depending on uninitialized memory content it could cause loss of wakeup()
call in taskqueue_run_locked().

8 years agoFix bad sizeof().
hselasky [Thu, 19 May 2016 11:02:39 +0000 (11:02 +0000)]
Fix bad sizeof().

Submitted by: David Binderman <dcb314@hotmail.com>
PR: 209636

8 years agoo -f, -i, -K, -q, -v, -X flags documented.
maxim [Thu, 19 May 2016 10:56:55 +0000 (10:56 +0000)]
o -f, -i, -K, -q, -v, -X flags documented.

8 years agoo Remove EoL whitespaces.
maxim [Thu, 19 May 2016 10:39:04 +0000 (10:39 +0000)]
o Remove EoL whitespaces.

8 years agoo usage() updated for -h and -X flags.
maxim [Thu, 19 May 2016 10:37:44 +0000 (10:37 +0000)]
o usage() updated for -h and -X flags.

8 years agoRalink: Add more SoC compatible strings
sgalabov [Thu, 19 May 2016 06:29:43 +0000 (06:29 +0000)]
Ralink: Add more SoC compatible strings

Add more 'compatible' strings found in various LEDE DTS files.

Reviewed by: adrian
Approved by: adrian (mentor)
Sponsored by: Smartcom - Bulgaria AD
Differential Revision: https://reviews.freebsd.org/D6432

8 years ago[bwn] quieten the "invalid firmware state".
adrian [Thu, 19 May 2016 05:09:20 +0000 (05:09 +0000)]
[bwn] quieten the "invalid firmware state".

That pops up in the rev 5xx / 6xx microcode on the later cores
(4312, 4322.) I'm not sure why this is happening yet and I'll
dig into it, but Linux b43 does the same thing.

8 years ago[bwn] program in the MAC capabilities somewhere where later microcode
adrian [Thu, 19 May 2016 05:06:48 +0000 (05:06 +0000)]
[bwn] program in the MAC capabilities somewhere where later microcode
expects it.

Obtained from: Linux b43

8 years ago[bwn] typo.
adrian [Thu, 19 May 2016 05:06:12 +0000 (05:06 +0000)]
[bwn] typo.

8 years ago[bwn] disable rfon checks so the 2056/2057 radios are programmed.
adrian [Thu, 19 May 2016 04:48:13 +0000 (04:48 +0000)]
[bwn] disable rfon checks so the 2056/2057 radios are programmed.

This was the big missing piece for getting the BCM94322MC NIC
to work at all.

Tested:

* BCM4322, STA mode (2g, 5g)

8 years ago[bwn] improve N-PHY debuggability a little bit.
adrian [Thu, 19 May 2016 04:46:21 +0000 (04:46 +0000)]
[bwn] improve N-PHY debuggability a little bit.

8 years ago[bwn] add opt_wlan.h and opt_bwn.h to each of the phy_n source files.
adrian [Thu, 19 May 2016 04:45:50 +0000 (04:45 +0000)]
[bwn] add opt_wlan.h and opt_bwn.h to each of the phy_n source files.

8 years ago[bwn] add extra debugging.
adrian [Thu, 19 May 2016 04:29:25 +0000 (04:29 +0000)]
[bwn] add extra debugging.

8 years ago[bwn] toggle the PHY clock during chip reset.
adrian [Thu, 19 May 2016 04:28:49 +0000 (04:28 +0000)]
[bwn] toggle the PHY clock during chip reset.

Tested:

* BCM4311, STA mode
* BCM4312, STA mode
* BCM4321, STA mode
* BCM4322, STA mde

8 years ago[bwn] enable dual-phy on BCM4322MC.
adrian [Thu, 19 May 2016 04:23:54 +0000 (04:23 +0000)]
[bwn] enable dual-phy on BCM4322MC.

Tested (with later commits):

* BCM4322MC, STA mode, 2G + 5G

8 years ago[bwn] rename TGS low registers to be consistent with naming scheme.
adrian [Thu, 19 May 2016 04:22:58 +0000 (04:22 +0000)]
[bwn] rename TGS low registers to be consistent with naming scheme.

8 years ago[siba] use consistent naming.
adrian [Thu, 19 May 2016 04:11:49 +0000 (04:11 +0000)]
[siba] use consistent naming.

8 years ago[siba] implement PMU behaviour for chips with a separate PMU module.
adrian [Thu, 19 May 2016 04:11:00 +0000 (04:11 +0000)]
[siba] implement PMU behaviour for chips with a separate PMU module.

* PMU controls the clock setup
* Correctly set idle low power handling
* Use a hard-coded powerup delay for some of the newer hardware
  (including the BCM4322, which I've tested with.)

Tested:

* BCM4322, 2G + 5G STA mode

Obtained from: Linux b43 (PMU behaviour)

8 years ago[siba] handle the PMU resource setup/init for 0x4322 series chips.
adrian [Thu, 19 May 2016 04:03:41 +0000 (04:03 +0000)]
[siba] handle the PMU resource setup/init for 0x4322 series chips.

Tested (with other changes):

* BCM4322 11abgn device, chip id 0x4322.

8 years ago[siba] fix up some comments and debug output.
adrian [Thu, 19 May 2016 04:02:13 +0000 (04:02 +0000)]
[siba] fix up some comments and debug output.

8 years ago[siba] add DMA debugging section, for changes later on to DMA addressing.
adrian [Thu, 19 May 2016 04:01:33 +0000 (04:01 +0000)]
[siba] add DMA debugging section, for changes later on to DMA addressing.

8 years agoUpdate leap-seconds to leap-seconds.3661459200.
cy [Thu, 19 May 2016 03:56:07 +0000 (03:56 +0000)]
Update leap-seconds to leap-seconds.3661459200.
NO leap second will be introduced at the end of June 2016.

This commit reapplies the r298887 minor spelling fix.

Obtained from: ftp://tycho.usno.navy.mil/pub/ntp/.
See also: http://www.iers.org/SharedDocs/News/EN/BulletinC.html
MFC after: 2 weeks