2 * Copyright (c)2004 The DragonFly Project. All rights reserved.
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
8 * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
11 * Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in
13 * the documentation and/or other materials provided with the
16 * Neither the name of the DragonFly Project nor the names of its
17 * contributors may be used to endorse or promote products derived
18 * from this software without specific prior written permission.
20 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
21 * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
22 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
23 * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
24 * COPYRIGHT HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
25 * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
26 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
27 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
28 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
29 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
30 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
31 * OF THE POSSIBILITY OF SUCH DAMAGE.
36 * Installer Function : Create Subpartitions.
37 * $Id: fn_subpart.c,v 1.50 2005/04/07 20:22:40 cpressey Exp $
46 #define _(String) gettext (String)
48 #define _(String) (String)
51 #include "libaura/mem.h"
52 #include "libaura/buffer.h"
53 #include "libaura/dict.h"
54 #include "libaura/fspred.h"
56 #include "libdfui/dfui.h"
57 #include "libdfui/dump.h"
58 #include "libdfui/system.h"
60 #include "libinstaller/commands.h"
61 #include "libinstaller/diskutil.h"
62 #include "libinstaller/functions.h"
63 #include "libinstaller/uiutil.h"
67 #include "pathnames.h"
69 static int create_subpartitions(struct i_fn_args *);
70 static long default_capacity(struct storage *, int);
71 static int check_capacity(struct i_fn_args *);
72 static int check_subpartition_selections(struct dfui_response *, struct i_fn_args *);
73 static void save_subpartition_selections(struct dfui_response *, struct i_fn_args *);
74 static void populate_create_subpartitions_form(struct dfui_form *, struct i_fn_args *);
75 static int warn_subpartition_selections(struct i_fn_args *);
76 static int warn_encrypted_root(struct i_fn_args *);
77 static struct dfui_form *make_create_subpartitions_form(struct i_fn_args *);
78 static int show_create_subpartitions_form(struct dfui_form *, struct i_fn_args *);
80 static const char *def_mountpt[] = {"/", "swap", "/var", "/tmp", "/usr", "/home", NULL};
81 static int expert = 0;
84 * Given a set of subpartitions-to-be in the selected slice,
88 create_subpartitions(struct i_fn_args *a)
90 struct subpartition *sp;
91 struct commands *cmds;
95 cmds = commands_new();
96 if (!is_file("%sinstall.disklabel.%s",
98 slice_get_device_name(storage_get_selected_slice(a->s)))) {
100 * Get a copy of the 'virgin' disklabel.
101 * XXX It might make more sense for this to
102 * happen right after format_slice() instead.
104 command_add(cmds, "%s%s -r %s >%sinstall.disklabel.%s",
105 a->os_root, cmd_name(a, "DISKLABEL64"),
106 slice_get_device_name(storage_get_selected_slice(a->s)),
108 slice_get_device_name(storage_get_selected_slice(a->s)));
112 * Weave together a new disklabel out the of the 'virgin'
113 * disklabel, and the user's subpartition choices.
117 * Take everything from the 'virgin' disklabel up until the
118 * '16 partitions' line.
121 command_add(cmds, "%s%s '$2==\"partitions:\" || cut { cut = 1 } !cut { print $0 }' <%sinstall.disklabel.%s >%sinstall.disklabel",
122 a->os_root, cmd_name(a, "AWK"),
124 slice_get_device_name(storage_get_selected_slice(a->s)),
129 * # size offset fstype
130 * c: 16383969 0 unused # 7999.985MB
133 command_add(cmds, "%s%s '%d partitions:' >>%sinstall.disklabel",
134 a->os_root, cmd_name(a, "ECHO"), num_partitions ,a->tmp);
135 command_add(cmds, "%s%s '%s' >>%sinstall.disklabel",
136 a->os_root, cmd_name(a, "ECHO"),
137 "# size offset fstype",
141 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
142 sp != NULL; sp = subpartition_next(sp)) {
143 command_add(cmds, "%s%s 'mountpoint: %s device: %s'",
144 a->os_root, cmd_name(a, "ECHO"),
145 subpartition_get_mountpoint(sp),
146 subpartition_get_device_name(sp));
151 * Write a line for each subpartition the user wants.
153 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
154 sp != NULL; sp = subpartition_next(sp)) {
155 if (subpartition_is_tmpfsbacked(sp)) {
158 if (subpartition_is_swap(sp)) {
159 command_add(cmds, "%s%s ' %c:\t%s\t*\tswap' >>%sinstall.disklabel",
160 a->os_root, cmd_name(a, "ECHO"),
161 subpartition_get_letter(sp),
162 capacity_to_string(subpartition_get_capacity(sp)),
165 command_add(cmds, "%s%s ' %c:\t%s\t%s\t4.2BSD' >>%sinstall.disklabel",
166 a->os_root, cmd_name(a, "ECHO"),
167 subpartition_get_letter(sp),
168 capacity_to_string(subpartition_get_capacity(sp)),
169 subpartition_get_letter(sp) == 'a' ? "0" : "*",
173 temp_file_add(a, "install.disklabel");
176 * Label the slice from the disklabel we just wove together.
178 command_add(cmds, "%s%s -R -B -r %s %sinstall.disklabel",
179 a->os_root, cmd_name(a, "DISKLABEL64"),
180 slice_get_device_name(storage_get_selected_slice(a->s)),
184 * Create a snapshot of the disklabel we just created
185 * for debugging inspection in the log.
187 command_add(cmds, "%s%s %s",
188 a->os_root, cmd_name(a, "DISKLABEL64"),
189 slice_get_device_name(storage_get_selected_slice(a->s)));
192 * If encryption was specified, load dm(4).
194 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
195 sp != NULL; sp = subpartition_next(sp)) {
196 if (subpartition_is_encrypted(sp)) {
197 fn_get_passphrase(a);
203 * Create filesystems on the newly-created subpartitions.
205 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
206 sp != NULL; sp = subpartition_next(sp)) {
207 if (subpartition_is_swap(sp) || subpartition_is_tmpfsbacked(sp)) {
208 if (subpartition_is_swap(sp) &&
209 subpartition_is_encrypted(sp)) {
211 "%s%s -d /tmp/t1 luksFormat %sdev/%s",
212 a->os_root, cmd_name(a, "CRYPTSETUP"),
214 subpartition_get_device_name(sp));
216 "%s%s -d /tmp/t1 luksOpen %sdev/%s swap",
217 a->os_root, cmd_name(a, "CRYPTSETUP"),
219 subpartition_get_device_name(sp));
224 if (subpartition_is_encrypted(sp) &&
225 strcmp(subpartition_get_mountpoint(sp), "/") != 0) {
227 "%s%s -d /tmp/t1 luksFormat %sdev/%s",
228 a->os_root, cmd_name(a, "CRYPTSETUP"),
230 subpartition_get_device_name(sp));
232 "%s%s -d /tmp/t1 luksOpen %sdev/%s %s",
233 a->os_root, cmd_name(a, "CRYPTSETUP"),
235 subpartition_get_device_name(sp),
236 subpartition_get_mountpoint(sp) + 1);
237 command_add(cmds, "%s%s%s -b %ld -f %ld %sdev/mapper/%s",
238 a->os_root, cmd_name(a, "NEWFS"),
239 subpartition_is_softupdated(sp) ? " -U" : "",
240 subpartition_get_bsize(sp),
241 subpartition_get_fsize(sp),
243 subpartition_get_mountpoint(sp) + 1);
245 command_add(cmds, "%s%s%s -b %ld -f %ld %sdev/%s",
246 a->os_root, cmd_name(a, "NEWFS"),
247 subpartition_is_softupdated(sp) ? " -U" : "",
248 subpartition_get_bsize(sp),
249 subpartition_get_fsize(sp),
251 subpartition_get_device_name(sp));
255 result = commands_execute(a, cmds);
261 default_capacity(struct storage *s, int mtpt)
264 unsigned long capacity;
267 if (mtpt == MTPT_HOME)
270 capacity = slice_get_capacity(storage_get_selected_slice(s));
271 mem = storage_get_memsize(s);
273 if (mem > (capacity / 2) || capacity < 4096)
280 if (capacity < DISK_MIN) {
282 * For the purposes of this installer:
283 * can't be done. Sorry.
286 } else if (capacity < 4096) {
288 case MTPT_ROOT: return(320);
289 case MTPT_SWAP: return(swap);
290 case MTPT_VAR: return(128);
291 case MTPT_TMP: return(128);
292 case MTPT_USR: return(1472);
294 } else if (capacity < 10240) {
296 case MTPT_ROOT: return(640);
297 case MTPT_SWAP: return(swap);
298 case MTPT_VAR: return(256);
299 case MTPT_TMP: return(256);
300 case MTPT_USR: return(2688);
304 case MTPT_ROOT: return(768);
305 case MTPT_SWAP: return(swap);
306 case MTPT_VAR: return(256);
307 case MTPT_TMP: return(256);
308 case MTPT_USR: return(7680);
311 /* shouldn't ever happen */
316 check_capacity(struct i_fn_args *a)
318 struct subpartition *sp;
319 long min_capacity[] = {320, 0, 16, 0, 1472, 0, 0};
320 unsigned long total_capacity = 0;
323 if (subpartition_find(storage_get_selected_slice(a->s), "/usr") == NULL)
324 min_capacity[MTPT_ROOT] += min_capacity[MTPT_USR];
326 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
327 sp != NULL; sp = subpartition_next(sp)) {
328 long subpart_capacity = subpartition_get_capacity(sp);
329 const char *mountpt = subpartition_get_mountpoint(sp);
331 if (subpart_capacity == -1)
334 total_capacity += subpart_capacity;
335 for (mtpt = 0; def_mountpt[mtpt] != NULL; mtpt++) {
336 if (strcmp(mountpt, def_mountpt[mtpt]) == 0 &&
337 subpart_capacity < min_capacity[mtpt] &&
338 subpart_capacity != -1) {
339 inform(a->c, _("WARNING: The size (%ldM) specified for "
340 "the %s subpartition is too small. It "
341 "should be at least %ldM or you will "
342 "risk running out of space during "
343 "the installation."),
344 subpart_capacity, mountpt,
350 if (total_capacity > slice_get_capacity(storage_get_selected_slice(a->s))) {
351 inform(a->c, _("The space allocated to all of your selected "
352 "subpartitions (%luM) exceeds the total "
353 "capacity of the selected primary partition "
354 "(%luM). Remove some subpartitions or choose "
355 "a smaller size for them and try again."),
356 total_capacity, slice_get_capacity(storage_get_selected_slice(a->s)));
364 check_subpartition_selections(struct dfui_response *r, struct i_fn_args *a)
366 struct dfui_dataset *ds;
367 struct dfui_dataset *star_ds = NULL;
369 const char *mountpoint, *capstring;
373 int softupdates, tmpfsbacked;
376 d = aura_dict_new(1, AURA_DICT_LIST);
378 if ((ds = dfui_response_dataset_get_first(r)) == NULL) {
379 inform(a->c, _("Please set up at least one subpartition."));
383 for (ds = dfui_response_dataset_get_first(r); valid && ds != NULL;
384 ds = dfui_dataset_get_next(ds)) {
386 dfui_dataset_dump(ds);
388 mountpoint = dfui_dataset_get_value(ds, "mountpoint");
389 capstring = dfui_dataset_get_value(ds, "capacity");
393 (strcmp(dfui_dataset_get_value(ds, "softupdates"), "Y") == 0);
394 fsize = atol(dfui_dataset_get_value(ds, "fsize"));
395 bsize = atol(dfui_dataset_get_value(ds, "bsize"));
396 tmpfsbacked = (strcmp(dfui_dataset_get_value(ds, "tmpfsbacked"), "Y") == 0);
398 softupdates = (strcmp(mountpoint, "/") == 0 ? 0 : 1);
399 tmpfsbacked = (strcmp(mountpoint, "/tmp") == 0 ? 0 : 1);
404 if (aura_dict_exists(d, mountpoint, strlen(mountpoint) + 1)) {
405 inform(a->c, _("The same mount point cannot be specified "
406 "for two different subpartitions."));
410 if (strcmp(mountpoint, "/") == 0)
413 if (strcmp(capstring, "*") == 0) {
414 if (star_ds != NULL) {
415 inform(a->c, _("You cannot have more than one subpartition "
416 "with a '*' capacity (meaning 'use the remainder "
417 "of the primary partition'.)"));
424 if (!(!strcasecmp(mountpoint, "swap") || mountpoint[0] == '/')) {
425 inform(a->c, _("Mount point must be either 'swap', or it must "
426 "start with a '/'."));
430 if (strpbrk(mountpoint, " \\\"'`") != NULL) {
431 inform(a->c, _("Mount point may not contain the following "
432 "characters: blank space, backslash, or "
433 "single, double, or back quotes."));
437 if (strlen(capstring) == 0) {
438 inform(a->c, _("A capacity must be specified."));
442 if (!string_to_capacity(capstring, &capacity)) {
443 inform(a->c, _("Capacity must be either a '*' symbol to indicate "
444 "'use the rest of the primary partition', or it "
445 "must be a series of decimal digits ending with a "
446 "'M' (indicating megabytes) or a 'G' (indicating "
452 * Maybe remove this limit entirely?
454 if ((strcasecmp(mountpoint, "swap") == 0) &&
455 (capacity > SWAP_MAX)) {
456 inform(a->c, _("Swap capacity is limited to %dG."),
462 * If we made it through that obstacle course, all is well.
466 aura_dict_store(d, mountpoint, strlen(mountpoint) + 1, "", 1);
470 inform(a->c, _("You must include a / (root) subpartition."));
474 if (aura_dict_size(d) > 16) {
475 inform(a->c, _("You cannot have more than 16 subpartitions "
476 "on a single primary partition. Remove some "
487 save_subpartition_selections(struct dfui_response *r, struct i_fn_args *a)
489 struct dfui_dataset *ds;
491 const char *mountpoint, *capstring;
497 subpartitions_free(storage_get_selected_slice(a->s));
499 for (ds = dfui_response_dataset_get_first(r); valid && ds != NULL;
500 ds = dfui_dataset_get_next(ds)) {
501 mountpoint = dfui_dataset_get_value(ds, "mountpoint");
502 capstring = dfui_dataset_get_value(ds, "capacity");
506 (strcmp(dfui_dataset_get_value(ds, "softupdates"), "Y") == 0);
507 fsize = atol(dfui_dataset_get_value(ds, "fsize"));
508 bsize = atol(dfui_dataset_get_value(ds, "bsize"));
509 tmpfsbacked = (strcmp(dfui_dataset_get_value(ds, "tmpfsbacked"), "Y") == 0);
511 softupdates = (strcmp(mountpoint, "/") == 0 ? 0 : 1);
517 if (string_to_capacity(capstring, &capacity)) {
518 subpartition_new_ufs(storage_get_selected_slice(a->s),
519 mountpoint, capacity,
520 strcasecmp(dfui_dataset_get_value(ds, "encrypted"), "Y") == 0,
521 softupdates, fsize, bsize, tmpfsbacked);
527 populate_create_subpartitions_form(struct dfui_form *f, struct i_fn_args *a)
529 struct subpartition *sp;
530 struct dfui_dataset *ds;
535 if (slice_subpartition_first(storage_get_selected_slice(a->s)) != NULL) {
537 * The user has already given us their subpartition
538 * preferences, so use them here.
540 for (sp = slice_subpartition_first(storage_get_selected_slice(a->s));
541 sp != NULL; sp = subpartition_next(sp)) {
542 ds = dfui_dataset_new();
543 dfui_dataset_celldata_add(ds, "mountpoint",
544 subpartition_get_mountpoint(sp));
545 dfui_dataset_celldata_add(ds, "capacity",
546 capacity_to_string(subpartition_get_capacity(sp)));
547 dfui_dataset_celldata_add(ds, "encrypted",
548 subpartition_is_encrypted(sp) ? "Y" : "N");
550 dfui_dataset_celldata_add(ds, "softupdates",
551 subpartition_is_softupdated(sp) ? "Y" : "N");
552 dfui_dataset_celldata_add(ds, "tmpfsbacked",
553 subpartition_is_tmpfsbacked(sp) ? "Y" : "N");
554 snprintf(temp, 32, "%ld", subpartition_get_fsize(sp));
555 dfui_dataset_celldata_add(ds, "fsize",
557 snprintf(temp, 32, "%ld", subpartition_get_bsize(sp));
558 dfui_dataset_celldata_add(ds, "bsize",
561 dfui_form_dataset_add(f, ds);
565 * Otherwise, populate the form with datasets representing
566 * reasonably-calculated defaults. The defaults are chosen
567 * based on the slice's total capacity and the machine's
568 * total physical memory (for swap.)
570 for (mtpt = 0; def_mountpt[mtpt] != NULL; mtpt++) {
571 capacity = default_capacity(a->s, mtpt);
572 ds = dfui_dataset_new();
573 dfui_dataset_celldata_add(ds, "mountpoint",
575 dfui_dataset_celldata_add(ds, "capacity",
576 capacity_to_string(capacity));
577 dfui_dataset_celldata_add(ds, "encrypted", "N");
579 dfui_dataset_celldata_add(ds, "softupdates",
580 strcmp(def_mountpt[mtpt], "/") != 0 ? "Y" : "N");
581 dfui_dataset_celldata_add(ds, "tmpfsbacked",
583 dfui_dataset_celldata_add(ds, "fsize",
584 capacity < 1024 ? "1024" : "2048");
585 dfui_dataset_celldata_add(ds, "bsize",
586 capacity < 1024 ? "8192" : "16384");
588 dfui_form_dataset_add(f, ds);
594 warn_subpartition_selections(struct i_fn_args *a)
597 struct aura_buffer *omit, *consequences;
599 omit = aura_buffer_new(2048);
600 consequences = aura_buffer_new(2048);
602 valid = check_capacity(a);
603 if (subpartition_find(storage_get_selected_slice(a->s), "/var") == NULL) {
604 aura_buffer_cat(omit, "/var ");
605 aura_buffer_cat(consequences, _("/var will be a plain dir in /\n"));
607 if (subpartition_find(storage_get_selected_slice(a->s), "/usr") == NULL) {
608 aura_buffer_cat(omit, "/usr ");
609 aura_buffer_cat(consequences, _("/usr will be a plain dir in /\n"));
611 if (subpartition_find(storage_get_selected_slice(a->s), "/tmp") == NULL) {
612 aura_buffer_cat(omit, "/tmp ");
613 aura_buffer_cat(consequences, _("/tmp will be symlinked to /var/tmp\n"));
615 if (subpartition_find(storage_get_selected_slice(a->s), "/home") == NULL) {
616 aura_buffer_cat(omit, "/home ");
617 aura_buffer_cat(consequences, _("/home will be symlinked to /usr/home\n"));
620 if (valid && aura_buffer_len(omit) > 0) {
621 switch (dfui_be_present_dialog(a->c, _("Really omit?"),
622 _("Omit Subpartition(s)|Return to Create Subpartitions"),
623 _("You have elected to not have the following "
624 "subpartition(s):\n\n%s\n\n"
625 "The ramifications of these subpartition(s) being "
626 "missing will be:\n\n%s\n"
627 "Is this really what you want to do?"),
628 aura_buffer_buf(omit), aura_buffer_buf(consequences))) {
640 aura_buffer_free(omit);
641 aura_buffer_free(consequences);
647 warn_encrypted_root(struct i_fn_args *a)
650 struct subpartition *sp;
652 sp = subpartition_find(storage_get_selected_slice(a->s), "/");
656 if (subpartition_is_encrypted(sp)) {
657 switch (dfui_be_present_dialog(a->c, _("root cannot be encrypted"),
658 _("Leave root unencrypted|Return to Create Subpartitions"),
659 _("You have selected encryption for the root partition which "
660 "is not supported."))) {
662 subpartition_clr_encrypted(sp);
676 static struct dfui_form *
677 make_create_subpartitions_form(struct i_fn_args *a)
679 struct dfui_field *fi;
681 char msg_buf[1][1024];
683 snprintf(msg_buf[0], sizeof(msg_buf[0]),
684 _("Subpartitions further divide a primary partition for "
685 "use with %s. Some reasons you may want "
686 "a set of subpartitions are:\n\n"
687 "- you want to restrict how much data can be written "
688 "to certain parts of the primary partition, to quell "
689 "denial-of-service attacks; and\n"
690 "- you want to speed up access to data on the disk."
691 ""), OPERATING_SYSTEM_NAME);
693 f = dfui_form_create(
694 "create_subpartitions",
695 _("Create Subpartitions"),
696 _("Set up the subpartitions (also known as just `partitions' "
697 "in BSD tradition) you want to have on this primary "
699 "For Capacity, use 'M' to indicate megabytes, 'G' to "
700 "indicate gigabytes, or a single '*' to indicate "
701 "'use the remaining space on the primary partition'."),
705 "p", "special", "dfinstaller_create_subpartitions",
706 "p", "minimum_width","64",
708 "f", "mountpoint", _("Mountpoint"), "", "",
709 "f", "capacity", _("Capacity"), "", "",
711 "f", "encrypted", _("Encrypted"), "", "",
712 "p", "control", "checkbox",
714 "a", "ok", _("Accept and Create"), "", "",
716 (disk_get_formatted(storage_get_selected_disk(a->s)) ?
717 _("Return to Select Disk") :
718 _("Return to Select Primary Partition")), "", "",
719 "p", "accelerator", "ESC",
724 dfui_form_set_multiple(f, 1);
725 dfui_form_set_extensible(f, 1);
728 fi = dfui_form_field_add(f, "softupdates",
729 dfui_info_new(_("Softupdates"), "", ""));
730 dfui_field_property_set(fi, "control", "checkbox");
732 fi = dfui_form_field_add(f, "tmpfsbacked",
733 dfui_info_new(_("TMPFS"), "", ""));
734 dfui_field_property_set(fi, "control", "checkbox");
736 fi = dfui_form_field_add(f, "fsize",
737 dfui_info_new(_("Frag Sz"), "", ""));
739 fi = dfui_form_field_add(f, "bsize",
740 dfui_info_new(_("Block Sz"), "", ""));
742 dfui_form_action_add(f, "switch",
743 dfui_info_new(_("Switch to Normal Mode"), "", ""));
745 dfui_form_action_add(f, "switch",
746 dfui_info_new(_("Switch to Expert Mode"), "", ""));
754 * -1 = the form should be redisplayed
755 * 0 = failure, function is over
756 * 1 = success, function is over
759 show_create_subpartitions_form(struct dfui_form *f, struct i_fn_args *a)
761 struct dfui_dataset *ds;
762 struct dfui_response *r;
765 if (dfui_form_dataset_get_first(f) == NULL)
766 populate_create_subpartitions_form(f, a);
768 if (!dfui_be_present(a->c, f, &r))
771 if (strcmp(dfui_response_get_action_id(r), "cancel") == 0) {
772 dfui_response_free(r);
774 } else if (strcmp(dfui_response_get_action_id(r), "switch") == 0) {
775 if (check_subpartition_selections(r, a)) {
776 save_subpartition_selections(r, a);
777 expert = expert ? 0 : 1;
778 dfui_response_free(r);
782 if (check_subpartition_selections(r, a)) {
783 save_subpartition_selections(r, a);
784 if (!warn_subpartition_selections(a) &&
785 !warn_encrypted_root(a)) {
786 if (!create_subpartitions(a)) {
787 inform(a->c, _("The subpartitions you chose were "
788 "not correctly created, and the "
789 "primary partition may "
790 "now be in an inconsistent state. "
791 "We recommend re-formatting it "
792 "before proceeding."));
793 dfui_response_free(r);
796 dfui_response_free(r);
803 dfui_form_datasets_free(f);
804 /* dfui_form_datasets_add_from_response(f, r); */
805 for (ds = dfui_response_dataset_get_first(r); ds != NULL;
806 ds = dfui_dataset_get_next(ds)) {
807 dfui_form_dataset_add(f, dfui_dataset_dup(ds));
813 fn_create_subpartitions_ufs(struct i_fn_args *a)
820 f = make_create_subpartitions_form(a);
821 switch (show_create_subpartitions_form(f, a)) {